All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Merlijn Wajer <merlijn@wizzup.org>
Cc: Beno??t Cousson <bcousson@baylibre.com>,
	Tony Lindgren <tony@atomide.com>,
	Rob Herring <robh+dt@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jeffrey Hugo <jhugo@codeaurora.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@suse.de>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Mattias Jacobsson <2pi@mok.nu>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Mark Gross <mgross@linux.intel.com>,
	"open list:OMAP DEVICE TREE SUPPORT" <linux-omap@vger.kernel.org>,
	"open list:OMAP DEVICE TREE SUPPORT" <devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
	TOUCHSCREEN)..."  <linux-input@vger.kernel.org>
Subject: Re: [PATCH 0/2] Add SW_MACHINE_COVER key
Date: Tue, 16 Jun 2020 12:50:02 +0200	[thread overview]
Message-ID: <20200616105002.GA1718@bug> (raw)
In-Reply-To: <20200612125402.18393-1-merlijn@wizzup.org>

On Fri 2020-06-12 14:53:57, Merlijn Wajer wrote:
> this series adds the sw_machine_cover key, and changes the nokia n900 dts to
> expose the key via gpio-keys.
> 
> before, this gpio was used as card detect gpio, causing the card not to show up
> if the phone was booted without cover, see this thread on linux-omap:
> 
>     n900: remove mmc1 "safety feature"? (was: re: mmc0 on nokia n900 on linux 5.4.18)
> 
> since there is no realistic use for using this gpio as card detect, instead
> expose it to userspace via gpio-keys. there are no event type for machine covers
> yet, so add that first.
> 
> the key should be 1 when the cover is closed, and 0 when the cover is open.
> 
> starting the nokia n900 with the cover removed, putting the cover in place:
> 
>     event: time 1581684523.415296, type 5 (ev_sw), code 16 (?), value 1
> 
> removing the cover again, exposing mmc1 and the battery:
> 
>     event: time 1581684529.413706, type 5 (ev_sw), code 16 (?), value 0

Looks good to me.

Acked-by: Pavel Machek <pavel@ucw.cz>

									Pavel


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2020-06-16 10:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12 12:53 [PATCH 0/2] Add SW_MACHINE_COVER key Merlijn Wajer
2020-06-12 12:53 ` [PATCH 1/2] Input: add `SW_MACHINE_COVER` Merlijn Wajer
2020-06-16 10:50   ` Pavel Machek
2020-06-29 11:27     ` Merlijn Wajer
2020-06-29 13:36       ` input maintainer -- are you there? was " Pavel Machek
2020-06-30  5:22         ` Dmitry Torokhov
2020-06-30 17:58           ` Pavel Machek
2020-06-30 18:04             ` Tony Lindgren
2020-06-12 12:53 ` [PATCH 2/2] ARM: dts: n900: remove mmc1 card detect gpio Merlijn Wajer
2020-06-16 10:50 ` Pavel Machek [this message]
2020-06-30 19:29 ` [PATCH 0/2] Add SW_MACHINE_COVER key Dmitry Torokhov
  -- strict thread matches above, loose matches on Subject: below --
2020-02-15 17:02 Merlijn Wajer
2020-02-25 14:31 ` Tony Lindgren
2020-04-15 13:29 ` Merlijn Wajer
2020-06-08 23:56   ` Merlijn Wajer
2020-06-09 11:21     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200616105002.GA1718@bug \
    --to=pavel@ucw.cz \
    --cc=2pi@mok.nu \
    --cc=bcousson@baylibre.com \
    --cc=bp@suse.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=merlijn@wizzup.org \
    --cc=mgross@linux.intel.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.