From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF4DAC433DF for ; Tue, 16 Jun 2020 13:19:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BC3120FC3 for ; Tue, 16 Jun 2020 13:19:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EEOrDwo8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BC3120FC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlBVH-0006t1-TU for qemu-devel@archiver.kernel.org; Tue, 16 Jun 2020 09:19:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlBTL-0005wi-Tl for qemu-devel@nongnu.org; Tue, 16 Jun 2020 09:17:52 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:45947 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jlBTI-0004eq-Th for qemu-devel@nongnu.org; Tue, 16 Jun 2020 09:17:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592313467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KIAAU2x5/BG61/UOmglkIpOGCjUfoRynRyuUf8bvYtw=; b=EEOrDwo8NnhqpGGde9NPfTG7/FBJiL3guURzP2FiTeRWMJbDh/X2OjoaboyzLtW1ORRQLC uUlBd6WEzc94hnpuwT5NRxDbN9mRrfvr/tM4OWd7NDTqkETKBgtZHD9IEFm1sq4TWXaZa2 607S2FHtEdM2upcmArUJY+8W/y5/Qm4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-e7CXzQtHOoeF5JstzEwK1A-1; Tue, 16 Jun 2020 09:17:45 -0400 X-MC-Unique: e7CXzQtHOoeF5JstzEwK1A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 44BA318A8222; Tue, 16 Jun 2020 13:17:44 +0000 (UTC) Received: from localhost (unknown [10.40.208.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id B098860C05; Tue, 16 Jun 2020 13:17:37 +0000 (UTC) Date: Tue, 16 Jun 2020 15:17:35 +0200 From: Igor Mammedov To: Ani Sinha Subject: Re: [PATCH V3] Rename use_acpi_pci_hotplug to more appropriate use_acpi_hotplug_bridge Message-ID: <20200616151735.17a84340@redhat.com> In-Reply-To: <1592310699-58916-1-git-send-email-ani.sinha@nutanix.com> References: <1592310699-58916-1-git-send-email-ani.sinha@nutanix.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/16 02:01:17 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Aleksandar Markovic , ani@anisinha.ca, Philippe =?UTF-8?B?TWF0aGlldS1EYXVk?= =?UTF-8?B?w6k=?= , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 16 Jun 2020 12:31:39 +0000 Ani Sinha wrote: > Currently, the option use_acpi_pci_hotplug is being used to control device > hotplug capability using ACPI for slots of cold plugged bridges. Hence, we > are renaming this option to better reflect what it actually does. > > Signed-off-by: Ani Sinha > --- what was wrong with v2? Also for the future, can you add under --- line change log please? > hw/acpi/piix4.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c > index 85c199b..7de44bc 100644 > --- a/hw/acpi/piix4.c > +++ b/hw/acpi/piix4.c > @@ -77,7 +77,7 @@ typedef struct PIIX4PMState { > Notifier powerdown_notifier; > > AcpiPciHpState acpi_pci_hotplug; > - bool use_acpi_pci_hotplug; > + bool use_acpi_hotplug_bridge; > > uint8_t disable_s3; > uint8_t disable_s4; > @@ -204,16 +204,17 @@ static const VMStateDescription vmstate_pci_status = { > } > }; > > -static bool vmstate_test_use_acpi_pci_hotplug(void *opaque, int version_id) > +static bool vmstate_test_use_acpi_hotplug_bridge(void *opaque, int version_id) > { > PIIX4PMState *s = opaque; > - return s->use_acpi_pci_hotplug; > + return s->use_acpi_hotplug_bridge; > } > > -static bool vmstate_test_no_use_acpi_pci_hotplug(void *opaque, int version_id) > +static bool vmstate_test_no_use_acpi_hotplug_bridge(void *opaque, > + int version_id) > { > PIIX4PMState *s = opaque; > - return !s->use_acpi_pci_hotplug; > + return !s->use_acpi_hotplug_bridge; > } > > static bool vmstate_test_use_memhp(void *opaque) > @@ -290,11 +291,11 @@ static const VMStateDescription vmstate_acpi = { > VMSTATE_STRUCT_TEST( > acpi_pci_hotplug.acpi_pcihp_pci_status[ACPI_PCIHP_BSEL_DEFAULT], > PIIX4PMState, > - vmstate_test_no_use_acpi_pci_hotplug, > + vmstate_test_no_use_acpi_hotplug_bridge, > 2, vmstate_pci_status, > struct AcpiPciHpPciStatus), > VMSTATE_PCI_HOTPLUG(acpi_pci_hotplug, PIIX4PMState, > - vmstate_test_use_acpi_pci_hotplug), > + vmstate_test_use_acpi_hotplug_bridge), > VMSTATE_END_OF_LIST() > }, > .subsections = (const VMStateDescription*[]) { > @@ -528,7 +529,7 @@ I2CBus *piix4_pm_init(PCIBus *bus, int devfn, uint32_t smb_io_base, > s->smi_irq = smi_irq; > s->smm_enabled = smm_enabled; > if (xen_enabled()) { > - s->use_acpi_pci_hotplug = false; > + s->use_acpi_hotplug_bridge = false; > } > > qdev_init_nofail(dev); > @@ -593,7 +594,7 @@ static void piix4_acpi_system_hot_add_init(MemoryRegion *parent, > memory_region_add_subregion(parent, GPE_BASE, &s->io_gpe); > > acpi_pcihp_init(OBJECT(s), &s->acpi_pci_hotplug, bus, parent, > - s->use_acpi_pci_hotplug); > + s->use_acpi_hotplug_bridge); > > s->cpu_hotplug_legacy = true; > object_property_add_bool(OBJECT(s), "cpu-hotplug-legacy", > @@ -631,7 +632,7 @@ static Property piix4_pm_properties[] = { > DEFINE_PROP_UINT8(ACPI_PM_PROP_S4_DISABLED, PIIX4PMState, disable_s4, 0), > DEFINE_PROP_UINT8(ACPI_PM_PROP_S4_VAL, PIIX4PMState, s4_val, 2), > DEFINE_PROP_BOOL("acpi-pci-hotplug-with-bridge-support", PIIX4PMState, > - use_acpi_pci_hotplug, true), > + use_acpi_hotplug_bridge, true), > DEFINE_PROP_BOOL("memory-hotplug-support", PIIX4PMState, > acpi_memory_hotplug.is_enabled, true), > DEFINE_PROP_END_OF_LIST(),