From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07FD1C433E0 for ; Tue, 16 Jun 2020 16:18:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CED5B208B3 for ; Tue, 16 Jun 2020 16:18:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592324307; bh=t3syh8NXFdpKAyNciH2hnkU2ovTSPSnl0INFvSsgUww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=v7hdI7JUwU/gc+ncMAtmdfp9yVbSVJ4Kd0TxWYLSrIXQUQY67ABG3fGZGv+vN3/Z1 iQ4hmJWZ9+sWIgLcFL2gzaEXx3ODBn9F6eTKDcuCSuOt6u/Fxqrih0RihX5kdzcnKW OadeipAFTpSGECNnONOSXynmdeCVkdC8GGtKCTbM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732615AbgFPQS0 (ORCPT ); Tue, 16 Jun 2020 12:18:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:50590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730604AbgFPPiQ (ORCPT ); Tue, 16 Jun 2020 11:38:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE39820C56; Tue, 16 Jun 2020 15:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592321896; bh=t3syh8NXFdpKAyNciH2hnkU2ovTSPSnl0INFvSsgUww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0LqlLGrvwCtDebIMJ8LWhf9gd1N/egXrlLSP9H3JtNoFPwjVlK99cX9WrZBW32cAl IPAlph+vSnQ5fAN9VydhxhiJh4gq23ZAqAeQiJee1izhAqbbgrhx3w6t1SGZLyBGJJ nemPO/gh1qwOMEjJ8VEgROlknF2kMK/r3Ed1MIpw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Takashi Iwai Subject: [PATCH 5.4 058/134] ALSA: pcm: disallow linking stream to itself Date: Tue, 16 Jun 2020 17:34:02 +0200 Message-Id: <20200616153103.552524198@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200616153100.633279950@linuxfoundation.org> References: <20200616153100.633279950@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michał Mirosław commit 951e2736f4b11b58dc44d41964fa17c3527d882a upstream. Prevent SNDRV_PCM_IOCTL_LINK linking stream to itself - the code can't handle it. Fixed commit is not where bug was introduced, but changes the context significantly. Cc: stable@vger.kernel.org Fixes: 0888c321de70 ("pcm_native: switch to fdget()/fdput()") Signed-off-by: Michał Mirosław Link: https://lore.kernel.org/r/89c4a2487609a0ed6af3ecf01cc972bdc59a7a2d.1591634956.git.mirq-linux@rere.qmqm.pl Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/core/pcm_native.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -1994,6 +1994,12 @@ static int snd_pcm_link(struct snd_pcm_s } pcm_file = f.file->private_data; substream1 = pcm_file->substream; + + if (substream == substream1) { + res = -EINVAL; + goto _badf; + } + group = kzalloc(sizeof(*group), GFP_KERNEL); if (!group) { res = -ENOMEM;