From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6762603767822562791==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [linux-next:master 1232/1691] drivers/mtd/nand/raw/tango_nand.c:348:35: warning: Clarify calculation precedence for '&' and Date: Tue, 16 Jun 2020 20:54:36 +0800 Message-ID: <202006162032.PMTpbd4e%lkp@intel.com> List-Id: --===============6762603767822562791== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git= master head: 27f70ec4fa0e0f419031f1b8d61b1a788244e313 commit: d8ed345a4c622657638b740415c6f73b26bfd132 [1232/1691] mtd: rawnand: = tango: Convert the driver to exec_op() compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot cppcheck warnings: (new ones prefixed by >>) >> drivers/mtd/nand/raw/tango_nand.c:348:35: warning: Clarify calculation p= recedence for '&' and '?'. [clarifyCalculation] return status & NAND_STATUS_FAIL ? -EIO : 0; ^ vim +348 drivers/mtd/nand/raw/tango_nand.c 319 = 320 static int tango_write_page(struct nand_chip *chip, const u8 *buf, 321 int oob_required, int page) 322 { 323 struct mtd_info *mtd =3D nand_to_mtd(chip); 324 struct tango_nfc *nfc =3D to_tango_nfc(chip->controller); 325 const struct nand_sdr_timings *timings; 326 int err, len =3D mtd->writesize; 327 u8 status; 328 = 329 /* Calling tango_write_oob() would send PAGEPROG twice */ 330 if (oob_required) 331 return -ENOTSUPP; 332 = 333 tango_select_target(chip, chip->cur_cs); 334 writel_relaxed(0xffffffff, nfc->mem_base + METADATA); 335 err =3D do_dma(nfc, DMA_TO_DEVICE, NFC_WRITE, buf, len, page); 336 if (err) 337 return err; 338 = 339 timings =3D nand_get_sdr_timings(&chip->data_interface); 340 err =3D tango_waitrdy(chip, PSEC_TO_MSEC(timings->tR_max)); 341 if (err) 342 return err; 343 = 344 err =3D nand_status_op(chip, &status); 345 if (err) 346 return err; 347 = > 348 return status & NAND_STATUS_FAIL ? -EIO : 0; 349 } 350 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============6762603767822562791==--