All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Xin Long <lucien.xin@gmail.com>
Cc: netdev@vger.kernel.org,
	Steffen Klassert <steffen.klassert@secunet.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Sabrina Dubroca <sd@queasysnail.net>
Subject: Re: [PATCH ipsec-next 02/10] tunnel4: add cb_handler to struct xfrm_tunnel
Date: Wed, 17 Jun 2020 09:19:05 -0700	[thread overview]
Message-ID: <20200617091905.2b007939@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <5a63a0c47cc71476786873cbd32db8db3c0f7d1e.1592328814.git.lucien.xin@gmail.com>

On Wed, 17 Jun 2020 01:36:27 +0800 Xin Long wrote:
> This patch is to register a callback function tunnel4_rcv_cb with
> is_ipip set in a xfrm_input_afinfo object for tunnel4 and tunnel64.
> 
> It will be called by xfrm_rcv_cb() from xfrm_input() when family
> is AF_INET and proto is IPPROTO_IPIP or IPPROTO_IPV6.
> 
> Signed-off-by: Xin Long <lucien.xin@gmail.com>

Please make sure W=1 C=1 builds don't add new warnings:

net/ipv4/tunnel4.c:118:14: warning: incorrect type in assignment (different address spaces)
net/ipv4/tunnel4.c:118:14:    expected struct xfrm_tunnel *head
net/ipv4/tunnel4.c:118:14:    got struct xfrm_tunnel [noderef] <asn:4> *
net/ipv4/tunnel4.c:120:9: error: incompatible types in comparison expression (different address spaces):
net/ipv4/tunnel4.c:120:9:    struct xfrm_tunnel [noderef] <asn:4> *
net/ipv4/tunnel4.c:120:9:    struct xfrm_tunnel *

  parent reply	other threads:[~2020-06-17 16:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-16 17:36 [PATCH ipsec-next 00/10] xfrm: support ipip and ipv6 tunnels in vti and xfrmi Xin Long
2020-06-16 17:36 ` [PATCH ipsec-next 01/10] xfrm: add is_ipip to struct xfrm_input_afinfo Xin Long
2020-06-16 17:36   ` [PATCH ipsec-next 02/10] tunnel4: add cb_handler to struct xfrm_tunnel Xin Long
2020-06-16 17:36     ` [PATCH ipsec-next 03/10] tunnel6: add tunnel6_input_afinfo for ipip and ipv6 tunnels Xin Long
2020-06-16 17:36       ` [PATCH ipsec-next 04/10] ip_vti: support IPIP tunnel processing with .cb_handler Xin Long
2020-06-16 17:36         ` [PATCH ipsec-next 05/10] ip_vti: support IPIP6 tunnel processing Xin Long
2020-06-16 17:36           ` [PATCH ipsec-next 06/10] ip6_vti: support IP6IP6 tunnel processing with .cb_handler Xin Long
2020-06-16 17:36             ` [PATCH ipsec-next 07/10] ip6_vti: support IP6IP tunnel processing Xin Long
2020-06-16 17:36               ` [PATCH ipsec-next 08/10] ipcomp: assign if_id to child tunnel from parent tunnel Xin Long
2020-06-16 17:36                 ` [PATCH ipsec-next 09/10] xfrm: interface: support IP6IP6 and IP6IP tunnels processing with .cb_handler Xin Long
2020-06-16 17:36                   ` [PATCH ipsec-next 10/10] xfrm: interface: support IPIP and IPIP6 " Xin Long
2020-06-17 16:19       ` [PATCH ipsec-next 03/10] tunnel6: add tunnel6_input_afinfo for ipip and ipv6 tunnels Jakub Kicinski
2020-06-22  8:30         ` Xin Long
2020-06-17 16:19     ` Jakub Kicinski [this message]
2020-06-22  8:29       ` [PATCH ipsec-next 02/10] tunnel4: add cb_handler to struct xfrm_tunnel Xin Long
2020-06-22 13:16     ` Sabrina Dubroca
2020-06-22 17:18       ` Xin Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617091905.2b007939@kicinski-fedora-PC1C0HJN \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=sd@queasysnail.net \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.