From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E38DC433E0 for ; Wed, 17 Jun 2020 11:47:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2298E21556 for ; Wed, 17 Jun 2020 11:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592394446; bh=c3/QWnFt5iLGaQTofmcr61auxhK/9/ececAXtvcpTyw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FPy+BJyvjfMwacy25J4IdL39Kb7EW4C7GNuSL7Bs1DA182h44YgLQc4gFLZQgQKgm 0pgh5iw0ItFjbfvTSusbT+TPzagHU0hsY2285HVJ0L851GkoFQYGmF9AFK+FAAZFdz 2hYtpu6PH1nYL25wia8EZddeRwmJpd1XAFEw/VTE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726331AbgFQLrZ (ORCPT ); Wed, 17 Jun 2020 07:47:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:57952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725967AbgFQLrZ (ORCPT ); Wed, 17 Jun 2020 07:47:25 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EBFE5207DD; Wed, 17 Jun 2020 11:47:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592394444; bh=c3/QWnFt5iLGaQTofmcr61auxhK/9/ececAXtvcpTyw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=14UpedtYLNDUXYNj3lMDMpr6FtOfPmEKPZlQOxSOtExirPznMhHAzsBBji3hG3E8q pDpM3mgMknuYGDeMfKD0oV0r99P+fuXb+FGAAMfrxjzkNlGu1SKIqTRM8CISEwRq/m MKFMrWwVXuKcPBHZlBz5WQrUrWhGbz15wQHYbpks= Date: Wed, 17 Jun 2020 12:47:22 +0100 From: Mark Brown To: Sumit Semwal Cc: agross@kernel.org, Bjorn Andersson , lgirdwood@gmail.com, robh+dt@kernel.org, Nisha Kumari , linux-arm-msm@vger.kernel.org, LKML , devicetree@vger.kernel.org, kgunda@codeaurora.org, Rajendra Nayak Subject: Re: [PATCH v4 4/5] regulator: qcom: Add labibb driver Message-ID: <20200617114721.GD4613@sirena.org.uk> References: <20200602100924.26256-1-sumit.semwal@linaro.org> <20200602100924.26256-5-sumit.semwal@linaro.org> <20200602113241.GE5684@sirena.org.uk> <20200602122554.GG5684@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UoPmpPX/dBe4BELn" Content-Disposition: inline In-Reply-To: X-Cookie: This fortune is false. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org --UoPmpPX/dBe4BELn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 17, 2020 at 05:12:35PM +0530, Sumit Semwal wrote: > I understand from a pure regulators' correctness point of view, > ENABLE_CTL should be the one checked there, so I can change the patch > as you suggested, but there seems to be some performance penalty > there. I thought the goal was to have the performance penalty to ensure that the regulator had actually started? > > > The WARN_ON? This was suggested by Bjorn to catch the case where the > > > DT binding for a PMIC instantiates only one of the regulators. > > No, this whole loop - why this whole match and get child stuff? > This loop mechanism is what I saw in the other qcom regulators > upstream, so thought it was an acceptable way. > For the two children nodes, do you recommend another mechanism to get > and validate both nodes? I don't understand what you mean by "two children nodes" here? --UoPmpPX/dBe4BELn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7qAskACgkQJNaLcl1U h9CwHwf8D6plSnWpJBT6fOA9ZBPP/820nVYr3A+7su56CgW5U+Q0a0fYck3zmpG/ WbNQm/poaHawCTQsmd6YQGs7SnBaVIJs5xyLmEtsX65EjP4jo+sYuN1/RWio+KIs 3qupZj3mYWLAVYUrsVq0nKDlrjcorsbT3Kpe/Yzg1TIg2ZYU9kwIrDvDowKkwSvD L3oj9fzDokGBGyl8PQd/xCGuM92IrGASoUZeWbYdXfMf0BZxZ0tXN53TmwLE1Ybg P8k94OIRbwx4z4HyNxpsy0+mKBwd3kLRIhyAwCZT+HJH13V4OrF5NfoEt3+e58TN 17C2i1cB4rfV/cHQLvJ6zkqLykqrZw== =DTZm -----END PGP SIGNATURE----- --UoPmpPX/dBe4BELn--