From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE8DC433DF for ; Thu, 18 Jun 2020 09:56:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD39D217A0 for ; Thu, 18 Jun 2020 09:56:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728236AbgFRJ4G (ORCPT ); Thu, 18 Jun 2020 05:56:06 -0400 Received: from foss.arm.com ([217.140.110.172]:47154 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728137AbgFRJ4F (ORCPT ); Thu, 18 Jun 2020 05:56:05 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D05FC31B; Thu, 18 Jun 2020 02:56:04 -0700 (PDT) Received: from e107158-lin.cambridge.arm.com (e107158-lin.cambridge.arm.com [10.1.195.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 81AA13F6CF; Thu, 18 Jun 2020 02:56:03 -0700 (PDT) Date: Thu, 18 Jun 2020 10:56:01 +0100 From: Qais Yousef To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Alan Stern , Tony Prisk , Greg Kroah-Hartman , Mathias Nyman , Oliver Neukum , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.7 229/388] usb/ohci-platform: Fix a warning when hibernating Message-ID: <20200618095600.umb4gyegy2hszlep@e107158-lin.cambridge.arm.com> References: <20200618010805.600873-1-sashal@kernel.org> <20200618010805.600873-229-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200618010805.600873-229-sashal@kernel.org> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sasha/Alan On 06/17/20 21:05, Sasha Levin wrote: [...] > diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c > index 7addfc2cbadc..4a8456f12a73 100644 > --- a/drivers/usb/host/ohci-platform.c > +++ b/drivers/usb/host/ohci-platform.c > @@ -299,6 +299,11 @@ static int ohci_platform_resume(struct device *dev) > } > > ohci_resume(hcd, false); > + > + pm_runtime_disable(dev); > + pm_runtime_set_active(dev); > + pm_runtime_enable(dev); > + I am not sure what's the protocol here, but the series was fixing similar problems to this driver but I didn't myself directly observe a warning because of that. https://lore.kernel.org/lkml/20200518154931.6144-2-qais.yousef@arm.com/ https://lore.kernel.org/lkml/20200518154931.6144-3-qais.yousef@arm.com/ So just pointing it out in case they're worth backporting to stable too. Thanks -- Qais Yousef From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6003C433E0 for ; Thu, 18 Jun 2020 09:56:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7126C21548 for ; Thu, 18 Jun 2020 09:56:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="graMzJhE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7126C21548 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xC9DUnBNmalt3FrtCDBj6XZQbq+3GVC3K+46sTWBZHA=; b=graMzJhEi/Zh4U LrmB0EJq3o/uAJBLMASvkdYyDdTfw8J7BQuQeqo/VZCSAjP/cSv5OtVaoSRUrRR88t9KjtlYIEJG5 1E0u4V3aLD7varuEuwmtXTmp5R1UIcYq8iBiToy9RmXmM83lmSihBfQGWVmM9+7KELrkLkZQaRGPh cumPyJr6jqXwCzR1AFjcaKRk29erRz/qj679F9U2/8ysoG2DDwhtIIab60y5OU3UWYtAqBw7oDTMM Xxb3Mi7VKeQFDa/mYtYNVbo2ZJ7bH96GG/kwcY4oDbf/ZBfTB+KTI+1qL427suEwp0XpuBEWI7ECN IAyvLDaRzgEQF+h/zcyg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlrHG-0000pt-G1; Thu, 18 Jun 2020 09:56:10 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlrHD-0000pG-NP for linux-arm-kernel@lists.infradead.org; Thu, 18 Jun 2020 09:56:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D05FC31B; Thu, 18 Jun 2020 02:56:04 -0700 (PDT) Received: from e107158-lin.cambridge.arm.com (e107158-lin.cambridge.arm.com [10.1.195.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 81AA13F6CF; Thu, 18 Jun 2020 02:56:03 -0700 (PDT) Date: Thu, 18 Jun 2020 10:56:01 +0100 From: Qais Yousef To: Sasha Levin Subject: Re: [PATCH AUTOSEL 5.7 229/388] usb/ohci-platform: Fix a warning when hibernating Message-ID: <20200618095600.umb4gyegy2hszlep@e107158-lin.cambridge.arm.com> References: <20200618010805.600873-1-sashal@kernel.org> <20200618010805.600873-229-sashal@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200618010805.600873-229-sashal@kernel.org> User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200618_025607_808503_9A1DDF8B X-CRM114-Status: GOOD ( 10.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oliver Neukum , Mathias Nyman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tony Prisk , Alan Stern , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sasha/Alan On 06/17/20 21:05, Sasha Levin wrote: [...] > diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c > index 7addfc2cbadc..4a8456f12a73 100644 > --- a/drivers/usb/host/ohci-platform.c > +++ b/drivers/usb/host/ohci-platform.c > @@ -299,6 +299,11 @@ static int ohci_platform_resume(struct device *dev) > } > > ohci_resume(hcd, false); > + > + pm_runtime_disable(dev); > + pm_runtime_set_active(dev); > + pm_runtime_enable(dev); > + I am not sure what's the protocol here, but the series was fixing similar problems to this driver but I didn't myself directly observe a warning because of that. https://lore.kernel.org/lkml/20200518154931.6144-2-qais.yousef@arm.com/ https://lore.kernel.org/lkml/20200518154931.6144-3-qais.yousef@arm.com/ So just pointing it out in case they're worth backporting to stable too. Thanks -- Qais Yousef _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel