All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
Subject: [PATCH 00/13] ALSA: hda: Use LED classdev for mute controls consistently
Date: Thu, 18 Jun 2020 13:08:29 +0200	[thread overview]
Message-ID: <20200618110842.27238-1-tiwai@suse.de> (raw)

Hi,

this is a patch set inspired by the recent patch Kai-Heng posted about
the HD-audio mic-mute LED control.  Currently HD-audio driver deals
with the mute and mic-mute LED in several different ways: primarily
with the direct callback of vmaster hook and capture sync hook, while
another with the LED class device binding.  The latter has been used
for binding with the platform device LEDs like Thinkpad, Dell,
Huawei.  And, yet, recently we added our own LED classdev for the
mic-mute LED on some HP systems although they are controlled directly
with the callback; it's exposed, however, for the DMIC that is
governed by a different ASoC driver.

This patch set is an attempt to sort out and make them consistent:
namely, 
* All LEDs are now controlled via LED class device
* The generic driver provides helper functions to easily build up the
  LED class dev and the relevant mixer controls
* Conversion of the existing framework and clean ups

The patches are lightly tested in my side with a couple of machines
and also through hda-emu tests.  Some devices receive new kcontrols
for the mute LED behavior (that have been missing so far), but
anything else look good though my tests.


thanks,

Takashi

===

Takashi Iwai (13):
  ALSA: hda: generic: Always call led-trigger for mic mute LED
  ALSA: hda: generic: Add a helper for mic-mute LED with LED classdev
  ALSA: hda/realtek: Convert to cdev-variant of mic-mute LED controls
  ALSA: hda/conexant: Convert to cdev-variant of mic-mute LED controls
  ALSA: hda/sigmatel: Convert to cdev-variant of mic-mute LED controls
  ALSA: hda: generic: Drop unused snd_hda_gen_fixup_micmute_led()
  ALSA: hda: generic: Drop the old mic-mute LED hook
  ALSA: hda: generic: Add vmaster mute LED helper
  ALSA: hda/realtek: Use the new vmaster mute LED helper
  ALSA: hda/conexant: Use the new vmaster mute LED helper
  ALSA: hda/sigmatel: Use the new vmaster mute LED helper
  ALSA: hda/realtek: Unify LED helper code
  ALSA: hda: Let LED cdev handling suspend/resume

 sound/pci/hda/Kconfig           |   9 ++
 sound/pci/hda/hda_generic.c     | 134 ++++++++++++++++--------
 sound/pci/hda/hda_generic.h     |  13 ++-
 sound/pci/hda/patch_conexant.c  |  47 ++++-----
 sound/pci/hda/patch_realtek.c   | 220 +++++++++++++++++++---------------------
 sound/pci/hda/patch_sigmatel.c  |  22 ++--
 sound/pci/hda/thinkpad_helper.c |  19 +---
 7 files changed, 248 insertions(+), 216 deletions(-)

-- 
2.16.4


             reply	other threads:[~2020-06-18 11:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 11:08 Takashi Iwai [this message]
2020-06-18 11:08 ` [PATCH 01/13] ALSA: hda: generic: Always call led-trigger for mic mute LED Takashi Iwai
2020-06-18 11:08 ` [PATCH 02/13] ALSA: hda: generic: Add a helper for mic-mute LED with LED classdev Takashi Iwai
2020-06-18 11:08 ` [PATCH 03/13] ALSA: hda/realtek: Convert to cdev-variant of mic-mute LED controls Takashi Iwai
2020-06-18 11:08 ` [PATCH 04/13] ALSA: hda/conexant: " Takashi Iwai
2020-06-18 11:08 ` [PATCH 05/13] ALSA: hda/sigmatel: " Takashi Iwai
2020-06-18 11:08 ` [PATCH 06/13] ALSA: hda: generic: Drop unused snd_hda_gen_fixup_micmute_led() Takashi Iwai
2020-06-18 11:08 ` [PATCH 07/13] ALSA: hda: generic: Drop the old mic-mute LED hook Takashi Iwai
2020-06-18 11:08 ` [PATCH 08/13] ALSA: hda: generic: Add vmaster mute LED helper Takashi Iwai
2020-06-18 11:08 ` [PATCH 09/13] ALSA: hda/realtek: Use the new " Takashi Iwai
2020-06-18 11:08 ` [PATCH 10/13] ALSA: hda/conexant: " Takashi Iwai
2020-06-18 11:08 ` [PATCH 11/13] ALSA: hda/sigmatel: " Takashi Iwai
2020-06-18 11:08 ` [PATCH 12/13] ALSA: hda/realtek: Unify LED helper code Takashi Iwai
2020-06-18 11:08 ` [PATCH 13/13] ALSA: hda: Let LED cdev handling suspend/resume Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200618110842.27238-1-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=kai.heng.feng@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.