From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1ACBC433E0 for ; Thu, 18 Jun 2020 11:47:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 811F0207D8 for ; Thu, 18 Jun 2020 11:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592480857; bh=Z4xemjOxoFNTIwYejBs/U0AFA9s0atEhKgOvdDcpg9I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ZYE5B4+ILPfWCJPZT4olRbOPfyQmhv2A484SugSQSFN03mJHF5+OusEK5pXt6Y65c qpmTVW3PNfsQX9t13SulJD+2NwMfFPp2S9otE4giRXa6lrfPPp2A6a2uD8Rvui9/Ao izrhMu32tUzkqm3VIRj5ke9OpKQkll2ZWHiwswgE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728711AbgFRLrg (ORCPT ); Thu, 18 Jun 2020 07:47:36 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55874 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726946AbgFRLrf (ORCPT ); Thu, 18 Jun 2020 07:47:35 -0400 Received: by mail-wm1-f67.google.com with SMTP id a6so1500385wmm.5; Thu, 18 Jun 2020 04:47:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=cFsUtUBh9aNFVLDZvQX6B8teUAK1O+/w59Gia3tUevI=; b=UIavvTuUV3TtIWA7NBTcW8BopGXpR8Ee67G4npmHhCj8q9TWeVtZOGZtuGtMK3Nfim u7aL0ZLXJ4i+VJwj118/s2ZfUulM4AeZjTU4YkUZibWbgaFE+dllejMxI53OjUgnYxDb ZQ6fP7EMpgOcomO+GYcHXzowtD/6DGgW1ENxK0Ws3OeqW4bBNWuar832Bn6Z3B348Ao6 Mq4HLAMyzcdqmQrgtG1clY97wPfFjecKS4qSjHyqiszwaB1aTkyaU62Kxlv5YGak0zPm J7fQV43+Xx0ju7fUC/++sNeY7uP4zeHRF+azOsDRLGK5G6aJl8usiAK16djNBwQM+hC1 cmQg== X-Gm-Message-State: AOAM532uAme8PeXUMUBt4pCgqKXz/HKf8GnNUGg36RH6B6xWrhlGnAMN vNBvawzjqFBJLmQYOXCg8+U= X-Google-Smtp-Source: ABdhPJwS415YB/rJb+NXaXvRVl2d4Aq2pYtG+WgCBUB3ffY8PwvYaxMgTUxFb9zCbuYH2eSiqEaltQ== X-Received: by 2002:a1c:3b43:: with SMTP id i64mr3792942wma.112.1592480852025; Thu, 18 Jun 2020 04:47:32 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id u7sm3299615wrm.23.2020.06.18.04.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 04:47:31 -0700 (PDT) Date: Thu, 18 Jun 2020 11:47:29 +0000 From: Wei Liu To: Christoph Hellwig Cc: Andrew Morton , Dexuan Cui , Vitaly Kuznetsov , Peter Zijlstra , Catalin Marinas , Will Deacon , Jessica Yu , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-mm@kvack.org, Wei Liu Subject: Re: [PATCH 1/3] x86/hyperv: allocate the hypercall page with only read and execute bits Message-ID: <20200618114729.bnut7gbj2j4uhjnc@liuwe-devbox-debian-v2> References: <20200618064307.32739-1-hch@lst.de> <20200618064307.32739-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200618064307.32739-2-hch@lst.de> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 18, 2020 at 08:43:05AM +0200, Christoph Hellwig wrote: > Avoid a W^X violation cause by the fact that PAGE_KERNEL_EXEC includes the > writable bit. > > For this resurrect the removed PAGE_KERNEL_RX definitіon, but as > PAGE_KERNEL_ROX to match arm64 and powerpc. > > Fixes: 78bb17f76edc ("x86/hyperv: use vmalloc_exec for the hypercall page") > Reported-by: Dexuan Cui > Signed-off-by: Christoph Hellwig > Tested-by: Vitaly Kuznetsov Acked-by: Wei Liu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31310C433E0 for ; Thu, 18 Jun 2020 11:47:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEBB0207D8 for ; Thu, 18 Jun 2020 11:47:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gppamWac" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEBB0207D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=03XX+IFyLvqx38rMDbx9yB/mxTwXyre2CrLUXhQjaR8=; b=gppamWac6j5CdX kcHYM7MOvqW/8e8ACXMkAU8u2Fmm/JlZHz/a1YELovH0VWBk0yY5TLCkyIFCXwFd/HfXVyMjF6e/g 2mOONA9W972N8rd3kxHzl74P7MsjSBb1ZeJdndvq24RFBzg1GIeB2HL8ef+6AnSvpKjYRIjFTZCcu y/w9tD15NoTc4+0QXMkw+Jn44qz24+XK+PGxvxDtzLvMdQj0IL0+oXpDnOswURW+L5qBj2RU+e/9A SN4gkLzHhbAo0ROZbO2HrTIhg1TjP258/c6QRjBROlIEDYf+TeIhjU/OQtreGxiZjUQ7s3kQSaH7H WfS/U6a3zxTFI+lKb7kA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlt16-0003mj-RT; Thu, 18 Jun 2020 11:47:36 +0000 Received: from mail-wm1-f65.google.com ([209.85.128.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlt13-0003mG-Tg for linux-arm-kernel@lists.infradead.org; Thu, 18 Jun 2020 11:47:35 +0000 Received: by mail-wm1-f65.google.com with SMTP id b82so4889749wmb.1 for ; Thu, 18 Jun 2020 04:47:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=cFsUtUBh9aNFVLDZvQX6B8teUAK1O+/w59Gia3tUevI=; b=TRxJXFMe4b/r8ZcL+K+4pGYeW+0ijapOkunL87Z3QJ8t7QZm+VKc7IHK8cYeckJiIc I4DOad3u0YFEPj23Q7uXWkxv9Go4ktmDvBA5EkyMknYNNwjKKOweFTVTEFFUU5MB35Uh FPnP5qJ1tTwA3QUpxdL90E0E1dH7w35e+rVKPu0hkHVjenfXJzguV2IG4opgUplOlmdn tLB0Ia0pi66ElsO/AWh7t+yF5CnfS5FJC4mHQgJIJ35EcnruRlZpLwst6j4NsyNE9pHi 2FMhuqdE4sizkeSUbBkB1fW/VLDeaKLdx/zGnqBmbbfvlgJMqrXh9klnwKFC7/QOS+IZ vC2g== X-Gm-Message-State: AOAM5308T4mokY/j7OZ8lDYytGaY+9XGEtgOW+wC3cgU01j8ogK9/+IY uGeTRpDQUXaTA7KBOEBtChQ= X-Google-Smtp-Source: ABdhPJwS415YB/rJb+NXaXvRVl2d4Aq2pYtG+WgCBUB3ffY8PwvYaxMgTUxFb9zCbuYH2eSiqEaltQ== X-Received: by 2002:a1c:3b43:: with SMTP id i64mr3792942wma.112.1592480852025; Thu, 18 Jun 2020 04:47:32 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id u7sm3299615wrm.23.2020.06.18.04.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 04:47:31 -0700 (PDT) Date: Thu, 18 Jun 2020 11:47:29 +0000 From: Wei Liu To: Christoph Hellwig Subject: Re: [PATCH 1/3] x86/hyperv: allocate the hypercall page with only read and execute bits Message-ID: <20200618114729.bnut7gbj2j4uhjnc@liuwe-devbox-debian-v2> References: <20200618064307.32739-1-hch@lst.de> <20200618064307.32739-2-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200618064307.32739-2-hch@lst.de> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200618_044733_953265_280C14CA X-CRM114-Status: GOOD ( 10.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, Peter Zijlstra , Catalin Marinas , x86@kernel.org, Dexuan Cui , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Wei Liu , Jessica Yu , Andrew Morton , Will Deacon , Vitaly Kuznetsov , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKdW4gMTgsIDIwMjAgYXQgMDg6NDM6MDVBTSArMDIwMCwgQ2hyaXN0b3BoIEhlbGx3 aWcgd3JvdGU6Cj4gQXZvaWQgYSBXXlggdmlvbGF0aW9uIGNhdXNlIGJ5IHRoZSBmYWN0IHRoYXQg UEFHRV9LRVJORUxfRVhFQyBpbmNsdWRlcyB0aGUKPiB3cml0YWJsZSBiaXQuCj4gCj4gRm9yIHRo aXMgcmVzdXJyZWN0IHRoZSByZW1vdmVkIFBBR0VfS0VSTkVMX1JYIGRlZmluaXTRlm9uLCBidXQg YXMKPiBQQUdFX0tFUk5FTF9ST1ggdG8gbWF0Y2ggYXJtNjQgYW5kIHBvd2VycGMuCj4gCj4gRml4 ZXM6IDc4YmIxN2Y3NmVkYyAoIng4Ni9oeXBlcnY6IHVzZSB2bWFsbG9jX2V4ZWMgZm9yIHRoZSBo eXBlcmNhbGwgcGFnZSIpCj4gUmVwb3J0ZWQtYnk6IERleHVhbiBDdWkgPGRlY3VpQG1pY3Jvc29m dC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+Cj4g VGVzdGVkLWJ5OiBWaXRhbHkgS3V6bmV0c292IDx2a3V6bmV0c0ByZWRoYXQuY29tPgoKQWNrZWQt Ynk6IFdlaSBMaXUgPHdlaS5saXVAa2VybmVsLm9yZz4KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK