From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88546C433E0 for ; Thu, 18 Jun 2020 12:37:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54AE12070A for ; Thu, 18 Jun 2020 12:37:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="Vba3/YBp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729803AbgFRMhs (ORCPT ); Thu, 18 Jun 2020 08:37:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729409AbgFRMhq (ORCPT ); Thu, 18 Jun 2020 08:37:46 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A7B4C0613EE for ; Thu, 18 Jun 2020 05:37:46 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id t194so5472644wmt.4 for ; Thu, 18 Jun 2020 05:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OgZomFoj/7toYCBCKWRo7nq/kYdKAWeXt05LtEajY3k=; b=Vba3/YBp135F4zjZnb2RedWXF2lwu1lFFL34CLaNpxPjPTPlt0UR472eYi5S4YZ1Wx Z0rDK+6Hs9d3o0cUOdxwi2SS36Jq5bWlnav7DNmZNgJpcMQ+D8caGFIGg/ORh0SmmPxl k69/g/gWD8TgMCYkGiY2Wz/GRty0LMQ/SrbXk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OgZomFoj/7toYCBCKWRo7nq/kYdKAWeXt05LtEajY3k=; b=M8HJaQogGJLV/HSDXX7iAwu+1uX3phQpBqpqm4dAuE7qZgylApkQFaMmEMC9txiWcN yQGKAUIbDOllJs0kna4XI7iGKkjbM8eZz5STonYU+UDqPlmvprLTsOJOVxAl4Ko51ewb iPCHD+v/0Ye4nneJcJ51E/STFJVGNGLQkej5bHpzNkHbQw/RL1JGzki82Z26HkcxbV+8 IYdc3mbTNZmAdnj4s6jIlOyr703uTg4CM1kvHEA0H+nj58JVqvyta+WJBJNuBztaqXzL gzXsjODyB3zwDYEf4KgXw3ig7oB2JVN9cMwRKE5VTH+zuriXGkRvekw5Gney2bRK1tEb QgVQ== X-Gm-Message-State: AOAM532dxzRuNhfa7eXTh3ndemgEtICo/r1l8gfHK1zPnBC3NdC4MsUb fgPLAI2A08EEqpQNF49Hr9FU5Q== X-Google-Smtp-Source: ABdhPJzFoWSkp2MqAS0xx92RSUWbWQ0U7Z92SQ/MTtOdoN5z3gnxoKRC/r81z8qHIYMjhulYtZARyw== X-Received: by 2002:a1c:4143:: with SMTP id o64mr3734793wma.157.1592483864725; Thu, 18 Jun 2020 05:37:44 -0700 (PDT) Received: from localhost ([2a01:4b00:8432:8a00:63de:dd93:20be:f460]) by smtp.gmail.com with ESMTPSA id t82sm2586962wmg.10.2020.06.18.05.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 05:37:43 -0700 (PDT) Date: Thu, 18 Jun 2020 13:37:43 +0100 From: Chris Down To: Yafang Shao Cc: Naresh Kamboju , Michal Hocko , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , Theodore Ts'o , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@lists.linaro.org, Johannes Weiner , Roman Gushchin , Cgroups Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Message-ID: <20200618123743.GA694719@chrisdown.name> References: <20200521095515.GK6462@dhcp22.suse.cz> <20200521163450.GV6462@dhcp22.suse.cz> <20200617135758.GA548179@chrisdown.name> <20200617141155.GQ9499@dhcp22.suse.cz> <20200617160624.GS9499@dhcp22.suse.cz> <20200617210935.GA578452@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.3 (2020-06-14) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Yafang Shao writes: >On Thu, Jun 18, 2020 at 5:09 AM Chris Down wrote: >> >> Naresh Kamboju writes: >> >After this patch applied the reported issue got fixed. >> >> Great! Thank you Naresh and Michal for helping to get to the bottom of this :-) >> >> I'll send out a new version tomorrow with the fixes applied and both of you >> credited in the changelog for the detection and fix. > >As we have already found that the usage around memory.{emin, elow} has >many limitations, I think memory.{emin, elow} should be used for >memcg-tree internally only, that means they can only be used to >calculate the protection of a memcg in a specified memcg-tree but >should not be exposed to other MM parts. I agree that the current semantics are mentally taxing and we should generally avoid exposing the implementation details outside of memcg where possible. Do you have a suggested rework? :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2C6FC433E0 for ; Thu, 18 Jun 2020 12:37:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 82B86207E8 for ; Thu, 18 Jun 2020 12:37:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="Vba3/YBp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82B86207E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 261716B0081; Thu, 18 Jun 2020 08:37:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 211456B0082; Thu, 18 Jun 2020 08:37:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08BE16B0083; Thu, 18 Jun 2020 08:37:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id E6B756B0081 for ; Thu, 18 Jun 2020 08:37:46 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id AE459348D for ; Thu, 18 Jun 2020 12:37:46 +0000 (UTC) X-FDA: 76942284132.19.fact13_331275826e10 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 75D201AD1AD for ; Thu, 18 Jun 2020 12:37:46 +0000 (UTC) X-HE-Tag: fact13_331275826e10 X-Filterd-Recvd-Size: 5058 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 18 Jun 2020 12:37:45 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id f185so5488516wmf.3 for ; Thu, 18 Jun 2020 05:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OgZomFoj/7toYCBCKWRo7nq/kYdKAWeXt05LtEajY3k=; b=Vba3/YBp135F4zjZnb2RedWXF2lwu1lFFL34CLaNpxPjPTPlt0UR472eYi5S4YZ1Wx Z0rDK+6Hs9d3o0cUOdxwi2SS36Jq5bWlnav7DNmZNgJpcMQ+D8caGFIGg/ORh0SmmPxl k69/g/gWD8TgMCYkGiY2Wz/GRty0LMQ/SrbXk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OgZomFoj/7toYCBCKWRo7nq/kYdKAWeXt05LtEajY3k=; b=oRRf+r5a1Wav/u1SIal4RgcF+Bu/jLItCEzZljNU8bFmz/ar4m5lF/410+cwI88RMf qmeYkgNPjYWdRED1bEt6HvyvLSRVGk1sSYnaTLRTxUQz8lYAXwh9DarOTanz0pxTMTqR 1zZoz4KVpjM0ZNztoZK7bn6GQvtbQSbhAPl4MVteNCEVaquaBau76WTqETQAexMO9Apv E2Ivw1ZyJnwT9Su5ApDYdHfGTcOjX13dp4dtL16mnWUGmwpk2Nt9oT8gI7nYrrjWLcU6 c0290tBHAdTnP6FgDdJwMG4epRD/o9dqlsyumCPIv6VPF7LFdILkjjxvT382ppIy3yk5 kSiQ== X-Gm-Message-State: AOAM5307D2vNyAGK903n13fr+1kqq4Td6UtMvYtW61rVf0+SL3EQ3PXQ nhvxV6PP2r0BbYJNv9cH9Rj9cQ== X-Google-Smtp-Source: ABdhPJzFoWSkp2MqAS0xx92RSUWbWQ0U7Z92SQ/MTtOdoN5z3gnxoKRC/r81z8qHIYMjhulYtZARyw== X-Received: by 2002:a1c:4143:: with SMTP id o64mr3734793wma.157.1592483864725; Thu, 18 Jun 2020 05:37:44 -0700 (PDT) Received: from localhost ([2a01:4b00:8432:8a00:63de:dd93:20be:f460]) by smtp.gmail.com with ESMTPSA id t82sm2586962wmg.10.2020.06.18.05.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 05:37:43 -0700 (PDT) Date: Thu, 18 Jun 2020 13:37:43 +0100 From: Chris Down To: Yafang Shao Cc: Naresh Kamboju , Michal Hocko , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , Theodore Ts'o , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@lists.linaro.org, Johannes Weiner , Roman Gushchin , Cgroups Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Message-ID: <20200618123743.GA694719@chrisdown.name> References: <20200521095515.GK6462@dhcp22.suse.cz> <20200521163450.GV6462@dhcp22.suse.cz> <20200617135758.GA548179@chrisdown.name> <20200617141155.GQ9499@dhcp22.suse.cz> <20200617160624.GS9499@dhcp22.suse.cz> <20200617210935.GA578452@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.3 (2020-06-14) X-Rspamd-Queue-Id: 75D201AD1AD X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Yafang Shao writes: >On Thu, Jun 18, 2020 at 5:09 AM Chris Down wrote: >> >> Naresh Kamboju writes: >> >After this patch applied the reported issue got fixed. >> >> Great! Thank you Naresh and Michal for helping to get to the bottom of this :-) >> >> I'll send out a new version tomorrow with the fixes applied and both of you >> credited in the changelog for the detection and fix. > >As we have already found that the usage around memory.{emin, elow} has >many limitations, I think memory.{emin, elow} should be used for >memcg-tree internally only, that means they can only be used to >calculate the protection of a memcg in a specified memcg-tree but >should not be exposed to other MM parts. I agree that the current semantics are mentally taxing and we should generally avoid exposing the implementation details outside of memcg where possible. Do you have a suggested rework? :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD79CC433E0 for ; Thu, 18 Jun 2020 12:37:56 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91EBB2070A for ; Thu, 18 Jun 2020 12:37:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="WJ509USN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="UFSluMCw"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="Vba3/YBp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91EBB2070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jltnm-0002mC-Q8; Thu, 18 Jun 2020 12:37:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jltnm-0002m5-0q for linux-f2fs-devel@lists.sourceforge.net; Thu, 18 Jun 2020 12:37:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OgZomFoj/7toYCBCKWRo7nq/kYdKAWeXt05LtEajY3k=; b=WJ509USN74qT6gw1TqGvZoIClc emO4+OCGprWj3h7CtDGmO/Dwu2hkYHgHJgS6CBabgAl4df7TN1SA2BLNaz2j+I8DSPkV8OePG0HNy NP8LPbhltgdJzCf5eaZZ4cIfedaVeQXdoX20y9kxRuWEcqL73XhRQXoI4MjcGZZpGM6Q=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OgZomFoj/7toYCBCKWRo7nq/kYdKAWeXt05LtEajY3k=; b=UFSluMCwzUqlrus45qVTZtEE0N 6kv5h6inBTAZQL0E1nn1nvIEe4ivseCW5WzY3JWnZiuqksByfpBwYz/XANYJLeFZ8SFqn/LDWYR6g OoRxtSgru+D843riNbO2TBG9uxfz+D8h24aPbtVtzZanl79v6cKwotUOuYwGrtCmV4lM=; Received: from mail-wm1-f66.google.com ([209.85.128.66]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1jltnj-00Ad10-5H for linux-f2fs-devel@lists.sourceforge.net; Thu, 18 Jun 2020 12:37:53 +0000 Received: by mail-wm1-f66.google.com with SMTP id d128so5485404wmc.1 for ; Thu, 18 Jun 2020 05:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OgZomFoj/7toYCBCKWRo7nq/kYdKAWeXt05LtEajY3k=; b=Vba3/YBp135F4zjZnb2RedWXF2lwu1lFFL34CLaNpxPjPTPlt0UR472eYi5S4YZ1Wx Z0rDK+6Hs9d3o0cUOdxwi2SS36Jq5bWlnav7DNmZNgJpcMQ+D8caGFIGg/ORh0SmmPxl k69/g/gWD8TgMCYkGiY2Wz/GRty0LMQ/SrbXk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OgZomFoj/7toYCBCKWRo7nq/kYdKAWeXt05LtEajY3k=; b=QTn92uOJCOCZtFlplmJKcMoC7xmNUWCMcQgtRrAmj7V26x9/PlVBley0hmB8L6tGx4 XSaKSvnzXWxRakKn42jRgruZdqa+/WL4ZWOAWtG4RDVl/5jrW53XPkKMhvh/6fu8M4VA +fTMbCxrxExLev0oFDK1QLpwqE1wy9PcNN4jLt3eLB1RG7sNz4Y7aMaQWmcgFXZDMZzG 1ZCtuoKWPsnPKLrT4l5XM4Ubq0lvMJ2UUEIjVRoQSny6ERq9MWfKwGIo3CnHccZdCoNq UEJq2V84d4b2O/b+KCyUkuJbb44kExkRoGbIrG3fkqWjLEYGA1Q0tdUDazN1JsmhZ55i yhHw== X-Gm-Message-State: AOAM532bMgvDAmHsxHQBOas1pKzNso+peP89zFLYdU4X3pifDiOqGySF j9jy4PuLauwwsR8c5KnwhKfCSw== X-Google-Smtp-Source: ABdhPJzFoWSkp2MqAS0xx92RSUWbWQ0U7Z92SQ/MTtOdoN5z3gnxoKRC/r81z8qHIYMjhulYtZARyw== X-Received: by 2002:a1c:4143:: with SMTP id o64mr3734793wma.157.1592483864725; Thu, 18 Jun 2020 05:37:44 -0700 (PDT) Received: from localhost ([2a01:4b00:8432:8a00:63de:dd93:20be:f460]) by smtp.gmail.com with ESMTPSA id t82sm2586962wmg.10.2020.06.18.05.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 05:37:43 -0700 (PDT) Date: Thu, 18 Jun 2020 13:37:43 +0100 From: Chris Down To: Yafang Shao Message-ID: <20200618123743.GA694719@chrisdown.name> References: <20200521095515.GK6462@dhcp22.suse.cz> <20200521163450.GV6462@dhcp22.suse.cz> <20200617135758.GA548179@chrisdown.name> <20200617141155.GQ9499@dhcp22.suse.cz> <20200617160624.GS9499@dhcp22.suse.cz> <20200617210935.GA578452@chrisdown.name> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.3 (2020-06-14) X-Headers-End: 1jltnj-00Ad10-5H Subject: Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lkft-triage@lists.linaro.org, Michal Hocko , linux-mm , Andreas Dilger , Cgroups , Andrea Arcangeli , Anders Roxell , Naresh Kamboju , Hugh Dickins , Matthew Wilcox , Linux-Next Mailing List , linux-ext4 , Arnd Bergmann , linux-block , Jaegeuk Kim , Theodore Ts'o , open list , "Linux F2FS DEV, Mailing List" , Johannes Weiner , Andrew Morton , Roman Gushchin Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Yafang Shao writes: >On Thu, Jun 18, 2020 at 5:09 AM Chris Down wrote: >> >> Naresh Kamboju writes: >> >After this patch applied the reported issue got fixed. >> >> Great! Thank you Naresh and Michal for helping to get to the bottom of this :-) >> >> I'll send out a new version tomorrow with the fixes applied and both of you >> credited in the changelog for the detection and fix. > >As we have already found that the usage around memory.{emin, elow} has >many limitations, I think memory.{emin, elow} should be used for >memcg-tree internally only, that means they can only be used to >calculate the protection of a memcg in a specified memcg-tree but >should not be exposed to other MM parts. I agree that the current semantics are mentally taxing and we should generally avoid exposing the implementation details outside of memcg where possible. Do you have a suggested rework? :-) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Down Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Date: Thu, 18 Jun 2020 13:37:43 +0100 Message-ID: <20200618123743.GA694719@chrisdown.name> References: <20200521095515.GK6462@dhcp22.suse.cz> <20200521163450.GV6462@dhcp22.suse.cz> <20200617135758.GA548179@chrisdown.name> <20200617141155.GQ9499@dhcp22.suse.cz> <20200617160624.GS9499@dhcp22.suse.cz> <20200617210935.GA578452@chrisdown.name> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OgZomFoj/7toYCBCKWRo7nq/kYdKAWeXt05LtEajY3k=; b=Vba3/YBp135F4zjZnb2RedWXF2lwu1lFFL34CLaNpxPjPTPlt0UR472eYi5S4YZ1Wx Z0rDK+6Hs9d3o0cUOdxwi2SS36Jq5bWlnav7DNmZNgJpcMQ+D8caGFIGg/ORh0SmmPxl k69/g/gWD8TgMCYkGiY2Wz/GRty0LMQ/SrbXk= Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" Content-Transfer-Encoding: 7bit To: Yafang Shao Cc: Naresh Kamboju , Michal Hocko , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , Theodore Ts'o , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft- Yafang Shao writes: >On Thu, Jun 18, 2020 at 5:09 AM Chris Down wrote: >> >> Naresh Kamboju writes: >> >After this patch applied the reported issue got fixed. >> >> Great! Thank you Naresh and Michal for helping to get to the bottom of this :-) >> >> I'll send out a new version tomorrow with the fixes applied and both of you >> credited in the changelog for the detection and fix. > >As we have already found that the usage around memory.{emin, elow} has >many limitations, I think memory.{emin, elow} should be used for >memcg-tree internally only, that means they can only be used to >calculate the protection of a memcg in a specified memcg-tree but >should not be exposed to other MM parts. I agree that the current semantics are mentally taxing and we should generally avoid exposing the implementation details outside of memcg where possible. Do you have a suggested rework? :-)