From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 094F1C433DF for ; Sun, 21 Jun 2020 03:34:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE814247CE for ; Sun, 21 Jun 2020 03:34:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729228AbgFUDer (ORCPT ); Sat, 20 Jun 2020 23:34:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729208AbgFUDer (ORCPT ); Sat, 20 Jun 2020 23:34:47 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F5A3C061794 for ; Sat, 20 Jun 2020 20:34:47 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1jmqkn-0003tp-Nz; Sun, 21 Jun 2020 05:34:45 +0200 Date: Sun, 21 Jun 2020 05:34:45 +0200 From: Florian Westphal To: Rob Gill Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH v2] netfilter: Add MODULE_DESCRIPTION entries to kernel modules Message-ID: <20200621033445.GI26990@breakpoint.cc> References: <20200621002114.16509-1-rrobgill@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200621002114.16509-1-rrobgill@protonmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Rob Gill wrote: > The user tool modinfo is used to get information on kernel modules, including a > description where it is available. > > This patch adds a brief MODULE_DESCRIPTION to netfilter kernel modules > (descriptions taken from Kconfig file or code comments) > +++ b/net/bridge/netfilter/nft_meta_bridge.c > +MODULE_DESCRIPTION("Netfilter nf_table bridge meta support"); [..] > --- a/net/bridge/netfilter/nft_reject_bridge.c > +MODULE_DESCRIPTION("Netfilter nf_tables bridge reject support"); [..] > diff --git a/net/ipv4/netfilter/ipt_SYNPROXY.c b/net/ipv4/netfilter/ipt_SYNPROXY.c > +MODULE_DESCRIPTION("SYNPROXY target support"); These three modules are called nft_meta_bridge.ko, nft_reject_bridge.ko and ipt_SYNPROXY.ko. I don't think the above adds anything meaningful to this. Maybe describe what these are for instead? E.g. 'reject packets from bridge via nftables' or something similar. > --- a/net/ipv4/netfilter/nft_dup_ipv4.c > +++ b/net/ipv4/netfilter/nft_dup_ipv4.c > @@ -107,3 +107,4 @@ module_exit(nft_dup_ipv4_module_exit); > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Pablo Neira Ayuso "); > MODULE_ALIAS_NFT_AF_EXPR(AF_INET, "dup"); > +MODULE_DESCRIPTION("IPv4 nf_tables packet duplication support"); This seens better, although i'd use nftables (no "_"). > +MODULE_DESCRIPTION("nf_tables fib / ip route lookup support"); This too. > +MODULE_DESCRIPTION("Netfilter nf_tables passive OS fingerprint support"); This is also ok, but perhaps just 'nftables passive OS fingerprint support" is enough.