From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD22EC433E0 for ; Sun, 21 Jun 2020 06:22:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96F652482C for ; Sun, 21 Jun 2020 06:22:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729352AbgFUGW0 (ORCPT ); Sun, 21 Jun 2020 02:22:26 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:48998 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729296AbgFUGWZ (ORCPT ); Sun, 21 Jun 2020 02:22:25 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 1188B20024; Sun, 21 Jun 2020 08:22:21 +0200 (CEST) Date: Sun, 21 Jun 2020 08:22:19 +0200 From: Sam Ravnborg To: Adam Ford Cc: Fabio Estevam , David Airlie , Tomi Valkeinen , Adam Ford-BE , stable , linux-kernel , Thierry Reding , DRI mailing list Subject: Re: [PATCH] drm/panel-simple: fix connector type for LogicPD Type28 Display Message-ID: <20200621062219.GE74146@ravnborg.org> References: <20200615131934.12440-1-aford173@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=edQTgYMH c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=Vt2AcnKqAAAA:8 a=e5mUnYsNAAAA:8 a=7gkXJVJtAAAA:8 a=VwQbUJbxAAAA:8 a=s3IO3C7y_afzQisZ5X4A:9 a=CjuIK1q_8ugA:10 a=v10HlyRyNeVhbzM4Lqgd:22 a=Vxmtnl_E_bksehYqCbjh:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=AjGcO6oz07-iQ99wixmX:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Adam. On Mon, Jun 15, 2020 at 09:53:45AM -0500, Adam Ford wrote: > On Mon, Jun 15, 2020 at 9:46 AM Fabio Estevam wrote: > > > > On Mon, Jun 15, 2020 at 10:19 AM Adam Ford wrote: > > > > > > The LogicPD Type28 display used by several Logic PD products has not > > > worked since v5.5. > > > > Maybe you could tell which commit exactly and then put a Fixes tag? > > I honestly don't know. I reached out to the omap mailing list, > because I noted this issue. Tomi V from TI responded with a link that > he posted which fixes this for another display. > > https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg312208.html > > I tested that patch and it worked for a different LCD, so I did the > same thing to the Logic PD Type 28 display as well. > > My patch and commit message were modeled after his, and his commit > CC's stable with a note about being required for v5.5+ > > I added him to the CC list, so maybe he knows which hash needs to be > referenced from a fixes tag. I was hoping to not have to go back and > bisect if it's not required, but I will if necessary. git blame is your friend - the panel was added here: 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2469) static const struct panel_desc logicpd_type_28 = { 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2470) .modes = &logicpd_type_28_mode, 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2471) .num_modes = 1, 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2472) .bpc = 8, 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2473) .size = { 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2474) .width = 105, 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2475) .height = 67, 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2476) }, So this gives us fllowing fixes info: Fixes: 0d35408afbeb ("drm/panel: simple: Add Logic PD Type 28 display support") Cc: Adam Ford Cc: Sam Ravnborg Cc: Thierry Reding Cc: dri-devel@lists.freedesktop.org Cc: # v5.6+ I have adjusted the changelog to say 5.6 and applied to drm-misc-fixes Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1ABEC433E1 for ; Sun, 21 Jun 2020 06:22:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5184E2482C for ; Sun, 21 Jun 2020 06:22:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5184E2482C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 33DBD89B0B; Sun, 21 Jun 2020 06:22:26 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 27F1289B0B for ; Sun, 21 Jun 2020 06:22:25 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 1188B20024; Sun, 21 Jun 2020 08:22:21 +0200 (CEST) Date: Sun, 21 Jun 2020 08:22:19 +0200 From: Sam Ravnborg To: Adam Ford Subject: Re: [PATCH] drm/panel-simple: fix connector type for LogicPD Type28 Display Message-ID: <20200621062219.GE74146@ravnborg.org> References: <20200615131934.12440-1-aford173@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=edQTgYMH c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=Vt2AcnKqAAAA:8 a=e5mUnYsNAAAA:8 a=7gkXJVJtAAAA:8 a=VwQbUJbxAAAA:8 a=s3IO3C7y_afzQisZ5X4A:9 a=CjuIK1q_8ugA:10 a=v10HlyRyNeVhbzM4Lqgd:22 a=Vxmtnl_E_bksehYqCbjh:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=AjGcO6oz07-iQ99wixmX:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Adam Ford-BE , stable , linux-kernel , Tomi Valkeinen , Thierry Reding , DRI mailing list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Adam. On Mon, Jun 15, 2020 at 09:53:45AM -0500, Adam Ford wrote: > On Mon, Jun 15, 2020 at 9:46 AM Fabio Estevam wrote: > > > > On Mon, Jun 15, 2020 at 10:19 AM Adam Ford wrote: > > > > > > The LogicPD Type28 display used by several Logic PD products has not > > > worked since v5.5. > > > > Maybe you could tell which commit exactly and then put a Fixes tag? > > I honestly don't know. I reached out to the omap mailing list, > because I noted this issue. Tomi V from TI responded with a link that > he posted which fixes this for another display. > > https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg312208.html > > I tested that patch and it worked for a different LCD, so I did the > same thing to the Logic PD Type 28 display as well. > > My patch and commit message were modeled after his, and his commit > CC's stable with a note about being required for v5.5+ > > I added him to the CC list, so maybe he knows which hash needs to be > referenced from a fixes tag. I was hoping to not have to go back and > bisect if it's not required, but I will if necessary. git blame is your friend - the panel was added here: 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2469) static const struct panel_desc logicpd_type_28 = { 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2470) .modes = &logicpd_type_28_mode, 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2471) .num_modes = 1, 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2472) .bpc = 8, 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2473) .size = { 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2474) .width = 105, 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2475) .height = 67, 0d35408afbeb6 (Adam Ford 2019-10-16 08:51:45 -0500 2476) }, So this gives us fllowing fixes info: Fixes: 0d35408afbeb ("drm/panel: simple: Add Logic PD Type 28 display support") Cc: Adam Ford Cc: Sam Ravnborg Cc: Thierry Reding Cc: dri-devel@lists.freedesktop.org Cc: # v5.6+ I have adjusted the changelog to say 5.6 and applied to drm-misc-fixes Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel