All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: Li Guifu <bluce.lee@aliyun.com>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v8] erofs-utils: introduce segment compression
Date: Sun, 21 Jun 2020 22:37:13 +0800	[thread overview]
Message-ID: <20200621143711.GA27245@hsiangkao-HP-ZHAN-66-Pro-G1> (raw)
In-Reply-To: <20200621122745.26996-1-bluce.lee@aliyun.com>

On Sun, Jun 21, 2020 at 08:27:45PM +0800, Li Guifu via Linux-erofs wrote:

...

>  nocompression:
> -			ret = write_uncompressed_block(ctx, &len, dst);
> +			/* reset clusterofs to 0 if permitted */
> +			if (!erofs_sb_has_lz4_0padding() &&
> +			    ctx->head >= ctx->clusterofs) {
> +				ctx->head -= ctx->clusterofs;
> +				len += ctx->clusterofs;
> +				limit += ctx->clusterofs;
> +				ctx->clusterofs = 0;

TL;DR: it seems still buggy here.
Pls rethink carefully and send a usable patch then...

Thanks,
Gao Xiang


  reply	other threads:[~2020-06-21 14:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 16:26 [PATCH v4] erofs-utils: introduce segment compression Li Guifu via Linux-erofs
2020-06-18 23:05 ` Gao Xiang
2020-06-19 17:51 ` [PATCH v5] " Li Guifu via Linux-erofs
2020-06-19 23:03   ` Gao Xiang
2020-06-21 10:51   ` [PATCH v6] erofs-utils: introduce segment limits compression Li Guifu via Linux-erofs
2020-06-21 12:27     ` [PATCH v8] erofs-utils: introduce segment compression Li Guifu via Linux-erofs
2020-06-21 14:37       ` Gao Xiang via Linux-erofs [this message]
2020-06-30 17:27         ` [PATCH v10] " Li Guifu via Linux-erofs
2020-07-05  8:32           ` [PATCH v11] " Li Guifu via Linux-erofs
2020-07-05 18:20             ` Gao Xiang via Linux-erofs
2020-10-07 15:04               ` Gao Xiang via Linux-erofs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200621143711.GA27245@hsiangkao-HP-ZHAN-66-Pro-G1 \
    --to=linux-erofs@lists.ozlabs.org \
    --cc=bluce.lee@aliyun.com \
    --cc=hsiangkao@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.