[PATCH] xinit: add rxvt in RDEPENDS

[PATCH] xinit: add rxvt in RDEPENDS

[Changqing Li]

From: Changqing Li <changqing.li@windriver.com>

fix below error:
/etc/X11/xinit/xinitrc: line 55: exec: xterm: not found

by default, xinit will generate /etc/X11/xinit/xinitrc,
and have below config in it:
XTERM -geometry 80x50+494+51 &
XTERM -geometry 80x20+494-0 &
exec XTERM -geometry 80x66+0+0 -name login

the default XTERM is xterm, but xterm is in meta-oe,
use rxvt instead

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta/recipes-graphics/xorg-app/xinit_1.4.1.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb b/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb
index c9e28d9bba..2f2ba3af71 100644
--- a/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb
+++ b/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb
@@ -19,4 +19,7 @@ SRC_URI[sha256sum] = "de9b8f617b68a70f6caf87da01fcf0ebd2b75690cdcba9c921d0ef54fa
 
 EXTRA_OECONF = "ac_cv_path_MCOOKIE=${bindir}/mcookie"
 
-RDEPENDS_${PN} += "util-linux-mcookie"
+PACKAGECONFIG ??= "xterm"
+PACKAGECONFIG[xterm] = "--with-xterm=rxvt,,,"
+
+RDEPENDS_${PN} += "util-linux-mcookie rxvt-unicode"
-- 
2.17.1

Re: [OE-core] [PATCH] xinit: add rxvt in RDEPENDS

[Jacob Kroon]

On 6/22/20 3:51 AM, Changqing Li wrote:
> From: Changqing Li <changqing.li@windriver.com>
> 
> fix below error:
> /etc/X11/xinit/xinitrc: line 55: exec: xterm: not found
> 
> by default, xinit will generate /etc/X11/xinit/xinitrc,
> and have below config in it:
> XTERM -geometry 80x50+494+51 &
> XTERM -geometry 80x20+494-0 &
> exec XTERM -geometry 80x66+0+0 -name login
> 
> the default XTERM is xterm, but xterm is in meta-oe,
> use rxvt instead
> 
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
>   meta/recipes-graphics/xorg-app/xinit_1.4.1.bb | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb b/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb
> index c9e28d9bba..2f2ba3af71 100644
> --- a/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb
> +++ b/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb
> @@ -19,4 +19,7 @@ SRC_URI[sha256sum] = "de9b8f617b68a70f6caf87da01fcf0ebd2b75690cdcba9c921d0ef54fa
>   
>   EXTRA_OECONF = "ac_cv_path_MCOOKIE=${bindir}/mcookie"
>   
> -RDEPENDS_${PN} += "util-linux-mcookie"
> +PACKAGECONFIG ??= "xterm"
> +PACKAGECONFIG[xterm] = "--with-xterm=rxvt,,,"
> +

Maybe "rxvt" would be a more suitable name for the PACKAGECONFIG ?

Jacob

Re: [OE-core] [PATCH] xinit: add rxvt in RDEPENDS

[Richard Purdie]

On Mon, 2020-06-22 at 06:40 +0200, Jacob Kroon wrote:
> On 6/22/20 3:51 AM, Changqing Li wrote:
> > From: Changqing Li <changqing.li@windriver.com>
> > 
> > fix below error:
> > /etc/X11/xinit/xinitrc: line 55: exec: xterm: not found
> > 
> > by default, xinit will generate /etc/X11/xinit/xinitrc,
> > and have below config in it:
> > XTERM -geometry 80x50+494+51 &
> > XTERM -geometry 80x20+494-0 &
> > exec XTERM -geometry 80x66+0+0 -name login
> > 
> > the default XTERM is xterm, but xterm is in meta-oe,
> > use rxvt instead
> > 
> > Signed-off-by: Changqing Li <changqing.li@windriver.com>
> > ---
> >   meta/recipes-graphics/xorg-app/xinit_1.4.1.bb | 5 ++++-
> >   1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb
> > b/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb
> > index c9e28d9bba..2f2ba3af71 100644
> > --- a/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb
> > +++ b/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb
> > @@ -19,4 +19,7 @@ SRC_URI[sha256sum] =
> > "de9b8f617b68a70f6caf87da01fcf0ebd2b75690cdcba9c921d0ef54fa
> >   
> >   EXTRA_OECONF = "ac_cv_path_MCOOKIE=${bindir}/mcookie"
> >   
> > -RDEPENDS_${PN} += "util-linux-mcookie"
> > +PACKAGECONFIG ??= "xterm"
> > +PACKAGECONFIG[xterm] = "--with-xterm=rxvt,,,"
> > +
> 
> Maybe "rxvt" would be a more suitable name for the PACKAGECONFIG ?

Also, the RDEPENDS should be in the PACKAGECONFIG entry itself.

Cheers,

Richard