All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dakshaja Uppalapati <dakshaja@chelsio.com>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, eduard@hasenleithner.at,
	sagi@grimberg.me, hch@lst.de, stable@vger.kernel.org,
	Nirranjan Kirubaharan <nirranjan@chelsio.com>,
	Potnuri Bharat Teja <bharat@chelsio.com>
Subject: Re: [PATCH for-stable nvmet 0/6] nvme: Fix for blk_update_request IO error.
Date: Mon, 22 Jun 2020 16:51:44 +0530	[thread overview]
Message-ID: <20200622112143.GA25601@chelsio.com> (raw)
In-Reply-To: <20200617141541.GA712019@dhcp-10-100-145-180.wdl.wdc.com>

On Wednesday, June 06/17/20, 2020 at 07:15:41 -0700, Keith Busch wrote:
> On Thu, Jun 11, 2020 at 09:23:33PM +0530, Dakshaja Uppalapati wrote:
> > The below error is seen in dmesg, while formatting the disks discovered on host.
> > 
> > dmesg:
> >         [  636.733374] blk_update_request: I/O error, dev nvme4n1, sector 0 op 0x3:(DISCARD) flags 0x800 phys_seg 1 prio class 0
> > 
> > Patch 6 fixes it and there are 5 other dependent patches that also need to be 
> > pulled from upstream to stable, 5.4 and 4.19 branches.
> > 
> > Patch 1 dependent patch
> > 
> > Patch 2 dependent patch
> > 
> > Patch 3 dependent patch
> > 
> > Patch 4 dependent patch
> > 
> > Patch 5 dependent patch
> > 
> > Patch 6 fix patch
> 
> 1. You need to copy the linux-nvme mainling list for linux nvme kernel patches.
> 
> 2. If you're sending someone else's patch, the patch is supposed to have
> the From: tag so the author is appropriately identified.
> 
> 3. Stable patches must referece the upstream commit ID.
> 
> As for this particular issue, while stable patches are required to
> reference an upstream commit, you don't need to bring in dependent
> patches. You are allowed to write an equivalent fix specific to the
> stable branch so that stable doesn't need to take a bunch of unrelated
> changes. For example, it looks like this particular isssue can be fixed
> with the following simple stable patch:
>

Hi keith,

Thanks for the review.

I initially tried pushing only the fix + required portion of the dependent 
patches(https://www.spinics.net/lists/stable/msg387744.html) but as that 
approach is discouraged in stable tree, I submitted all the patches as it is.

Here are the ways to fix the issue in stable tree:

•  push fix + all dependent patches
•  push fix + custom patch of dependent patches
•  revert the culprit patch.

Please let me know how this issue can be resolved in stable tree.

Thanks,
Dakshaja


  reply	other threads:[~2020-06-22 11:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 15:53 [PATCH for-stable nvmet 0/6] nvme: Fix for blk_update_request IO error Dakshaja Uppalapati
2020-06-11 15:53 ` [PATCH for-stable nvmet 1/6] nvmet: Cleanup discovery execute handlers Dakshaja Uppalapati
2020-06-11 15:53 ` [PATCH for-stable nvmet 2/6] nvmet: Introduce common execute function for get_log_page and identify Dakshaja Uppalapati
2020-06-11 15:53 ` [PATCH for-stable nvmet 3/6] nvmet: Introduce nvmet_dsm_len() helper Dakshaja Uppalapati
2020-06-11 15:53 ` [PATCH for-stable nvmet 4/6] nvmet: Remove the data_len field from the nvmet_req struct Dakshaja Uppalapati
2020-06-11 15:53 ` [PATCH for-stable nvmet 5/6] nvmet: Open code nvmet_req_execute() Dakshaja Uppalapati
2020-06-11 15:53 ` [PATCH for-stable nvmet 6/6] nvmet: fix dsm failure when payload does not match sgl descriptor Dakshaja Uppalapati
2020-06-17 13:54 ` [PATCH for-stable nvmet 0/6] nvme: Fix for blk_update_request IO error Dakshaja Uppalapati
2020-06-17 14:15 ` Keith Busch
2020-06-22 11:21   ` Dakshaja Uppalapati [this message]
2020-06-29 13:55     ` Dakshaja Uppalapati
2020-06-29 13:55       ` Dakshaja Uppalapati
2020-09-04 11:33     ` Greg KH
2020-09-04 11:33       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200622112143.GA25601@chelsio.com \
    --to=dakshaja@chelsio.com \
    --cc=bharat@chelsio.com \
    --cc=eduard@hasenleithner.at \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nirranjan@chelsio.com \
    --cc=sagi@grimberg.me \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.