From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH AUTOSEL 5.7 004/388] ASoC: tegra: tegra_wm8903: Support nvidia, headset property Date: Mon, 22 Jun 2020 14:27:57 +0100 Message-ID: <20200622132757.GG4560@sirena.org.uk> References: <20200618010805.600873-1-sashal@kernel.org> <20200618010805.600873-4-sashal@kernel.org> <20200618110023.GB5789@sirena.org.uk> <20200618143046.GT1931@sasha-vm> <20200618143930.GI5789@sirena.org.uk> <20200621233352.GA1931@sasha-vm> <20200622112321.GB4560@sirena.org.uk> <20200622123118.GF1931@sasha-vm> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GdbWtwDHkcXqP16f" Return-path: Content-Disposition: inline In-Reply-To: <20200622123118.GF1931@sasha-vm> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sasha Levin Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dmitry Osipenko , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org --GdbWtwDHkcXqP16f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 22, 2020 at 08:31:18AM -0400, Sasha Levin wrote: > On Mon, Jun 22, 2020 at 12:23:21PM +0100, Mark Brown wrote: > > That's concerning - please don't do this. It's not what stable is > > expected to be and there's no guarantee that you're getting all the > > changes required to actually make things work. > How come? This is one of the things stable rules explicitly call for: > "New device IDs and quirks are also accepted". I would expect that to be data only additions, I would not expect that to be adding new code. > If we're missing anything, the solution is to make sure we stop missing > it rather than not take anything to begin with :) It would be much better to not have to watch stable constantly like we currently do - we're seeing people report breakage often enough to be a concern as things are, we don't need to be trying to pile extra stuff in there because there's some keywords in a changelog or whatever. The testing coverage for drivers is weak, increasing the change rate puts more stress on that. --GdbWtwDHkcXqP16f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7wsdwACgkQJNaLcl1U h9DAWgf+LXkPTWA3Nc4TkIaUcPd+6AtboLQyyP/9/zEkyr2ajDpxQXLudemBDlSm kHTVki/gUcoz35AYQ5Hz9grJOzflY0Md4GMge23a8MOKyI4vG/bPkDU1cB0Ui9nz g6HpTo9KGjOtwUMrL8EOOukvy87Uq9UdfSbffIWDLo8o/RiicXsc+on+Oso9NXdZ mTI5atdoy6lseE9eaYxGrgmetAytq7nmr79/UBBVIh2WMxgqZjNHE360hUJx8HSQ O9TUmrx7VKViCZxIhSW0DnJz0ArHTqJ6E/kdsoy6OaM4PkGUGup9xqLe3eHoaFqp OvEHOplFor4XKOgt1n2JicJP6G+Wrw== =xyNh -----END PGP SIGNATURE----- --GdbWtwDHkcXqP16f-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 210E4C433DF for ; Mon, 22 Jun 2020 13:28:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7F5F20702 for ; Mon, 22 Jun 2020 13:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592832482; bh=lhi0FntWbQp4WIrSKUUmGDerYj3VQxf+0v5+P6/doWc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wXIT570BvDhQy1KG1K7vJztJYkUadMlipvRKhIGDRcsaM+cOPI/9iU7XhiazL+lYn KHkHWbUimf8LpP5QrAQAIkE/LvXFxPnTz/BQTK0rPqnsWj3dm8qqM0RAcmCuOA6kUq mNhJ8SmRoDJ76rScQEl6xpZ7ZWiBYZw8lATvSXrQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729018AbgFVN2A (ORCPT ); Mon, 22 Jun 2020 09:28:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:42396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728187AbgFVN2A (ORCPT ); Mon, 22 Jun 2020 09:28:00 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D4DCF206D7; Mon, 22 Jun 2020 13:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592832479; bh=lhi0FntWbQp4WIrSKUUmGDerYj3VQxf+0v5+P6/doWc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JBUfeRI44+v7JXdB6xXg+hIdb2t30haIQsuAJLa0wyZmSthAEVhHdecY9uHhx85nL S4HuvyD0gC30/581rYJXWnWLQL2Xevq7246D7yJr74DluWtW9bCTlf60np6xoSIWfs NOGQclz2mgoEbpCOGEtVzf6tv7x9ltlrbjyyAi4U= Date: Mon, 22 Jun 2020 14:27:57 +0100 From: Mark Brown To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Dmitry Osipenko , alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.7 004/388] ASoC: tegra: tegra_wm8903: Support nvidia, headset property Message-ID: <20200622132757.GG4560@sirena.org.uk> References: <20200618010805.600873-1-sashal@kernel.org> <20200618010805.600873-4-sashal@kernel.org> <20200618110023.GB5789@sirena.org.uk> <20200618143046.GT1931@sasha-vm> <20200618143930.GI5789@sirena.org.uk> <20200621233352.GA1931@sasha-vm> <20200622112321.GB4560@sirena.org.uk> <20200622123118.GF1931@sasha-vm> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GdbWtwDHkcXqP16f" Content-Disposition: inline In-Reply-To: <20200622123118.GF1931@sasha-vm> X-Cookie: laser, n.: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --GdbWtwDHkcXqP16f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 22, 2020 at 08:31:18AM -0400, Sasha Levin wrote: > On Mon, Jun 22, 2020 at 12:23:21PM +0100, Mark Brown wrote: > > That's concerning - please don't do this. It's not what stable is > > expected to be and there's no guarantee that you're getting all the > > changes required to actually make things work. > How come? This is one of the things stable rules explicitly call for: > "New device IDs and quirks are also accepted". I would expect that to be data only additions, I would not expect that to be adding new code. > If we're missing anything, the solution is to make sure we stop missing > it rather than not take anything to begin with :) It would be much better to not have to watch stable constantly like we currently do - we're seeing people report breakage often enough to be a concern as things are, we don't need to be trying to pile extra stuff in there because there's some keywords in a changelog or whatever. The testing coverage for drivers is weak, increasing the change rate puts more stress on that. --GdbWtwDHkcXqP16f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7wsdwACgkQJNaLcl1U h9DAWgf+LXkPTWA3Nc4TkIaUcPd+6AtboLQyyP/9/zEkyr2ajDpxQXLudemBDlSm kHTVki/gUcoz35AYQ5Hz9grJOzflY0Md4GMge23a8MOKyI4vG/bPkDU1cB0Ui9nz g6HpTo9KGjOtwUMrL8EOOukvy87Uq9UdfSbffIWDLo8o/RiicXsc+on+Oso9NXdZ mTI5atdoy6lseE9eaYxGrgmetAytq7nmr79/UBBVIh2WMxgqZjNHE360hUJx8HSQ O9TUmrx7VKViCZxIhSW0DnJz0ArHTqJ6E/kdsoy6OaM4PkGUGup9xqLe3eHoaFqp OvEHOplFor4XKOgt1n2JicJP6G+Wrw== =xyNh -----END PGP SIGNATURE----- --GdbWtwDHkcXqP16f-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D936C433DF for ; Mon, 22 Jun 2020 13:29:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADFDA20702 for ; Mon, 22 Jun 2020 13:29:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Z4oToh1K"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JBUfeRI4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADFDA20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1E6AD16CB; Mon, 22 Jun 2020 15:28:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1E6AD16CB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1592832566; bh=lhi0FntWbQp4WIrSKUUmGDerYj3VQxf+0v5+P6/doWc=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Z4oToh1Km3D2cU/s5epmPuD3fTm2u+0lArPrtrvX/zkvo2gCFbzY0Ag5yTx8vdsao VOMtYZ77xJff/ejMh+uB3RfJkUaMabCMJJbLoGI0lI+eBdDR75yFdJ6seWze1X0OD5 ZE2FmztjlnCLKUxwtPMecuLRM09TECWahBTtpvKI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 80E2AF801DB; Mon, 22 Jun 2020 15:28:12 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 270E3F801F2; Mon, 22 Jun 2020 15:28:08 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3BB67F8010E for ; Mon, 22 Jun 2020 15:28:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3BB67F8010E Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JBUfeRI4" Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D4DCF206D7; Mon, 22 Jun 2020 13:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592832479; bh=lhi0FntWbQp4WIrSKUUmGDerYj3VQxf+0v5+P6/doWc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JBUfeRI44+v7JXdB6xXg+hIdb2t30haIQsuAJLa0wyZmSthAEVhHdecY9uHhx85nL S4HuvyD0gC30/581rYJXWnWLQL2Xevq7246D7yJr74DluWtW9bCTlf60np6xoSIWfs NOGQclz2mgoEbpCOGEtVzf6tv7x9ltlrbjyyAi4U= Date: Mon, 22 Jun 2020 14:27:57 +0100 From: Mark Brown To: Sasha Levin Subject: Re: [PATCH AUTOSEL 5.7 004/388] ASoC: tegra: tegra_wm8903: Support nvidia, headset property Message-ID: <20200622132757.GG4560@sirena.org.uk> References: <20200618010805.600873-1-sashal@kernel.org> <20200618010805.600873-4-sashal@kernel.org> <20200618110023.GB5789@sirena.org.uk> <20200618143046.GT1931@sasha-vm> <20200618143930.GI5789@sirena.org.uk> <20200621233352.GA1931@sasha-vm> <20200622112321.GB4560@sirena.org.uk> <20200622123118.GF1931@sasha-vm> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GdbWtwDHkcXqP16f" Content-Disposition: inline In-Reply-To: <20200622123118.GF1931@sasha-vm> X-Cookie: laser, n.: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: linux-tegra@vger.kernel.org, Dmitry Osipenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --GdbWtwDHkcXqP16f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 22, 2020 at 08:31:18AM -0400, Sasha Levin wrote: > On Mon, Jun 22, 2020 at 12:23:21PM +0100, Mark Brown wrote: > > That's concerning - please don't do this. It's not what stable is > > expected to be and there's no guarantee that you're getting all the > > changes required to actually make things work. > How come? This is one of the things stable rules explicitly call for: > "New device IDs and quirks are also accepted". I would expect that to be data only additions, I would not expect that to be adding new code. > If we're missing anything, the solution is to make sure we stop missing > it rather than not take anything to begin with :) It would be much better to not have to watch stable constantly like we currently do - we're seeing people report breakage often enough to be a concern as things are, we don't need to be trying to pile extra stuff in there because there's some keywords in a changelog or whatever. The testing coverage for drivers is weak, increasing the change rate puts more stress on that. --GdbWtwDHkcXqP16f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7wsdwACgkQJNaLcl1U h9DAWgf+LXkPTWA3Nc4TkIaUcPd+6AtboLQyyP/9/zEkyr2ajDpxQXLudemBDlSm kHTVki/gUcoz35AYQ5Hz9grJOzflY0Md4GMge23a8MOKyI4vG/bPkDU1cB0Ui9nz g6HpTo9KGjOtwUMrL8EOOukvy87Uq9UdfSbffIWDLo8o/RiicXsc+on+Oso9NXdZ mTI5atdoy6lseE9eaYxGrgmetAytq7nmr79/UBBVIh2WMxgqZjNHE360hUJx8HSQ O9TUmrx7VKViCZxIhSW0DnJz0ArHTqJ6E/kdsoy6OaM4PkGUGup9xqLe3eHoaFqp OvEHOplFor4XKOgt1n2JicJP6G+Wrw== =xyNh -----END PGP SIGNATURE----- --GdbWtwDHkcXqP16f--