From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A05C433DF for ; Mon, 22 Jun 2020 12:21:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FF9520716 for ; Mon, 22 Jun 2020 12:21:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AZ/nrmSd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FF9520716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnLRz-0006ht-Er for qemu-devel@archiver.kernel.org; Mon, 22 Jun 2020 08:21:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnLLY-0001Rr-KH for qemu-devel@nongnu.org; Mon, 22 Jun 2020 08:14:44 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:26360 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jnLLW-0007P4-Pw for qemu-devel@nongnu.org; Mon, 22 Jun 2020 08:14:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592828081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CMLboNu1qxqZPPO8HVB4OJvxdDg36/k2iGV/iQP/PZs=; b=AZ/nrmSd61hw+f9FKfhiBNq44OshS7tO4RNBy388cgxIuAKlWcSr4pBaqi9s4qXgbYwm5L RY2oOagtWHWsYkMSip0pkd3B+5GKxKt+XxeuWdZzoFqG3slfJSqsPhx8bYEbhX/OZn0Twi M+008vPi0YkJAwnZyuoPqWevXQKDQvY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-AbU0wt0xMVeCE4069InVug-1; Mon, 22 Jun 2020 08:14:35 -0400 X-MC-Unique: AbU0wt0xMVeCE4069InVug-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D219107ACF9; Mon, 22 Jun 2020 12:14:34 +0000 (UTC) Received: from localhost (unknown [10.40.208.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id A06A01002396; Mon, 22 Jun 2020 12:14:16 +0000 (UTC) Date: Mon, 22 Jun 2020 14:14:12 +0200 From: Igor Mammedov To: Auger Eric Subject: Re: [PATCH v4 1/5] acpi: Convert build_tpm2() to build_append* API Message-ID: <20200622141412.0e5640f8@redhat.com> In-Reply-To: References: <20200611135917.18300-1-eric.auger@redhat.com> <20200611135917.18300-2-eric.auger@redhat.com> <20200616143327.2ee38a48@redhat.com> <3c3b466a-c965-e3f6-9bd6-74fce9c424c8@linux.ibm.com> <44663542-8352-2398-a297-3e1fe7f4bfd5@redhat.com> <20200622113915.1dce2989@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=205.139.110.120; envelope-from=imammedo@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/22 01:27:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, drjones@redhat.com, mst@redhat.com, Laszlo Ersek , qemu-devel@nongnu.org, shannon.zhaosl@gmail.com, qemu-arm@nongnu.org, marcandre.lureau@redhat.com, eric.auger.pro@gmail.com, philmd@redhat.com, ardb@kernel.org, Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 22 Jun 2020 11:47:26 +0200 Auger Eric wrote: > Hi Igor, >=20 > On 6/22/20 11:39 AM, Igor Mammedov wrote: > > On Fri, 19 Jun 2020 07:19:51 -0400 > > Stefan Berger wrote: > > =20 > >> On 6/19/20 5:43 AM, Auger Eric wrote: =20 > >>> Hi Laszlo, > >>> > >>> On 6/19/20 11:38 AM, Laszlo Ersek wrote: =20 > >>>> On 06/18/20 09:50, Auger Eric wrote: =20 > >>>>> Hi Stefan, Igor, > >>>>> > >>>>> On 6/16/20 4:11 PM, Stefan Berger wrote: =20 > >>>>>> On 6/16/20 8:33 AM, Igor Mammedov wrote: =20 > >>>>>>> nevertheless looks like faithfull conversion, > >>>>>>> btw why you didn't drop Acpi20TPM2 structure definition? > >>>>>>> =20 > >>>>>> If we get rid of the table we should keep a reference to this docu= ment, > >>>>>> table 7: "TCG ACPI Specification; Family 1.2 and 2.0; Level 00 Rev= ision > >>>>>> 00.37, December 19, 2014" > >>>>>> > >>>>>> https://trustedcomputinggroup.org/wp-content/uploads/TCG_ACPIGener= alSpecification_1-10_0-37-Published.pdf > >>>>>> > >>>>>> > >>>>>> =20 > >>>>> Further looking at this spec, the log_area_minimum_length and > >>>>> log_area_start_address only are described in > >>>>> - Table 2 (TCG Hardware InterfaceDescription Table Format for TPM 1= .2 > >>>>> Clients) > >>>>> - Table 4 (TCG Hardware Interface Description Table Format for TPM = 1.2 > >>>>> Servers) > >>>>> but not in Table 7, ie. not for TPM 2.0. > >>>>> > >>>>> Are they really needed for TPM2 or what do I miss? =20 > >>>> (side comment: > >>>> > >>>> LASA and LAML are optional with TPM-2.0. From the discussion at > >>>> . =20 > >> > >> > >> They are needed for (x86) BIOS, such as SeaBIOS, not for UEFI, though.= I=20 > >> do not know about ARM. > >> > >> =20 > >>> Thank you for the pointer and info. I failed to find this info in the > >>> spec. Given the risk of confusion, I would personally keep struct > >>> Acpi20TPM2 and maybe add a comment. Stefan? =20 > >> > >> Either way is fine with me for as long as we know where to find the=20 > >> layout of the structure. =20 > > I'd remove Acpi20TPM2 as it hardly documents anything, and add a commen= t > > pointing to the concrete spec that has these fields. > >=20 > > TCGTCG ACPI SpecificationFamily =E2=80=9C1.2=E2=80=9D and =E2=80=9C2.0= =E2=80=9DVersion 1.2,Revision 8 =20 >=20 > [PATCH v6 0/3] vTPM/aarch64 ACPI support was posted. >=20 > As documented in the cover letter (history log), the presence of the > LAML and LASA fields in the TPM2 table is not clearly documented in the > spec (at least I failed to find it). It is for TPM 1.2. On the other > hand, Stefan said it is mandated for some x86 BIOS to work. Given this > weirdness I think keeping the Acpi20TPM2 struct is not too bad. See v6 .= .. Laszlo pointed to spec version where LAML/LASA in TPM2 are documented, so I'd just use that as a spec this code is based on. PS: Acpi20TPM2 struct doesn't document anything, it's just another way to do the same thing as build_appen_* calls do. Having it just adds to confusion.= =20 >=20 > Thanks >=20 > Eric > > =20 > >> > >> =C2=A0 Stefan > >> =20 > >>> > >>> Thanks > >>> > >>> Eric =20 > >>>> ) > >>>> > >>>> Thanks > >>>> Laszlo > >>>> =20 > >> =20 > >=20 > > =20