From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Xj+s=AD=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 7BA56C433DF
	for <linux-kernel@archiver.kernel.org>; Mon, 22 Jun 2020 22:15:26 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 527ED2073E
	for <linux-kernel@archiver.kernel.org>; Mon, 22 Jun 2020 22:15:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1592864126;
	bh=vEPF3QHZSG88UIS1f+UfYPfeu2Wme3edT4i/j95Q9xc=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From;
	b=uTwa5v89Q0XxHb461nXEbuZM208k2r4b+7LTt7cYvx9civ6yMkWMisH5Rut+zFSG9
	 f4LyiilkeqjAZWMNnq0SZcns8AOBmTWyozhNyXIk1S7THLMEctguM0rAhhflEc9Um9
	 f2vrBXPrfyu5b/gl4q88rekHRpUvTt+69KFQqrKU=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730937AbgFVWPX (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 22 Jun 2020 18:15:23 -0400
Received: from mail.kernel.org ([198.145.29.99]:52690 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727018AbgFVWPX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 Jun 2020 18:15:23 -0400
Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.1])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 6191920738;
        Mon, 22 Jun 2020 22:15:22 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1592864122;
        bh=vEPF3QHZSG88UIS1f+UfYPfeu2Wme3edT4i/j95Q9xc=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=Y0MhcMwGCpIi3dZuB694pDXY7J8J7fevOTbdI4/weNvBzfLFHi8hSpDykOAB6lzOk
         O9HQKRYW9vU7UQX+Zf+eMHwKbCqUPsSVUjxI7RELhwGC1dg/KgJJADsQiRjgVAfhRn
         U5To28uUmCB+06pcb9AdoIYvcslRk/S5SRX/rczA=
Date:   Mon, 22 Jun 2020 15:15:20 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Luo bin <luobin9@huawei.com>
Cc:     <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>, <luoxianjun@huawei.com>,
        <yin.yinshi@huawei.com>, <cloud.wangxiaoyun@huawei.com>
Subject: Re: [PATCH net-next v1 5/5] hinic: add support to get eeprom
 information
Message-ID: <20200622151520.79ab2af9@kicinski-fedora-PC1C0HJN>
In-Reply-To: <20200620094258.13181-6-luobin9@huawei.com>
References: <20200620094258.13181-1-luobin9@huawei.com>
        <20200620094258.13181-6-luobin9@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 20 Jun 2020 17:42:58 +0800 Luo bin wrote:
> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_port.h b/drivers/net/ethernet/huawei/hinic/hinic_port.h
> index 5c916875f295..0d0354241345 100644
> --- a/drivers/net/ethernet/huawei/hinic/hinic_port.h
> +++ b/drivers/net/ethernet/huawei/hinic/hinic_port.h
> @@ -677,6 +677,37 @@ struct hinic_led_info {
>  	u8	reset;
>  };
>  
> +#define MODULE_TYPE_SFP		0x3
> +#define MODULE_TYPE_QSFP28	0x11
> +#define MODULE_TYPE_QSFP	0x0C
> +#define MODULE_TYPE_QSFP_PLUS	0x0D
> +
> +#define STD_SFP_INFO_MAX_SIZE	640

Please use the existing defines, e.g. from #include <linux/sfp.h>
there is no need for every driver to redefine those constants.