From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09028C433DF for ; Mon, 22 Jun 2020 16:33:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E14DA20767 for ; Mon, 22 Jun 2020 16:33:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729718AbgFVQd4 (ORCPT ); Mon, 22 Jun 2020 12:33:56 -0400 Received: from mga18.intel.com ([134.134.136.126]:57928 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729604AbgFVQdz (ORCPT ); Mon, 22 Jun 2020 12:33:55 -0400 IronPort-SDR: RtKf2HnctkeV+fLtTsK1C6Fv6VnbwChHlDzo8zRFNc0CfUkpfAe+2YaS3IsWuM3ZfkH/EzG1Wm jjOKiDZ8PtLw== X-IronPort-AV: E=McAfee;i="6000,8403,9660"; a="131207938" X-IronPort-AV: E=Sophos;i="5.75,267,1589266800"; d="scan'208";a="131207938" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2020 09:33:52 -0700 IronPort-SDR: ESHbFLnXvnDSL1D0OdIFiAZK6C1vaYwL7oK7wBCTVAzWtJoezumLNVWBaI7TIxhcnDo4Aw2Ycx JRu3Juo31MaA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,267,1589266800"; d="scan'208";a="478516569" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga005.fm.intel.com with SMTP; 22 Jun 2020 09:33:48 -0700 Received: by lahna (sSMTP sendmail emulation); Mon, 22 Jun 2020 19:33:48 +0300 Date: Mon, 22 Jun 2020 19:33:48 +0300 From: Mika Westerberg To: Yehezkel Bernat Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, Michael Jamet , "David S . Miller" , Jakub Kicinski , Andreas Noever , Lukas Wunner , netdev@vger.kernel.org Subject: Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround Message-ID: <20200622163348.GU2795@lahna.fi.intel.com> References: <20200615135112.GA1402792@kroah.com> <20200615142247.GN247495@lahna.fi.intel.com> <20200615153249.GR247495@lahna.fi.intel.com> <20200615155512.GS247495@lahna.fi.intel.com> <20200616115520.GK2795@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200616115520.GK2795@lahna.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jun 16, 2020 at 02:55:25PM +0300, Mika Westerberg wrote: > On Mon, Jun 15, 2020 at 10:54:52PM +0300, Yehezkel Bernat wrote: > > On Mon, Jun 15, 2020 at 6:55 PM Mika Westerberg > > wrote: > > > > > > On Mon, Jun 15, 2020 at 06:41:32PM +0300, Yehezkel Bernat wrote: > > > > > I think you are talking about the "prtstns" property in the network > > > > > driver. There we only set TBNET_MATCH_FRAGS_ID (bit 1). This is the > > > > > thing that get exposed to the other side of the connection and we never > > > > > announced support for full E2E. > > > > > > > > > > > > Ah, yes, this one, Thanks! > > > > As Windows driver uses it for flagging full-E2E, and we completely drop E2E > > > > support here, it may worth to mention there that this is what bit 2 is used in > > > > Windows so any reuse should consider the possible compatibility issue. > > > > > > Note we only drop dead code in this patch. It is that workaround for > > > Falcon Ridge controller we actually never used. > > > > > > I can add a comment to the network driver about the full E2E support > > > flag as a separate patch if you think it is useful. > > > > > > The network protocol will be public soon I guess because USB4 spec > > > refers to "USB4 Inter-Domain Specification, Revision 1.0, [to be > > > published] – (USB4 Inter-Domain Specification)" so I would expect it to > > > be explained there as well. > > > > I see. I leave it for your decision, then. > > Thanks for bearing with me. > > OK, I think it makes sense to add the comment so I'll do that as > a separate patch (will probably go next week since I have some other > patches to deal with this week, and Friday is holiday in Finland). OK, I sent it now and can be found here: https://lore.kernel.org/netdev/20200622163022.53298-1-mika.westerberg@linux.intel.com/