From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E83EC433E0 for ; Tue, 23 Jun 2020 00:54:40 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C15DA20706 for ; Tue, 23 Jun 2020 00:54:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="eD2zNURL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C15DA20706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49rSV50pRkzDqTy for ; Tue, 23 Jun 2020 10:54:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=chromium.org (client-ip=2607:f8b0:4864:20::1044; helo=mail-pj1-x1044.google.com; envelope-from=keescook@chromium.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=eD2zNURL; dkim-atps=neutral Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49rSKL0gVfzDqTq for ; Tue, 23 Jun 2020 10:47:01 +1000 (AEST) Received: by mail-pj1-x1044.google.com with SMTP id cm23so724956pjb.5 for ; Mon, 22 Jun 2020 17:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zu4OU7IGZiTsvIaDwmyLbj4I9ozbACkG/Mn2gAIRkbg=; b=eD2zNURLgHPqg/d00zOemVc/uWc9XFUrQc9T/r0CfHnQ37J5w12dtxWOt/XLxUaoPr oPBZAAlU/s8JvF08Eg5Uwe6Yf/qJtxl/cKLc4YjjZ2omXW0o0Dck4uICr1tn5iEyOb+s XrFSioDSrXqS4AKWpDQOm1ZEp45q7IQaD6sek= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zu4OU7IGZiTsvIaDwmyLbj4I9ozbACkG/Mn2gAIRkbg=; b=B6EdmpH+uXkSJ6nx0Vn062KRGXVs1Diq+LVeDE/xNaZAQnyL6FB3GXu2vllGE/IUfp gIipPZQ0wYJGWQQGZF9PJCM992sxp+TJTsRFvI1uuZcmtzIMBXiTMsWtvEV4BYQcPoig 4nihiUWpRVf5p2bXVkfQm23iKn7Nf2F86oI2slopBYvNA3nFt/yxYciOLLzmwTagIhgg fXEDxprODD3At9WNZ7228vKHlhsv9BA6adjTMqTPyvipbHY1AR3kq56h6uOkRZtwK+Xu zmlZa3In47hIw+xmBURkDNaxAzWsS1LwogVkY0jzdWKUcxMEt/wH1mq4FPo5sX42TU2y Ar1w== X-Gm-Message-State: AOAM532sOxKUvo3uXLdr1wFpmXvg/1hmbyAPfVJjTHk1JKQJpQjmVOlS I5IRuEldqqFw2bbcm1AaF3XZhQ== X-Google-Smtp-Source: ABdhPJwLqwCQ0Rost0KalBZ/gdRO16zHbQi9rscaK3Ne64vv0f4wO0Oby1WybaoTmJuLYB1GYOmDPw== X-Received: by 2002:a17:90a:ee82:: with SMTP id i2mr21052514pjz.29.1592873218628; Mon, 22 Jun 2020 17:46:58 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id ii17sm383343pjb.56.2020.06.22.17.46.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 17:46:57 -0700 (PDT) Date: Mon, 22 Jun 2020 17:46:56 -0700 From: Kees Cook To: Christian Brauner Subject: Re: [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread() Message-ID: <202006221745.5999CF5@keescook> References: <20200622234326.906346-1-christian.brauner@ubuntu.com> <20200622234326.906346-18-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200622234326.906346-18-christian.brauner@ubuntu.com> X-Mailman-Approved-At: Tue, 23 Jun 2020 10:49:20 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , linux-sh@vger.kernel.org, "Peter Zijlstra \(Intel\)" , Catalin Marinas , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Guo Ren , "Matthew Wilcox \(Oracle\)" , "H. Peter Anvin" , sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, Vincent Chen , Will Deacon , Thomas Gleixner , Anton Ivanov , Jonas Bonn , linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Brian Cain , linux-xtensa@linux-xtensa.org, Helge Deller , x86@kernel.org, Russell King , Ley Foon Tan , Christian Borntraeger , Ingo Molnar , Geert Uytterhoeven , linux-parisc@vger.kernel.org, Mark Salter , Matt Turner , linux-snps-arc@lists.infradead.org, uclinux-h8-devel@lists.sourceforge.jp, Fenghua Yu , Albert Ou , linux-csky@vger.kernel.org, Jeff Dike , linux-alpha@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Aurelien Jacquiot , linux-m68k@lists.linux-m68k.org, Thomas Bogendoerfer , Ivan Kokshaysky , Greentime Hu , Paul Walmsley , Stafford Horne , Stefan Kristiansson , Guan Xuetao , linux-arm-kernel@lists.infradead.org, Richard Henderson , Chris Zankel , Michal Simek , Tony Luck , Yoshinori Sato , Nick Hu , Vineet Gupta , linux-kernel@vger.kernel.org, openrisc@lists.librecores.org, Palmer Dabbelt , Richard Weinberger , Paul Mackerras , Linus Torvalds , "David S. Miller" , Al Viro Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jun 23, 2020 at 01:43:26AM +0200, Christian Brauner wrote: > Now that HAVE_COPY_THREAD_TLS has been removed, rename copy_thread_tls() > back simply copy_thread(). It's a simpler name, and doesn't imply that only > tls is copied here. This finishes an outstanding chunk of internal process > creation work since we've added clone3(). > [...] > -copy_thread_tls(unsigned long clone_flags, unsigned long user_stack_base, > +copy_thread(unsigned long clone_flags, unsigned long user_stack_base, > unsigned long user_stack_size, struct task_struct *p, > unsigned long tls) Maybe clean up the arg indentation too? I'm not sure how strongly people feel about that, but I think it'd be nice. Either way: Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Date: Mon, 22 Jun 2020 17:46:56 -0700 Subject: [OpenRISC] [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread() In-Reply-To: <20200622234326.906346-18-christian.brauner@ubuntu.com> References: <20200622234326.906346-1-christian.brauner@ubuntu.com> <20200622234326.906346-18-christian.brauner@ubuntu.com> Message-ID: <202006221745.5999CF5@keescook> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org On Tue, Jun 23, 2020 at 01:43:26AM +0200, Christian Brauner wrote: > Now that HAVE_COPY_THREAD_TLS has been removed, rename copy_thread_tls() > back simply copy_thread(). It's a simpler name, and doesn't imply that only > tls is copied here. This finishes an outstanding chunk of internal process > creation work since we've added clone3(). > [...] > -copy_thread_tls(unsigned long clone_flags, unsigned long user_stack_base, > +copy_thread(unsigned long clone_flags, unsigned long user_stack_base, > unsigned long user_stack_size, struct task_struct *p, > unsigned long tls) Maybe clean up the arg indentation too? I'm not sure how strongly people feel about that, but I think it'd be nice. Either way: Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 22 Jun 2020 17:46:56 -0700 From: Kees Cook Subject: Re: [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread() Message-ID: <202006221745.5999CF5@keescook> References: <20200622234326.906346-1-christian.brauner@ubuntu.com> <20200622234326.906346-18-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200622234326.906346-18-christian.brauner@ubuntu.com> To: Christian Brauner Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Mark Salter , Aurelien Jacquiot , Guo Ren , Yoshinori Sato , Brian Cain , Tony Luck , Fenghua Yu , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Nick Hu , Greentime Hu , Vincent Chen , Ley Foon Tan , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Rich Felker , "David S. Miller" , Jeff Dike , Richard Weinberger , Anton Ivanov , Guan Xuetao , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , Chris Zankel , Max Filippov , "Peter Zijlstra (Intel)" , "Matthew Wilcox (Oracle)" , Al Viro , linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-csky@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org List-ID: On Tue, Jun 23, 2020 at 01:43:26AM +0200, Christian Brauner wrote: > Now that HAVE_COPY_THREAD_TLS has been removed, rename copy_thread_tls() > back simply copy_thread(). It's a simpler name, and doesn't imply that only > tls is copied here. This finishes an outstanding chunk of internal process > creation work since we've added clone3(). > [...] > -copy_thread_tls(unsigned long clone_flags, unsigned long user_stack_base, > +copy_thread(unsigned long clone_flags, unsigned long user_stack_base, > unsigned long user_stack_size, struct task_struct *p, > unsigned long tls) Maybe clean up the arg indentation too? I'm not sure how strongly people feel about that, but I think it'd be nice. Either way: Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread() Date: Mon, 22 Jun 2020 17:46:56 -0700 Message-ID: <202006221745.5999CF5@keescook> References: <20200622234326.906346-1-christian.brauner@ubuntu.com> <20200622234326.906346-18-christian.brauner@ubuntu.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zu4OU7IGZiTsvIaDwmyLbj4I9ozbACkG/Mn2gAIRkbg=; b=eD2zNURLgHPqg/d00zOemVc/uWc9XFUrQc9T/r0CfHnQ37J5w12dtxWOt/XLxUaoPr oPBZAAlU/s8JvF08Eg5Uwe6Yf/qJtxl/cKLc4YjjZ2omXW0o0Dck4uICr1tn5iEyOb+s XrFSioDSrXqS4AKWpDQOm1ZEp45q7IQaD6sek= Content-Disposition: inline In-Reply-To: <20200622234326.906346-18-christian.brauner@ubuntu.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane-mx.org@lists.ozlabs.org Sender: "Linuxppc-dev" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christian Brauner Cc: Rich Felker , linux-sh@vger.kernel.org, "Peter Zijlstra (Intel)" , Catalin Marinas , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Guo Ren , "Matthew Wilcox (Oracle)" , "H. Peter Anvin" , sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, Vincent Chen , Will Deacon , Thomas Gleixner , Anton Ivanov , Jonas Bonn , linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Brian Cain , linux-xtensa@linux-xtensa.org, Helge Deller , x86@kernel.org, Russell King <> On Tue, Jun 23, 2020 at 01:43:26AM +0200, Christian Brauner wrote: > Now that HAVE_COPY_THREAD_TLS has been removed, rename copy_thread_tls() > back simply copy_thread(). It's a simpler name, and doesn't imply that only > tls is copied here. This finishes an outstanding chunk of internal process > creation work since we've added clone3(). > [...] > -copy_thread_tls(unsigned long clone_flags, unsigned long user_stack_base, > +copy_thread(unsigned long clone_flags, unsigned long user_stack_base, > unsigned long user_stack_size, struct task_struct *p, > unsigned long tls) Maybe clean up the arg indentation too? I'm not sure how strongly people feel about that, but I think it'd be nice. Either way: Reviewed-by: Kees Cook -- Kees Cook