From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF5FAC433DF for ; Mon, 22 Jun 2020 18:52:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF26E206FA for ; Mon, 22 Jun 2020 18:52:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730150AbgFVSw1 (ORCPT ); Mon, 22 Jun 2020 14:52:27 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:54004 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730030AbgFVSw1 (ORCPT ); Mon, 22 Jun 2020 14:52:27 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jnRYP-001hz7-Fk; Mon, 22 Jun 2020 20:52:25 +0200 Date: Mon, 22 Jun 2020 20:52:25 +0200 From: Andrew Lunn To: Daniel Mack Cc: netdev@vger.kernel.org, vivien.didelot@gmail.com, f.fainelli@gmail.com, linux@armlinux.org.uk Subject: Re: [PATCH] net: dsa: mv88e6xxx: Allow MAC configuration for ports with internal PHY Message-ID: <20200622185225.GF405672@lunn.ch> References: <20200622183443.3355240-1-daniel@zonque.org> <20200622184115.GE405672@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 22, 2020 at 08:44:51PM +0200, Daniel Mack wrote: > On 6/22/20 8:41 PM, Andrew Lunn wrote: > > On Mon, Jun 22, 2020 at 08:34:43PM +0200, Daniel Mack wrote: > >> Ports with internal PHYs that are not in 'fixed-link' mode are currently > >> only set up once at startup with a static config. Attempts to change the > >> link speed or duplex settings are currently prevented by an early bail > >> in mv88e6xxx_mac_config(). As the default config forces the speed to > >> 1000M, setups with reduced link speed on such ports are unsupported. > > > > Hi Daniel > > > > How are you trying to change the speed? > > With ethtool for instance. But all userspace tools are bailing out early > on this port for the reason I described. So you mean ethtool -s devname advertise 0x001 set make it advertise 10BaseT Half? Andrew