From: mark gross <mgross@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Borislav Petkov <bp@suse.de>,
Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH] cpu/speculation: Add prototype for cpu_show_srbds
Date: Mon, 22 Jun 2020 12:08:14 -0700 [thread overview]
Message-ID: <20200622190814.GA13232@mtg-dev.jf.intel.com> (raw)
In-Reply-To: <20200617141410.93338-1-linux@roeck-us.net>
ack
Reviewed-by: mark gross <mgross@linux.intel.com>
--mark
On Wed, Jun 17, 2020 at 07:14:10AM -0700, Guenter Roeck wrote:
> 0-day is not happy that there is no prototype for cpu_show_srbds().
>
> drivers/base/cpu.c:565:16: error:
> no previous prototype for 'cpu_show_srbds'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 7e5b3c267d25 ("x86/speculation: Add Special Register Buffer Data Sampling (SRBDS) mitigation")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> include/linux/cpu.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/cpu.h b/include/linux/cpu.h
> index 52692587f7fe..8aa84c052fdf 100644
> --- a/include/linux/cpu.h
> +++ b/include/linux/cpu.h
> @@ -64,6 +64,7 @@ extern ssize_t cpu_show_tsx_async_abort(struct device *dev,
> char *buf);
> extern ssize_t cpu_show_itlb_multihit(struct device *dev,
> struct device_attribute *attr, char *buf);
> +extern ssize_t cpu_show_srbds(struct device *dev, struct device_attribute *attr, char *buf);
>
> extern __printf(4, 5)
> struct device *cpu_device_create(struct device *parent, void *drvdata,
> --
> 2.17.1
>
prev parent reply other threads:[~2020-06-22 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 14:14 Guenter Roeck
2020-06-17 15:48 ` [tip: x86/cleanups] cpu/speculation: Add prototype for cpu_show_srbds() tip-bot2 for Guenter Roeck
2020-06-22 19:08 ` mark gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622190814.GA13232@mtg-dev.jf.intel.com \
--to=mgross@linux.intel.com \
--cc=bp@suse.de \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tglx@linutronix.de \
--subject='Re: [PATCH] cpu/speculation: Add prototype for cpu_show_srbds' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.