From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4452AC433E0 for ; Tue, 23 Jun 2020 06:20:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20C6B2070E for ; Tue, 23 Jun 2020 06:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592893234; bh=Dxxtu9JejAl8IVsxWoK8TC+TGSvvbQrjHiwpR/3/1ng=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=VK4wk5EC+xb0qK8TIMtjAFFU6Fn/xQqov79xzYTD1F7p6SU1jRa/dkN2+hsN2E9RU Abcx1Ze6Xuc+eOX8wWnNZE1zzgT/OPeaFEzsAxJLGW1U0bVy4Z4YXDp8DhKRxipO9h sJO1CQfYx6M4vvvr6KQnr4wslXKHJ5wl5m3ibb/8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730852AbgFWGUc (ORCPT ); Tue, 23 Jun 2020 02:20:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:40346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730510AbgFWGUc (ORCPT ); Tue, 23 Jun 2020 02:20:32 -0400 Received: from coco.lan (unknown [95.90.213.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6FBF820720; Tue, 23 Jun 2020 06:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592893231; bh=Dxxtu9JejAl8IVsxWoK8TC+TGSvvbQrjHiwpR/3/1ng=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xiCNweWMDBrmlOdtr3Nz9fvmudwtUf8FgnWO/KvRuTdTH19r5jFz+kQpF36lfcser cGjqt1Bp/vRd6H0Z5ucCAY9GXYq40M/kagvXhXqUlCzblYYr6a1H17k0eL2yKBCTYj AT5TBqE+0uRB6svC2t1jX72L8GY5w7UANmpx/olQ= Date: Tue, 23 Jun 2020 08:20:26 +0200 From: Mauro Carvalho Chehab To: Nathan Chancellor Cc: Andrew Morton , Laurent Pinchart , Arnd Bergmann , Christoph Hellwig , Geert Uytterhoeven , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH 1/2] media: omap3isp: Remove cacheflush.h Message-ID: <20200623082026.055d361a@coco.lan> In-Reply-To: <20200622234740.72825-2-natechancellor@gmail.com> References: <20200622234740.72825-1-natechancellor@gmail.com> <20200622234740.72825-2-natechancellor@gmail.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, 22 Jun 2020 16:47:39 -0700 Nathan Chancellor escreveu: > After mm.h was removed from the asm-generic version of cacheflush.h, > s390 allyesconfig shows several warnings of the following nature: > > In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, > from drivers/media/platform/omap3isp/isp.c:42: > ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' > declared inside parameter list will not be visible outside of this > definition or declaration > > As Geert and Laurent point out, this driver does not need this header in > the two files that include it. Remove it so there are no warnings. > > Fixes: e0cf615d725c ("asm-generic: don't include in cacheflush.h") > Suggested-by: Geert Uytterhoeven > Suggested-by: Laurent Pinchart > Signed-off-by: Nathan Chancellor Reviewed-by: Mauro Carvalho Chehab > --- > drivers/media/platform/omap3isp/isp.c | 2 -- > drivers/media/platform/omap3isp/ispvideo.c | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a4ee6b86663e..b91e472ee764 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -39,8 +39,6 @@ > * Troy Laramy > */ > > -#include > - > #include > #include > #include > diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c > index 10c214bd0903..1ac9aef70dff 100644 > --- a/drivers/media/platform/omap3isp/ispvideo.c > +++ b/drivers/media/platform/omap3isp/ispvideo.c > @@ -18,7 +18,6 @@ > #include > #include > #include > -#include > > #include > #include > > base-commit: 27f11fea33608cbd321a97cbecfa2ef97dcc1821 Thanks, Mauro