From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: vfeenstr@redhat.com, sw@weilnetz.de, mdroth@linux.vnet.ibm.com,
qemu-devel@nongnu.org, marcandre.lureau@gmail.com,
pbonzini@redhat.com
Subject: Re: [PATCH v3 2/2] qga: Use qemu_get_host_name() instead of g_get_host_name()
Date: Tue, 23 Jun 2020 09:50:43 +0100 [thread overview]
Message-ID: <20200623085043.GD751477@redhat.com> (raw)
In-Reply-To: <873fc5052847ee5df75a75e30960d6d4ab44473b.1592849834.git.mprivozn@redhat.com>
On Mon, Jun 22, 2020 at 08:19:36PM +0200, Michal Privoznik wrote:
> Problem with g_get_host_name() is that on the first call it saves
> the hostname into a global variable and from then on, every
> subsequent call returns the saved hostname. Even if the hostname
> changes. This doesn't play nicely with guest agent, because if
> the hostname is acquired before the guest is set up (e.g. on the
> first boot, or before DHCP) we will report old, invalid hostname.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1845127
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
> qga/commands.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-06-23 8:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 18:19 [PATCH v3 0/2] qga: Ditch g_get_host_name() Michal Privoznik
2020-06-22 18:19 ` [PATCH v3 1/2] util: Introduce qemu_get_host_name() Michal Privoznik
2020-06-22 18:37 ` Philippe Mathieu-Daudé
2020-06-23 8:50 ` Daniel P. Berrangé
2020-06-22 18:19 ` [PATCH v3 2/2] qga: Use qemu_get_host_name() instead of g_get_host_name() Michal Privoznik
2020-06-23 8:50 ` Daniel P. Berrangé [this message]
2020-07-10 9:43 ` [PATCH v3 0/2] qga: Ditch g_get_host_name() Michal Privoznik
2020-07-13 10:57 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623085043.GD751477@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mprivozn@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=vfeenstr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.