All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tobias Klauser <tklauser@distanz.ch>
To: Quentin Monnet <quentin@isovalent.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andriin@fb.com>,
	bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next 1/2] tools, bpftool: Define prog_type_name array only once
Date: Tue, 23 Jun 2020 11:58:20 +0200	[thread overview]
Message-ID: <20200623095820.3xiwsfaxsxyyosbt@distanz.ch> (raw)
In-Reply-To: <2df810b0-b31d-641a-9d81-47eb11c3f0a4@isovalent.com>

On 2020-06-22 at 17:17:04 +0200, Quentin Monnet <quentin@isovalent.com> wrote:
> 2020-06-22 17:05 UTC+0200 ~ Tobias Klauser <tklauser@distanz.ch>
> > On 2020-06-22 at 16:26:17 +0200, Quentin Monnet <quentin@isovalent.com> wrote:
> >> 2020-06-22 16:00 UTC+0200 ~ Tobias Klauser <tklauser@distanz.ch>
> >>> Follow the same approach as for map_type_name. This leads to a slight
> >>
> >> map_type_name looks unchanged in this series, could you please check
> >> your commit log?
> > 
> > Yes this patch intentionally shouldn't change map_type_name. The idea
> > was to say "do the same thing for prog_type_name name as is already done
> > for map_type_name". I can rephrase that to become more clear if you
> > want.
> 
> Ok sorry, I thought you meant map_type_name had been moved to reduce the
> size as well. I think I got confused by "Follow the same approach",
> since map_type_name has always been in map.c, but it's both
> prog_type_name and attach_type_name that were moved to main.h from their
> original files some time ago (so not much to "follow" from map_type_name).
> 
> Anyway, minor confusion on my side, no need to respin just for that.
> Thanks for the clarification.

Will send a v2 to address Andrii's comment on patch 2/2, so I'll
rephrase the commit message on this patch to be less confusing.

Tobias

  reply	other threads:[~2020-06-23  9:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-22 14:00 [PATCH bpf-next 0/2] tools, bpftool: Define name arrays only once Tobias Klauser
2020-06-22 14:00 ` [PATCH bpf-next 1/2] tools, bpftool: Define prog_type_name array " Tobias Klauser
2020-06-22 14:26   ` Quentin Monnet
2020-06-22 15:05     ` Tobias Klauser
2020-06-22 15:17       ` Quentin Monnet
2020-06-23  9:58         ` Tobias Klauser [this message]
2020-06-22 14:00 ` [PATCH bpf-next 2/2] tools, bpftool: Define attach_type_name " Tobias Klauser
2020-06-23  5:58   ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200623095820.3xiwsfaxsxyyosbt@distanz.ch \
    --to=tklauser@distanz.ch \
    --cc=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=quentin@isovalent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.