From: Jakub Kicinski <kuba@kernel.org>
To: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"Kwapulinski, Piotr" <piotr.kwapulinski@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"nhorman@redhat.com" <nhorman@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
"Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>,
"Bowers, AndrewX" <andrewx.bowers@intel.com>
Subject: Re: [net-next 4/9] i40e: detect and log info about pre-recovery mode
Date: Tue, 23 Jun 2020 13:40:37 -0700 [thread overview]
Message-ID: <20200623134037.3cde6263@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <61CC2BC414934749BD9F5BF3D5D94044987324EF@ORSMSX112.amr.corp.intel.com>
On Tue, 23 Jun 2020 03:13:35 +0000 Kirsher, Jeffrey T wrote:
> In patch 8, the functions are not so small and simple. Are you sure
> the compiler would inline them if we did not explicitly 'inline'
> them? I want to make sure before making that change.
I'm not, but why are they supposed to be inlined - programming promisc
seems hardly to be so performance sensitive we can't take a function
call...
Also can the functions be reordered there so no forward declarations
are needed?
next prev parent reply other threads:[~2020-06-23 20:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 22:18 [net-next 0/9][pull request] 40GbE Intel Wired LAN Driver Updates 2020-06-22 Jeff Kirsher
2020-06-22 22:18 ` [net-next 1/9] i40e: Move client header location Jeff Kirsher
2020-06-22 22:18 ` [net-next 2/9] i40e: remove unused defines Jeff Kirsher
2020-06-23 0:47 ` Shannon Nelson
2020-06-22 22:18 ` [net-next 3/9] i40e: make PF wait reset loop reliable Jeff Kirsher
2020-06-22 22:18 ` [net-next 4/9] i40e: detect and log info about pre-recovery mode Jeff Kirsher
2020-06-22 23:55 ` Jakub Kicinski
2020-06-23 0:18 ` Kirsher, Jeffrey T
2020-06-23 0:29 ` Jakub Kicinski
2020-06-23 0:41 ` Kirsher, Jeffrey T
2020-06-23 3:13 ` Kirsher, Jeffrey T
2020-06-23 20:40 ` Jakub Kicinski [this message]
2020-06-22 22:18 ` [net-next 5/9] i40e: Add a check to see if MFS is set Jeff Kirsher
2020-06-22 22:18 ` [net-next 6/9] net/intel: remove driver versions from Intel drivers Jeff Kirsher
2020-06-22 22:18 ` [net-next 7/9] i40e: Add support for 5Gbps cards Jeff Kirsher
2020-06-22 22:18 ` [net-next 8/9] i40e: Remove scheduling while atomic possibility Jeff Kirsher
2020-06-22 22:18 ` [net-next 9/9] i40e: silence an UBSAN false positive Jeff Kirsher
2020-06-23 0:35 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623134037.3cde6263@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=andrewx.bowers@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=piotr.kwapulinski@intel.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.