From: Maxime Ripard <maxime@cerno.tech>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Dinghao Liu <dinghao.liu@zju.edu.cn>,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, Aditya Pakki <pakki001@umn.edu>,
Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Qiushi Wu <wu000273@umn.edu>,
linux-kernel@vger.kernel.org, YueHaibing <yuehaibing@huawei.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Eric Biggers <ebiggers@google.com>,
"David S. Miller" <davem@davemloft.net>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
Chen-Yu Tsai <wens@csie.org>
Subject: Re: [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init
Date: Tue, 23 Jun 2020 15:44:42 +0200 [thread overview]
Message-ID: <20200623134442.wj4i3r3dlp6rtpaq@gilmour.lan> (raw)
In-Reply-To: <265c3a75-f8ce-fb34-d559-39e58a4dfb4f@web.de>
On Mon, Jun 22, 2020 at 07:50:08PM +0200, Markus Elfring wrote:
> > Fix this by …
>
> Please replace the beginning of this sentence with the tag “Fixes”.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183
No, not really. The comment you (partially) quoted explains how the
issue is fixed, your suggestion explains what commit introduced the fix
in the first place. They are both beneficial, but there's strictly no
reason to remove the former for the latter.
Maxime
next prev parent reply other threads:[~2020-06-23 13:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 17:50 [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init Markus Elfring
2020-06-23 13:44 ` Maxime Ripard [this message]
2020-06-23 15:00 ` Markus Elfring
2020-06-23 15:00 ` Markus Elfring
2020-06-23 16:56 ` Maxime Ripard
2020-06-23 16:56 ` Maxime Ripard
2020-06-23 18:12 ` Markus Elfring
2020-06-23 18:12 ` Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-06-22 2:40 Dinghao Liu
2020-07-03 4:47 ` Herbert Xu
2020-07-03 4:47 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623134442.wj4i3r3dlp6rtpaq@gilmour.lan \
--to=maxime@cerno.tech \
--cc=Markus.Elfring@web.de \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=dinghao.liu@zju.edu.cn \
--cc=ebiggers@google.com \
--cc=emamd001@umn.edu \
--cc=herbert@gondor.apana.org.au \
--cc=kjlu@umn.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=pakki001@umn.edu \
--cc=wens@csie.org \
--cc=wu000273@umn.edu \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.