From: Gao Xiang <hsiangkao@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH v2] xfs: add test for CVE-2020-12655
Date: Tue, 23 Jun 2020 23:30:37 +0800 [thread overview]
Message-ID: <20200623153037.GB31326@xiangao.remote.csb> (raw)
In-Reply-To: <20200623152352.GA7600@magnolia>
Hi Darrick,
On Tue, Jun 23, 2020 at 08:23:52AM -0700, Darrick J. Wong wrote:
...
> > +
> > + _scratch_unmount > /dev/null 2>&1
> > + [ $mounted -eq 0 -o $hasmsg -eq 1 ] && return
> > + _fail "potential broken kernel"
>
> Could you print both variables in the error message so that it's easier
> to figure out where exactly we went wrong?
Okay, will fix in the next version (tomorrow, about to sleep...)
>
...
> > 518 auto quick quota
> > 519 auto quick reflink
> > +520 auto quick reflink dangerous
>
> Hmmm... I guess the fix has been out for a while, so it's less shocking
> to put a dangerous test in the auto group?
Okay, will update it (I'm backporting the fix to old old kernels...
and some you know....). Thanks for the review!
Thanks,
Gao Xiang
>
> --D
>
> > --
> > 2.18.1
> >
>
next prev parent reply other threads:[~2020-06-23 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 13:44 [PATCH] xfs: add test for CVE-2020-12655 Gao Xiang
2020-06-23 2:04 ` [PATCH v2] " Gao Xiang
2020-06-23 15:23 ` Darrick J. Wong
2020-06-23 15:30 ` Gao Xiang [this message]
2020-06-24 1:06 ` [PATCH v3] " Gao Xiang
2020-06-24 15:18 ` Darrick J. Wong
2020-06-25 3:15 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623153037.GB31326@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.