From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D0E4C433E0 for ; Tue, 23 Jun 2020 20:36:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 249BA20781 for ; Tue, 23 Jun 2020 20:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944568; bh=+YPoB9eHkOMFYGLz+Lv8xbqdACT5IpHWZ4XdKQJ1088=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HD6fdEJBEitSjz62uQoJzzVttMA60Yh2ZoPxvi2ciJ+IAu1yrdypeDbV/veBbyWvH kJszlXrIsniVwBwzJNZlk1v1ByWacLG5QsDNc+ncob8XwGHyqVSIuUmmdMaX72k6nN PbjTCOUDZ/pa3L7eXCrk9Q5YlBUW9MRf8B8f0xI8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391764AbgFWUgG (ORCPT ); Tue, 23 Jun 2020 16:36:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:58846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391754AbgFWUf7 (ORCPT ); Tue, 23 Jun 2020 16:35:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CCD7920836; Tue, 23 Jun 2020 20:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944559; bh=+YPoB9eHkOMFYGLz+Lv8xbqdACT5IpHWZ4XdKQJ1088=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KDmySFafKbt6iMN7cg/jATAB6h8r1nUP3qn4Liwjj2xQgt6Iz+z/CaEy6h+hY+Lv5 KbwvTe8vcyS8fuIV78EmUqLzQEAdDPTM2ZhicJ3CDa9fogP53KD2Atw0Wz4hwLWUHX xmTcMen0T8o+SIUfsuTV+RX2YBPwdwlzLCBiS2tE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Wang Hai , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 037/206] yam: fix possible memory leak in yam_init_driver Date: Tue, 23 Jun 2020 21:56:05 +0200 Message-Id: <20200623195318.806435031@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195316.864547658@linuxfoundation.org> References: <20200623195316.864547658@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wang Hai [ Upstream commit 98749b7188affbf2900c2aab704a8853901d1139 ] If register_netdev(dev) fails, free_netdev(dev) needs to be called, otherwise a memory leak will occur. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Hulk Robot Signed-off-by: Wang Hai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/hamradio/yam.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c index ba9df430fca6e..fdab498725878 100644 --- a/drivers/net/hamradio/yam.c +++ b/drivers/net/hamradio/yam.c @@ -1148,6 +1148,7 @@ static int __init yam_init_driver(void) err = register_netdev(dev); if (err) { printk(KERN_WARNING "yam: cannot register net device %s\n", dev->name); + free_netdev(dev); goto error; } yam_devs[i] = dev; -- 2.25.1