From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EBEAC433E0 for ; Tue, 23 Jun 2020 20:42:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F394620767 for ; Tue, 23 Jun 2020 20:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944960; bh=oLM9mZZYs/YSKFC3NB04AuXd89VQrWwoajHorXVHtNs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=kG27OI1pKHXwiX/PPjXDZchlsvkjBvUq2mr1CpineuPTF0luh4OFBJ1chSDWBNJOR ql5OcO/Z24K5Kut2P5X1v4Eq9XcQanRjDx/GpOLyXvrzS+JFaKMwBYM0TUO+qOAgJJ UYVYcE6WK/xRXIpdqsppkWDuLOmJdQUeHt8OPL4s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403880AbgFWUmh (ORCPT ); Tue, 23 Jun 2020 16:42:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:39124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391802AbgFWUmb (ORCPT ); Tue, 23 Jun 2020 16:42:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 791B02053B; Tue, 23 Jun 2020 20:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944952; bh=oLM9mZZYs/YSKFC3NB04AuXd89VQrWwoajHorXVHtNs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sDmYGpjTUi2i9Luio9uTRIUKxBgF0tDWf7ER/3BWRSO0nTlLzHFuoSvY4vGUZ7q79 VMHiJMuNqTxRjatK8HWtV5WaV7RV75LgZoXhAscjUrmH/KjQbiPTZvMQU8+uYXGdd9 uZtJVde6mnQfC8Xv0fpc+0Z+pofrMubaCBgQfH0E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miquel Raynal , Sasha Levin Subject: [PATCH 4.19 188/206] mtd: rawnand: orion: Fix the probe error path Date: Tue, 23 Jun 2020 21:58:36 +0200 Message-Id: <20200623195326.279247950@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195316.864547658@linuxfoundation.org> References: <20200623195316.864547658@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miquel Raynal [ Upstream commit be238fbf78e4c7c586dac235ab967d3e565a4d1a ] nand_release() is supposed be called after MTD device registration. Here, only nand_scan() happened, so use nand_cleanup() instead. There is no real Fixes tag applying here as the use of nand_release() in this driver predates by far the introduction of nand_cleanup() in commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") which makes this change possible. However, pointing this commit as the culprit for backporting purposes makes sense even if this commit is not introducing any bug. Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") Signed-off-by: Miquel Raynal Cc: stable@vger.kernel.org Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-34-miquel.raynal@bootlin.com Signed-off-by: Sasha Levin --- drivers/mtd/nand/raw/orion_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/orion_nand.c b/drivers/mtd/nand/raw/orion_nand.c index 5c58d91ffaee6..caffebab6c9b1 100644 --- a/drivers/mtd/nand/raw/orion_nand.c +++ b/drivers/mtd/nand/raw/orion_nand.c @@ -181,7 +181,7 @@ static int __init orion_nand_probe(struct platform_device *pdev) mtd->name = "orion_nand"; ret = mtd_device_register(mtd, board->parts, board->nr_parts); if (ret) { - nand_release(nc); + nand_cleanup(nc); goto no_dev; } -- 2.25.1