From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12EAC433E0 for ; Tue, 23 Jun 2020 20:43:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 869CD21927 for ; Tue, 23 Jun 2020 20:43:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945007; bh=jNd3Ur46cox01HltkWv+2q8a/88h4/YW+XlwKdEV6EY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PXyf0TeKvvdNBUKK1gx3wenTAsQ1EVRomOHsPB9gEa8MofNGMMo2ZKX76RozPc08O AxcfVFMvbRVVW2xE30jexq64gwy7KhpvKJEdiNy4BGXJJTF4AyLi+Gt5b5/zaPUJuD JlOGiBFsI0OFz17IFLKMEEv4Jwt3cnzB3HfESki8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392524AbgFWUnY (ORCPT ); Tue, 23 Jun 2020 16:43:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:40144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390278AbgFWUnR (ORCPT ); Tue, 23 Jun 2020 16:43:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CAD252070E; Tue, 23 Jun 2020 20:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944998; bh=jNd3Ur46cox01HltkWv+2q8a/88h4/YW+XlwKdEV6EY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=URdlmxONlPFnontGYRs5WJBmDIBHyb5BTlslOL19XVzhZBbSWx7bxSb4wCQ3BbHqO Kly39wh4zPMIXRye4yvtXSTEWW25RUYZcOiQSy6vxNcf3yyYQJo3cu2oXPg6Hk1R2v cpdEYyoXoOFDqI13bN5Tvpx8PnEEwsp1NAZKJFoo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miquel Raynal , Sasha Levin Subject: [PATCH 4.19 194/206] mtd: rawnand: tmio: Fix the probe error path Date: Tue, 23 Jun 2020 21:58:42 +0200 Message-Id: <20200623195326.568883995@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195316.864547658@linuxfoundation.org> References: <20200623195316.864547658@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miquel Raynal [ Upstream commit 75e9a330a9bd48f97a55a08000236084fe3dae56 ] nand_release() is supposed be called after MTD device registration. Here, only nand_scan() happened, so use nand_cleanup() instead. There is no real Fixes tag applying here as the use of nand_release() in this driver predates by far the introduction of nand_cleanup() in commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") which makes this change possible. However, pointing this commit as the culprit for backporting purposes makes sense even if this commit is not introducing any bug. Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") Signed-off-by: Miquel Raynal Cc: stable@vger.kernel.org Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-57-miquel.raynal@bootlin.com Signed-off-by: Sasha Levin --- drivers/mtd/nand/raw/tmio_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/tmio_nand.c b/drivers/mtd/nand/raw/tmio_nand.c index 39594910e6f04..2a9a966ff2b9e 100644 --- a/drivers/mtd/nand/raw/tmio_nand.c +++ b/drivers/mtd/nand/raw/tmio_nand.c @@ -449,7 +449,7 @@ static int tmio_probe(struct platform_device *dev) if (!retval) return retval; - nand_release(nand_chip); + nand_cleanup(nand_chip); err_irq: tmio_hw_stop(dev, tmio); -- 2.25.1