From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64F52C433DF for ; Wed, 24 Jun 2020 00:21:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3EDB620B80 for ; Wed, 24 Jun 2020 00:21:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388034AbgFXAVZ (ORCPT ); Tue, 23 Jun 2020 20:21:25 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:47114 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387693AbgFXAVX (ORCPT ); Tue, 23 Jun 2020 20:21:23 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jnt9u-0007Sc-28; Wed, 24 Jun 2020 10:20:59 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Wed, 24 Jun 2020 10:20:58 +1000 Date: Wed, 24 Jun 2020 10:20:58 +1000 From: Herbert Xu To: Petr Mladek Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Andy Shevchenko , Sergey Senozhatsky , "Steven Rostedt (VMware)" , Heiko Carstens , Peter Zijlstra Subject: Re: linux-next: build failure after merge of the printk tree Message-ID: <20200624002057.GA12716@gondor.apana.org.au> References: <20200621131554.5a662afe@canb.auug.org.au> <20200623102655.6d16e610@canb.auug.org.au> <20200623121637.GA8444@alley> <20200623121937.GA9671@gondor.apana.org.au> <20200623142858.GB8444@alley> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200623142858.GB8444@alley> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 23, 2020 at 04:28:58PM +0200, Petr Mladek wrote: > > It is similar cycle: > > spinlock_types.h -> lockdep.h -> printk.h -> ratelimit.h -> spinlock_types.h > > But this time it happens via list.h -> kernel.h ->printk.h. > Where list.h needs READ_ONCE() stuff from compiler.h. But this is exactly the loop that's fixed by the lockdep_types patch. Did you get a compile failure with *just* the lockdep patch? > PS: And yes, it makes sense to push both patches via a single tree to > make sure that the lockdep.h split is done first. OK, can I repost this patch with your ack then? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt