All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Amit Daniel Kachhap <amit.kachhap@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Kees Cook <keescook@chromium.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Kristina Martsenko <kristina.martsenko@arm.com>,
	Mark Brown <broonie@kernel.org>,
	James Morse <james.morse@arm.com>,
	Vincenzo Frascino <Vincenzo.Frascino@arm.com>,
	Dave Martin <Dave.Martin@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] arm64: cpufeature: Modify address authentication cpufeature to exact
Date: Wed, 24 Jun 2020 08:49:23 +0100	[thread overview]
Message-ID: <20200624074923.GA5853@willie-the-truck> (raw)
In-Reply-To: <b2268521-9829-8aa5-feca-32a1f6f9e0a5@arm.com>

On Wed, Jun 24, 2020 at 12:43:20PM +0530, Amit Daniel Kachhap wrote:
> On 6/23/20 8:17 PM, Dave Martin wrote:
> > On Tue, Jun 23, 2020 at 06:47:02PM +0530, Amit Daniel Kachhap wrote:
> > > On 6/22/20 8:05 PM, Dave Martin wrote:
> > > > On Thu, Jun 18, 2020 at 10:40:28AM +0530, Amit Daniel Kachhap wrote:
> > > > > This patch modifies the address authentication cpufeature type to EXACT
> > > > >from earlier LOWER_SAFE as the different configurations added for Armv8.6
> > > > > enhanced PAC have different behaviour and there is no tunable to enable the
> > > > > lower safe versions.

$ git grep 'This patch' Documentation/process/submitting-patches.rst

> > > > Does a corresponding patch need to go to stable?  As things stand, I
> > > > think older kernels that support pointer auth will go wrong on v8.7+
> > > > hardware that has these features.
> 
> Yes It makes to add this patch to the stable version.
> 
> @Catalin, @Will - Shall I send this one with a fix subject line? Please let
> me know your suggestion.

What exactly goes wrong? As far as I can tell, we will taint and probably
(?) crash shortly afterwards if you run an old kernel on hardware with
mismatched pointer auth. If that's the case, I don't think this warrants
stable (especially since this file has seen enough churn that the backports
are likely risky).

Can you confirm that things only go wrong if we have a mismatched system,
and ideally provide an example of what the crash looks like (you should
be able to get a fast model to emulate this setup)?

Cheers,

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-06-24  7:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18  5:10 [PATCH v3 0/3] arm64: add Armv8.6 pointer authentication Amit Daniel Kachhap
2020-06-18  5:10 ` [PATCH v3 1/3] arm64: ptrauth: add pointer authentication Armv8.6 enhanced feature Amit Daniel Kachhap
     [not found]   ` <20200622142255.GS25945@arm.com>
     [not found]     ` <d1d3b25d-12d8-15d6-086a-d23b36440dd5@arm.com>
2020-06-23 14:45       ` Dave Martin
2020-06-24  7:07         ` Amit Daniel Kachhap
2020-06-18  5:10 ` [PATCH v3 2/3] arm64: cpufeature: Modify address authentication cpufeature to exact Amit Daniel Kachhap
     [not found]   ` <20200622143503.GT25945@arm.com>
     [not found]     ` <d4e29203-7a6b-c6e5-643c-6b0abc670feb@arm.com>
2020-06-23 14:47       ` Dave Martin
2020-06-24  7:13         ` Amit Daniel Kachhap
2020-06-24  7:49           ` Will Deacon [this message]
2020-06-24 11:55             ` Amit Daniel Kachhap
2020-06-18  5:10 ` [PATCH v3 3/3] arm64: kprobe: disable probe of fault prone ptrauth instruction Amit Daniel Kachhap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200624074923.GA5853@willie-the-truck \
    --to=will@kernel.org \
    --cc=Dave.Martin@arm.com \
    --cc=Vincenzo.Frascino@arm.com \
    --cc=amit.kachhap@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=james.morse@arm.com \
    --cc=keescook@chromium.org \
    --cc=kristina.martsenko@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.