From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: yaminf@mellanox.com, Sagi Grimberg <sagi@grimberg.me>,
idanb@mellanox.com, israelr@mellanox.com,
linux-nvme@lists.infradead.org, shlomin@mellanox.com,
Jason Gunthorpe <jgg@nvidia.com>,
kbusch@kernel.org, ogerlitz@mellanox.com, hch@lst.de
Subject: Re: [PATCH 3/3] nvme-rdma: assign completion vector correctly
Date: Wed, 24 Jun 2020 10:37:43 +0200 [thread overview]
Message-ID: <20200624083743.GA23529@lst.de> (raw)
In-Reply-To: <ec6b1a89-0cc0-1378-6d29-29b9d255c7f5@mellanox.com>
On Wed, Jun 24, 2020 at 11:34:22AM +0300, Max Gurtovoy wrote:
>
> On 6/23/2020 8:34 PM, Sagi Grimberg wrote:
>>
>>>> The completion vector index that is given during CQ creation can't
>>>> exceed the number of support vectors by the underlying RDMA device. This
>>>> violation currently can accure, for example, in case one will try to
>>>> connect with N regular read/write queues and M poll queues and the sum
>>>> of N + M > num_supported_vectors. This will lead to failure in establish
>>>> a connection to remote target. Instead, in that case, share a completion
>>>> vector between queues.
>>>
>>> That sounds like a RC patch? Where is the fixes line? Why is it in
>>> this series?
>>
>> Agree, this should be sent as a separate patch.
>
> The reason I sent it in 1 series is to avoid conflicts. Since all the
> patches can go to nvme-5.8, I tried to make life easier.
>
> We can do it separately of course.
>
> Christoph,
>
> would you like to merge patches 1+2 from this series or should I send them
> again as well ?
I don't think 1+2 are 5.8 material, so please just resend 3 standalone
for now, and then resend 1+2 once I've merged it and rebased nvme-5.9
on top of nvme-5.8.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-06-24 8:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 14:55 [PATCH 0/3] NVMe/RDMA patches for 5.8 Max Gurtovoy
2020-06-23 14:55 ` [PATCH 1/3] nvme-rdma: use new shared CQ mechanism Max Gurtovoy
2020-06-23 14:55 ` [PATCH 2/3] nvmet-rdma: " Max Gurtovoy
2020-06-23 14:55 ` [PATCH 3/3] nvme-rdma: assign completion vector correctly Max Gurtovoy
2020-06-23 15:22 ` Jason Gunthorpe
2020-06-23 17:34 ` Sagi Grimberg
2020-06-24 8:34 ` Max Gurtovoy
2020-06-24 8:37 ` Christoph Hellwig [this message]
2020-06-24 8:44 ` Max Gurtovoy
2020-06-24 8:46 ` Christoph Hellwig
2020-06-24 14:22 ` Jason Gunthorpe
2020-06-24 15:14 ` Max Gurtovoy
2020-06-24 16:41 ` Christoph Hellwig
2020-06-25 8:11 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624083743.GA23529@lst.de \
--to=hch@lst.de \
--cc=idanb@mellanox.com \
--cc=israelr@mellanox.com \
--cc=jgg@nvidia.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
--cc=yaminf@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.