From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D85FAC433E0 for ; Thu, 25 Jun 2020 02:01:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4AB120781 for ; Thu, 25 Jun 2020 02:01:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="eYTYObKf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389269AbgFYCBn (ORCPT ); Wed, 24 Jun 2020 22:01:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389070AbgFYCBm (ORCPT ); Wed, 24 Jun 2020 22:01:42 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 651D1C061573; Wed, 24 Jun 2020 19:01:42 -0700 (PDT) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 068C5521; Thu, 25 Jun 2020 04:01:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1593050499; bh=n97qLVSUqjbZyOpAvOnmnG3JG2QHTee2JfaM1SPPE7w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eYTYObKfLaXx10G1fSq0kO5lf4A7fnCQ8UY+dzN/apx0ih0khJvt8gloGKCFY2TL3 5uHnPBXiDWTXgV7EHW6nLcxxKEEVJH+R8etUpq1097hfdUuL9D5Aa2O2GtX/BBCBBc 0dAe4AKPDCL6MPW0lHBpZ5hF2AxPyrCpKahPqbGI= Date: Thu, 25 Jun 2020 05:01:38 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: Ramzi BEN MEFTAH , niklas soderlund , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , Janusz Krzysztofik , Steve Longerbeam , Ezequiel Garcia , Arnd Bergmann , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Rodin , efriedrich@de.adit-jv.com, erosca@de.adit-jv.com Subject: Re: [PATCH 1/3] v4l2-subdev: Add subdev ioctl support for ENUM/GET/SET INPUT Message-ID: <20200625020138.GW5980@pendragon.ideasonboard.com> References: <1592301619-17631-1-git-send-email-rbmeftah@de.adit-jv.com> <20200624075307.hl6wew7vr5ue225t@uno.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200624075307.hl6wew7vr5ue225t@uno.localdomain> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, On Wed, Jun 24, 2020 at 09:53:07AM +0200, Jacopo Mondi wrote: > On Tue, Jun 16, 2020 at 12:00:15PM +0200, Ramzi BEN MEFTAH wrote: > > From: Steve Longerbeam > > +Niklas, +Laurent > > Niklas, Laurent, how does this play with CAP_IO_MC ? I don't think it's related to CAP_IO_MC, but I don't think it's a good idea either :-) Routing doesn't go through the subdev [gs]_input operations in MC-based drivers. It should be configured through link setup instead. This patch goes in the wrong direction, sorry Steve. > > This commit enables VIDIOC_ENUMINPUT, VIDIOC_G_INPUT, and VIDIOC_S_INPUT > > ioctls for use via v4l2 subdevice node. > > > > This commit should probably not be pushed upstream, because the (old) > > idea of video inputs conflicts with the newer concept of establishing > > media links between src->sink pads. > > > > However it might make sense for some subdevices to support enum/get/set > > inputs. One example would be the analog front end subdevice for the > > ADV748x. By providing these ioctls, selecting the ADV748x analog inputs > > can be done without requiring the implementation of media entities that > > would define the analog source for which to establish a media link. > > > > Signed-off-by: Steve Longerbeam > > --- > > drivers/media/v4l2-core/v4l2-subdev.c | 9 +++++++++ > > include/media/v4l2-subdev.h | 11 +++++++++++ > > 2 files changed, 20 insertions(+) > > > > diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c > > index 6b989fe..73fbfe9 100644 > > --- a/drivers/media/v4l2-core/v4l2-subdev.c > > +++ b/drivers/media/v4l2-core/v4l2-subdev.c > > @@ -378,6 +378,15 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg) > > return -ENOTTY; > > return v4l2_querymenu(vfh->ctrl_handler, arg); > > > > + case VIDIOC_ENUMINPUT: > > + return v4l2_subdev_call(sd, video, enuminput, arg); > > + > > + case VIDIOC_G_INPUT: > > + return v4l2_subdev_call(sd, video, g_input, arg); > > + > > + case VIDIOC_S_INPUT: > > + return v4l2_subdev_call(sd, video, s_input, *(u32 *)arg); > > + > > case VIDIOC_G_CTRL: > > if (!vfh->ctrl_handler) > > return -ENOTTY; > > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h > > index f7fe78a..6e1a9cd 100644 > > --- a/include/media/v4l2-subdev.h > > +++ b/include/media/v4l2-subdev.h > > @@ -383,6 +383,14 @@ struct v4l2_mbus_frame_desc { > > * @g_input_status: get input status. Same as the status field in the > > * &struct &v4l2_input > > * > > + * @enuminput: enumerate inputs. Should return the same input status as > > + * @g_input_status if the passed input index is the currently active > > + * input. > > + * > > + * @g_input: returns the currently active input index. > > + * > > + * @s_input: set the active input. > > + * > > * @s_stream: used to notify the driver that a video stream will start or has > > * stopped. > > * > > @@ -423,6 +431,9 @@ struct v4l2_subdev_video_ops { > > int (*g_tvnorms)(struct v4l2_subdev *sd, v4l2_std_id *std); > > int (*g_tvnorms_output)(struct v4l2_subdev *sd, v4l2_std_id *std); > > int (*g_input_status)(struct v4l2_subdev *sd, u32 *status); > > + int (*enuminput)(struct v4l2_subdev *sd, struct v4l2_input *input); > > + int (*g_input)(struct v4l2_subdev *sd, u32 *index); > > + int (*s_input)(struct v4l2_subdev *sd, u32 index); > > int (*s_stream)(struct v4l2_subdev *sd, int enable); > > int (*g_pixelaspect)(struct v4l2_subdev *sd, struct v4l2_fract *aspect); > > int (*g_frame_interval)(struct v4l2_subdev *sd, -- Regards, Laurent Pinchart