From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 167C0C433E1 for ; Thu, 25 Jun 2020 07:47:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9A3420675 for ; Thu, 25 Jun 2020 07:47:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="UIuIqigV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390363AbgFYHrp (ORCPT ); Thu, 25 Jun 2020 03:47:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390237AbgFYHrn (ORCPT ); Thu, 25 Jun 2020 03:47:43 -0400 Received: from merlin.infradead.org (unknown [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85AC1C061573; Thu, 25 Jun 2020 00:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jlp9yRmob93dOT2KqKFc9+KfQV0pPJXXFdCgHBP2kM0=; b=UIuIqigVl3WX7R1skgg/Iif4x9 hy/pTl2n1RYBArKVSpmY8DjS2unkPxAVMZxi3vZw7HkiMQ+Q+KOu3kiQG6sz78NeMA4DjcPNCGbbC ieWTzZr/0PFbRVojQSNhSqU5Ygr0XL2gN/oeuqxuiR3yrMqgmnRta6jruo86RnRYVv3F8szsLT28j IJP5z91KUq5xvrgosAkmgdhmv1RD+jV8oL87ketaFGyEAK09VPwLfB5LapFSpaYn4XQkDKv3Z97sc mhFdebUs1E6/vlLnkbP5Ta5PkZAqSKNE5SxdS4jK+SauMNXF8v8mFghUbAWe7Ae9OCr1g2cf+23N+ DBACpvNw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1joMbO-0006Qg-LI; Thu, 25 Jun 2020 07:47:18 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id C6AAB3007CD; Thu, 25 Jun 2020 09:47:16 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id B2A1522B8EBE8; Thu, 25 Jun 2020 09:47:16 +0200 (CEST) Date: Thu, 25 Jun 2020 09:47:16 +0200 From: Peter Zijlstra To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 05/22] kbuild: lto: postpone objtool Message-ID: <20200625074716.GX4817@hirez.programming.kicks-ass.net> References: <20200624203200.78870-1-samitolvanen@google.com> <20200624203200.78870-6-samitolvanen@google.com> <20200624211908.GT4817@hirez.programming.kicks-ass.net> <20200624214925.GB120457@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624214925.GB120457@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 24, 2020 at 02:49:25PM -0700, Sami Tolvanen wrote: > On Wed, Jun 24, 2020 at 11:19:08PM +0200, Peter Zijlstra wrote: > > On Wed, Jun 24, 2020 at 01:31:43PM -0700, Sami Tolvanen wrote: > > > diff --git a/include/linux/compiler.h b/include/linux/compiler.h > > > index 30827f82ad62..12b115152532 100644 > > > --- a/include/linux/compiler.h > > > +++ b/include/linux/compiler.h > > > @@ -120,7 +120,7 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int val, > > > /* Annotate a C jump table to allow objtool to follow the code flow */ > > > #define __annotate_jump_table __section(.rodata..c_jump_table) > > > > > > -#ifdef CONFIG_DEBUG_ENTRY > > > +#if defined(CONFIG_DEBUG_ENTRY) || defined(CONFIG_LTO_CLANG) > > > /* Begin/end of an instrumentation safe region */ > > > #define instrumentation_begin() ({ \ > > > asm volatile("%c0:\n\t" \ > > > > Why would you be doing noinstr validation for lto builds? That doesn't > > make sense. > > This is just to avoid a ton of noinstr warnings when we run objtool on > vmlinux.o, but I'm also fine with skipping noinstr validation with LTO. Right, then we need to make --no-vmlinux work properly when !DEBUG_ENTRY, which I think might be buggered due to us overriding the argument when the objname ends with "vmlinux.o". > > > +ifdef CONFIG_STACK_VALIDATION > > > +ifneq ($(SKIP_STACK_VALIDATION),1) > > > +cmd_ld_ko_o += \ > > > + $(objtree)/tools/objtool/objtool \ > > > + $(if $(CONFIG_UNWINDER_ORC),orc generate,check) \ > > > + --module \ > > > + $(if $(CONFIG_FRAME_POINTER),,--no-fp) \ > > > + $(if $(CONFIG_GCOV_KERNEL),--no-unreachable,) \ > > > + $(if $(CONFIG_RETPOLINE),--retpoline,) \ > > > + $(if $(CONFIG_X86_SMAP),--uaccess,) \ > > > + $(@:.ko=$(prelink-ext).o); > > > + > > > +endif # SKIP_STACK_VALIDATION > > > +endif # CONFIG_STACK_VALIDATION > > > > What about the objtool invocation from link-vmlinux.sh ? > > What about it? The existing objtool_link invocation in link-vmlinux.sh > works fine for our purposes as well. Well, I was wondering why you're adding yet another objtool invocation while we already have one. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D7C0C433DF for ; Thu, 25 Jun 2020 07:49:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB1B420675 for ; Thu, 25 Jun 2020 07:49:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vq7Ji9qe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB1B420675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b+Xu2vfbBDSJ2C+v70BWUCov6MJZXClFEC9bJh77zOo=; b=vq7Ji9qeQxXPcIskKvwIGelYc bjNrVvMiPUJwhseMi9Gp3P+w0BHhrs7yVr7oKDjDRnUF/vc6NFqJ8hOxRRRFbUZZQY8vDlM3dPYkE hl8pVieD3+aHzSMoOuxG5JKuxEdI8dQg28LGuiCMjMFZnNzcceCDZm28EqU6MtjFngelSxusKuVb4 Rb21qkzaJ2ab3GV3gTGU6PP4VeEuk+xHkR6Wwe2My2U0Pt9RkrbaQotVxrNAsmatuNy0UD1Pr0zbw K8eh7HHL9ki6FyEPgU3lHGviKtn2nW53vm/9ysy1TCgWTGN9J30WintmInyaLXiwMqJlaRXIE1OZy hpo1+ZpcQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joMbU-0006Sp-HS; Thu, 25 Jun 2020 07:47:24 +0000 Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1joMbO-0006Qg-LI; Thu, 25 Jun 2020 07:47:18 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id C6AAB3007CD; Thu, 25 Jun 2020 09:47:16 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id B2A1522B8EBE8; Thu, 25 Jun 2020 09:47:16 +0200 (CEST) Date: Thu, 25 Jun 2020 09:47:16 +0200 From: Peter Zijlstra To: Sami Tolvanen Subject: Re: [PATCH 05/22] kbuild: lto: postpone objtool Message-ID: <20200625074716.GX4817@hirez.programming.kicks-ass.net> References: <20200624203200.78870-1-samitolvanen@google.com> <20200624203200.78870-6-samitolvanen@google.com> <20200624211908.GT4817@hirez.programming.kicks-ass.net> <20200624214925.GB120457@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624214925.GB120457@google.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, Kees Cook , "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 24, 2020 at 02:49:25PM -0700, Sami Tolvanen wrote: > On Wed, Jun 24, 2020 at 11:19:08PM +0200, Peter Zijlstra wrote: > > On Wed, Jun 24, 2020 at 01:31:43PM -0700, Sami Tolvanen wrote: > > > diff --git a/include/linux/compiler.h b/include/linux/compiler.h > > > index 30827f82ad62..12b115152532 100644 > > > --- a/include/linux/compiler.h > > > +++ b/include/linux/compiler.h > > > @@ -120,7 +120,7 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int val, > > > /* Annotate a C jump table to allow objtool to follow the code flow */ > > > #define __annotate_jump_table __section(.rodata..c_jump_table) > > > > > > -#ifdef CONFIG_DEBUG_ENTRY > > > +#if defined(CONFIG_DEBUG_ENTRY) || defined(CONFIG_LTO_CLANG) > > > /* Begin/end of an instrumentation safe region */ > > > #define instrumentation_begin() ({ \ > > > asm volatile("%c0:\n\t" \ > > > > Why would you be doing noinstr validation for lto builds? That doesn't > > make sense. > > This is just to avoid a ton of noinstr warnings when we run objtool on > vmlinux.o, but I'm also fine with skipping noinstr validation with LTO. Right, then we need to make --no-vmlinux work properly when !DEBUG_ENTRY, which I think might be buggered due to us overriding the argument when the objname ends with "vmlinux.o". > > > +ifdef CONFIG_STACK_VALIDATION > > > +ifneq ($(SKIP_STACK_VALIDATION),1) > > > +cmd_ld_ko_o += \ > > > + $(objtree)/tools/objtool/objtool \ > > > + $(if $(CONFIG_UNWINDER_ORC),orc generate,check) \ > > > + --module \ > > > + $(if $(CONFIG_FRAME_POINTER),,--no-fp) \ > > > + $(if $(CONFIG_GCOV_KERNEL),--no-unreachable,) \ > > > + $(if $(CONFIG_RETPOLINE),--retpoline,) \ > > > + $(if $(CONFIG_X86_SMAP),--uaccess,) \ > > > + $(@:.ko=$(prelink-ext).o); > > > + > > > +endif # SKIP_STACK_VALIDATION > > > +endif # CONFIG_STACK_VALIDATION > > > > What about the objtool invocation from link-vmlinux.sh ? > > What about it? The existing objtool_link invocation in link-vmlinux.sh > works fine for our purposes as well. Well, I was wondering why you're adding yet another objtool invocation while we already have one. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel