From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 360A0C433E0 for ; Thu, 25 Jun 2020 09:43:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1368B20720 for ; Thu, 25 Jun 2020 09:43:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QcPIfJT0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390953AbgFYJnt (ORCPT ); Thu, 25 Jun 2020 05:43:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390531AbgFYJnr (ORCPT ); Thu, 25 Jun 2020 05:43:47 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70FADC061795 for ; Thu, 25 Jun 2020 02:43:47 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id h15so5125228wrq.8 for ; Thu, 25 Jun 2020 02:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MqP8eNt5kwKUBAByimv8vaw/hFZlRD99sPA2Bo3gQ/A=; b=QcPIfJT0OYuMimVCuS3u7waeycKOlpWv1A6SwNnzq88479wkKhcjXVPkab2vluMUX5 LeeTArYmmhswzaY/daOOdr5sF6wdkDWQp17nI/brLbmrDDjepmJdul0+lk+0uX1UxvZr buN0EhR1tUvzo4Z/TumMGB9c57ZCJHgulDKYH/BU9AGQURU7Dld75NtJwyyBlsrabgpG dCWzNGGCrFwBPWctYAT6eG9ugrrhh08GlrzsmMrgGshMttLdCvsa3pwMT3xBVjpgSJKH 7X+DHAadcNLe9HyuDwmDuQxk9yu4mk1E+zQKjoS76LezdLZc2d5mAutvLXMQ6Dehan0v VqCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MqP8eNt5kwKUBAByimv8vaw/hFZlRD99sPA2Bo3gQ/A=; b=MmkLUbt5EL2LusVCwMay9/GIy8IF0eKazP7SYMShzCAeoMZR117KxDCaaQskB6DuVi VlmVjVPHcUlvBo/aqeQ3kcz7a9mt54IKzIrb7N3st52Vvh6/QQAUhXZ6iciVc/LtEHmL 81fJKzIyoQYbn4EEKzosDEM3xXOmUvT+gimBiyki/fCJ/+ZdMpgVa3JNo1NWFMf7EOMT EgTD3WVi6kh2IMk44H5I7x0jyB6BerkQ+DlLyiuCmtHCXhGhF9k6osJh/HWH7YTI521n 4Ts/yfExVCifkTNKqzyuust0t1pD/2C1tYJcxziCiK4YFKpWkoMYbEiti0EqoUn56K+y yuwA== X-Gm-Message-State: AOAM5312XhAL36HnmP/egBhOIXIUNZ/l+li5juFWzls8RClcEPqy2JlR sB7fjd++4qQ+ICOxkOFKj5KvfA== X-Google-Smtp-Source: ABdhPJxi4S3Sc2l8ebR+2X/0lvGbwaCCrXXH0BrvjqecfUvwyNjsH13vgYRHtDkjWkf3uBbECp8RmQ== X-Received: by 2002:a5d:4845:: with SMTP id n5mr19419236wrs.353.1593078226184; Thu, 25 Jun 2020 02:43:46 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id f13sm10976485wmb.33.2020.06.25.02.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 02:43:45 -0700 (PDT) Date: Thu, 25 Jun 2020 10:43:43 +0100 From: Daniel Thompson To: Lee Jones Cc: jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bartlomiej Zolnierkiewicz , Jamey Hicks , Andrew Zabolotny Subject: Re: [PATCH 6/8] backlight: backlight: Supply description for function args in existing Kerneldocs Message-ID: <20200625094343.koh2ln4fy6v6h7mo@holly.lan> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624145721.2590327-7-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624145721.2590327-7-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 24, 2020 at 03:57:19PM +0100, Lee Jones wrote: > Kerneldoc syntax is used, but not complete. Descriptions required. > > Prevents warnings like: > > drivers/video/backlight/backlight.c:329: warning: Function parameter or member 'reason' not described in 'backlight_force_update' > drivers/video/backlight/backlight.c:354: warning: Function parameter or member 'props' not described in 'backlight_device_register' > > Cc: > Cc: Bartlomiej Zolnierkiewicz > Cc: Jamey Hicks > Cc: Andrew Zabolotny > Signed-off-by: Lee Jones Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/backlight.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > index 92d80aa0c0ef1..744ba58488e01 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -320,6 +320,7 @@ ATTRIBUTE_GROUPS(bl_device); > * backlight_force_update - tell the backlight subsystem that hardware state > * has changed > * @bd: the backlight device to update > + * @reason: reason for update > * > * Updates the internal state of the backlight in response to a hardware event, > * and generate a uevent to notify userspace > @@ -344,6 +345,7 @@ EXPORT_SYMBOL(backlight_force_update); > * @devdata: an optional pointer to be stored for private driver use. The > * methods may retrieve it by using bl_get_data(bd). > * @ops: the backlight operations structure. > + * @props: pointer to backlight's properties structure. > * > * Creates and registers new backlight device. Returns either an > * ERR_PTR() or a pointer to the newly allocated device. > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Date: Thu, 25 Jun 2020 09:43:43 +0000 Subject: Re: [PATCH 6/8] backlight: backlight: Supply description for function args in existing Kerneldocs Message-Id: <20200625094343.koh2ln4fy6v6h7mo@holly.lan> List-Id: References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624145721.2590327-7-lee.jones@linaro.org> In-Reply-To: <20200624145721.2590327-7-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lee Jones Cc: linux-fbdev@vger.kernel.org, Andrew Zabolotny , Bartlomiej Zolnierkiewicz , jingoohan1@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jamey Hicks , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org On Wed, Jun 24, 2020 at 03:57:19PM +0100, Lee Jones wrote: > Kerneldoc syntax is used, but not complete. Descriptions required. > > Prevents warnings like: > > drivers/video/backlight/backlight.c:329: warning: Function parameter or member 'reason' not described in 'backlight_force_update' > drivers/video/backlight/backlight.c:354: warning: Function parameter or member 'props' not described in 'backlight_device_register' > > Cc: > Cc: Bartlomiej Zolnierkiewicz > Cc: Jamey Hicks > Cc: Andrew Zabolotny > Signed-off-by: Lee Jones Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/backlight.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > index 92d80aa0c0ef1..744ba58488e01 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -320,6 +320,7 @@ ATTRIBUTE_GROUPS(bl_device); > * backlight_force_update - tell the backlight subsystem that hardware state > * has changed > * @bd: the backlight device to update > + * @reason: reason for update > * > * Updates the internal state of the backlight in response to a hardware event, > * and generate a uevent to notify userspace > @@ -344,6 +345,7 @@ EXPORT_SYMBOL(backlight_force_update); > * @devdata: an optional pointer to be stored for private driver use. The > * methods may retrieve it by using bl_get_data(bd). > * @ops: the backlight operations structure. > + * @props: pointer to backlight's properties structure. > * > * Creates and registers new backlight device. Returns either an > * ERR_PTR() or a pointer to the newly allocated device. > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41507C433DF for ; Thu, 25 Jun 2020 09:45:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EBC720679 for ; Thu, 25 Jun 2020 09:45:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C4rY3BaB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QcPIfJT0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EBC720679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nuL0kGsfNvvSl/qUC+K2KoIH/OaY6P3llWJQUvKTWAU=; b=C4rY3BaB9l+8tsTolqSM2WHUR Z24vKZT82Z/tSiyv1HV9UZG4EtAucrmWUwyqB1s0eNYoT0wDr34o0yIinMBBpf0guRb8nVcS5E5DV 6/8I7FFyWxLLK9wpwQQ7YG00LOWcv12hRIm/o345q3qKvEDDJpg9P6+7IDWKouDAOvR4MIUEe6YY9 ZrBObLRPYwWol4TbCogrN6czYKzwjgcLzAHlg+Cr5WE5V9ONxxU1/tRuTzk0aL9Rk++BoHFnLT1JU COouucsZ4ev1pgf80jPecPiLujdlsV0yOPzuKKN/AJjG1kPhG2/eHCz/2GOPJJc7TJEU7vCfvSzCI umW+MIspw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joOQ9-0007oo-U2; Thu, 25 Jun 2020 09:43:49 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joOQ7-0007ma-50 for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 09:43:47 +0000 Received: by mail-wr1-x442.google.com with SMTP id g18so5162255wrm.2 for ; Thu, 25 Jun 2020 02:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MqP8eNt5kwKUBAByimv8vaw/hFZlRD99sPA2Bo3gQ/A=; b=QcPIfJT0OYuMimVCuS3u7waeycKOlpWv1A6SwNnzq88479wkKhcjXVPkab2vluMUX5 LeeTArYmmhswzaY/daOOdr5sF6wdkDWQp17nI/brLbmrDDjepmJdul0+lk+0uX1UxvZr buN0EhR1tUvzo4Z/TumMGB9c57ZCJHgulDKYH/BU9AGQURU7Dld75NtJwyyBlsrabgpG dCWzNGGCrFwBPWctYAT6eG9ugrrhh08GlrzsmMrgGshMttLdCvsa3pwMT3xBVjpgSJKH 7X+DHAadcNLe9HyuDwmDuQxk9yu4mk1E+zQKjoS76LezdLZc2d5mAutvLXMQ6Dehan0v VqCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MqP8eNt5kwKUBAByimv8vaw/hFZlRD99sPA2Bo3gQ/A=; b=FDXJQYE5SWaY13DjznYOhaHejOEH7m/RTsktiZg16PjROjN/Yj939ffYfOROB6fINM DtoVH1tyPr44180zye9blkmNvw80y3009HNkKZioiUUEh7bNkqQ9DcqNrm5hKYvud1sW Cegufl7cldASPPb+fubQSp0I7BHcCRQAaweV87fyuso0uvw9E4SQsLANhlP8qUgQ41wo Sco061PgoK6eyZx8C1YQOO1oYV7fP+C5KYfFPk5I5U6bzhjZlEPPgex2fWEQyVVr5GHp dEYeTgO3W1lgf3OvmtmWPobiaX87LKfdCM8Q9epQCpvUnMkgKaQcxkoHeeRS3tFkXe+x pnag== X-Gm-Message-State: AOAM533TZPuEqdiQw1rqrCyxW+0DjnTyfkjMFxe4IaDmW1rboZRh8mor dJUHVuqs5P9qNYaEJR73dbe7Kg== X-Google-Smtp-Source: ABdhPJxi4S3Sc2l8ebR+2X/0lvGbwaCCrXXH0BrvjqecfUvwyNjsH13vgYRHtDkjWkf3uBbECp8RmQ== X-Received: by 2002:a5d:4845:: with SMTP id n5mr19419236wrs.353.1593078226184; Thu, 25 Jun 2020 02:43:46 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id f13sm10976485wmb.33.2020.06.25.02.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 02:43:45 -0700 (PDT) Date: Thu, 25 Jun 2020 10:43:43 +0100 From: Daniel Thompson To: Lee Jones Subject: Re: [PATCH 6/8] backlight: backlight: Supply description for function args in existing Kerneldocs Message-ID: <20200625094343.koh2ln4fy6v6h7mo@holly.lan> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624145721.2590327-7-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624145721.2590327-7-lee.jones@linaro.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Andrew Zabolotny , Bartlomiej Zolnierkiewicz , jingoohan1@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jamey Hicks , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 24, 2020 at 03:57:19PM +0100, Lee Jones wrote: > Kerneldoc syntax is used, but not complete. Descriptions required. > > Prevents warnings like: > > drivers/video/backlight/backlight.c:329: warning: Function parameter or member 'reason' not described in 'backlight_force_update' > drivers/video/backlight/backlight.c:354: warning: Function parameter or member 'props' not described in 'backlight_device_register' > > Cc: > Cc: Bartlomiej Zolnierkiewicz > Cc: Jamey Hicks > Cc: Andrew Zabolotny > Signed-off-by: Lee Jones Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/backlight.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > index 92d80aa0c0ef1..744ba58488e01 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -320,6 +320,7 @@ ATTRIBUTE_GROUPS(bl_device); > * backlight_force_update - tell the backlight subsystem that hardware state > * has changed > * @bd: the backlight device to update > + * @reason: reason for update > * > * Updates the internal state of the backlight in response to a hardware event, > * and generate a uevent to notify userspace > @@ -344,6 +345,7 @@ EXPORT_SYMBOL(backlight_force_update); > * @devdata: an optional pointer to be stored for private driver use. The > * methods may retrieve it by using bl_get_data(bd). > * @ops: the backlight operations structure. > + * @props: pointer to backlight's properties structure. > * > * Creates and registers new backlight device. Returns either an > * ERR_PTR() or a pointer to the newly allocated device. > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C06DC433E0 for ; Thu, 25 Jun 2020 09:43:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 034F320720 for ; Thu, 25 Jun 2020 09:43:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QcPIfJT0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 034F320720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE01E6E098; Thu, 25 Jun 2020 09:43:47 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7AD0B6E098 for ; Thu, 25 Jun 2020 09:43:47 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id k6so5151412wrn.3 for ; Thu, 25 Jun 2020 02:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MqP8eNt5kwKUBAByimv8vaw/hFZlRD99sPA2Bo3gQ/A=; b=QcPIfJT0OYuMimVCuS3u7waeycKOlpWv1A6SwNnzq88479wkKhcjXVPkab2vluMUX5 LeeTArYmmhswzaY/daOOdr5sF6wdkDWQp17nI/brLbmrDDjepmJdul0+lk+0uX1UxvZr buN0EhR1tUvzo4Z/TumMGB9c57ZCJHgulDKYH/BU9AGQURU7Dld75NtJwyyBlsrabgpG dCWzNGGCrFwBPWctYAT6eG9ugrrhh08GlrzsmMrgGshMttLdCvsa3pwMT3xBVjpgSJKH 7X+DHAadcNLe9HyuDwmDuQxk9yu4mk1E+zQKjoS76LezdLZc2d5mAutvLXMQ6Dehan0v VqCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MqP8eNt5kwKUBAByimv8vaw/hFZlRD99sPA2Bo3gQ/A=; b=NL/n1nXbLeCkEuMSClK369ShukMVYuzkhlTe2h7uXqrrSpILtA2Ahhapxz6ohsumXR Ah9X6iKqt4VXxDYhSauLjNo5oJKNFSRXPyYbNnAVuAj8AahexkW5XlPtAqu4ZRuwK4iB Ox488IVv1ddu8eh9EutxMh2g/eVUnK59Qa2m2zGqmqixXL5WD6qs/MmA6srGOjMfBXqq gDNh27JthdLwUabRxKqt6yZnZvn8ADFDyhPyRriBm90W1gEQJw415NZQW1CRMeSvoQKv JJZvfybA8JZr3bhUI+g+zz5m4BwVALRW98nmZ1LDaJCEtmTo79LyA0ghiFRG03Np3lLR OQvQ== X-Gm-Message-State: AOAM532Rm85vximB/kNnWSojUYUCyxBhJQKn1PLyPAtfcOrKvUXC8Ets 0EtlWRyWYSfBlHLWFv8myyH4Cg== X-Google-Smtp-Source: ABdhPJxi4S3Sc2l8ebR+2X/0lvGbwaCCrXXH0BrvjqecfUvwyNjsH13vgYRHtDkjWkf3uBbECp8RmQ== X-Received: by 2002:a5d:4845:: with SMTP id n5mr19419236wrs.353.1593078226184; Thu, 25 Jun 2020 02:43:46 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id f13sm10976485wmb.33.2020.06.25.02.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 02:43:45 -0700 (PDT) Date: Thu, 25 Jun 2020 10:43:43 +0100 From: Daniel Thompson To: Lee Jones Subject: Re: [PATCH 6/8] backlight: backlight: Supply description for function args in existing Kerneldocs Message-ID: <20200625094343.koh2ln4fy6v6h7mo@holly.lan> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624145721.2590327-7-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624145721.2590327-7-lee.jones@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Andrew Zabolotny , Bartlomiej Zolnierkiewicz , jingoohan1@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jamey Hicks , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jun 24, 2020 at 03:57:19PM +0100, Lee Jones wrote: > Kerneldoc syntax is used, but not complete. Descriptions required. > > Prevents warnings like: > > drivers/video/backlight/backlight.c:329: warning: Function parameter or member 'reason' not described in 'backlight_force_update' > drivers/video/backlight/backlight.c:354: warning: Function parameter or member 'props' not described in 'backlight_device_register' > > Cc: > Cc: Bartlomiej Zolnierkiewicz > Cc: Jamey Hicks > Cc: Andrew Zabolotny > Signed-off-by: Lee Jones Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/backlight.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > index 92d80aa0c0ef1..744ba58488e01 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -320,6 +320,7 @@ ATTRIBUTE_GROUPS(bl_device); > * backlight_force_update - tell the backlight subsystem that hardware state > * has changed > * @bd: the backlight device to update > + * @reason: reason for update > * > * Updates the internal state of the backlight in response to a hardware event, > * and generate a uevent to notify userspace > @@ -344,6 +345,7 @@ EXPORT_SYMBOL(backlight_force_update); > * @devdata: an optional pointer to be stored for private driver use. The > * methods may retrieve it by using bl_get_data(bd). > * @ops: the backlight operations structure. > + * @props: pointer to backlight's properties structure. > * > * Creates and registers new backlight device. Returns either an > * ERR_PTR() or a pointer to the newly allocated device. > -- > 2.25.1 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel