From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AFE7C433E0 for ; Thu, 25 Jun 2020 17:23:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB4AE20789 for ; Thu, 25 Jun 2020 17:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593105828; bh=CA8sK1iaFslFSn8XGSDmoUdnBkprbim1itFO/LPNh/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bmyzJWRRXPhiua+4dTnbQjn8Xr2aWfbA0Kq7oZsE7wsNjOeCQB9W5u2Fq5wlAB3sn nSCSN2tgEDiIeATrgkJDHtgWE8fwplh9/ECq3FgZrbFxwIH3DQoczL0+XcIrq9qGz4 odp0cFw8WV3rwX772dLT6gSY51Pp7/JB3WOOMrYg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406724AbgFYRXr (ORCPT ); Thu, 25 Jun 2020 13:23:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:48104 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404378AbgFYRXr (ORCPT ); Thu, 25 Jun 2020 13:23:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57D4720773; Thu, 25 Jun 2020 17:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593105826; bh=CA8sK1iaFslFSn8XGSDmoUdnBkprbim1itFO/LPNh/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zvjAC9yYbAgnqLTGPS1P81nV2NWhnDq+aLq1948TpmmXlp9JIBddj6DSbePiKRdzP iy5BNoaAgBHoUFOgS0kGB3GkvEaZumFrUl7SwWZmL4RR43hRLyeYmKCl2GZYUuz4u5 kVEtEG49aDmjyQnuUopYz7ozKlvFsewDUnfTZTho= Date: Thu, 25 Jun 2020 19:23:42 +0200 From: Greg Kroah-Hartman To: Coiby Xu Cc: devel@driverdev.osuosl.org, "supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER" , open list , Manish Chopra , "open list:QLOGIC QLGE 10Gb ETHERNET DRIVER" Subject: Re: [PATCH 2/2] fix else after return or break Message-ID: <20200625172342.GA3965841@kroah.com> References: <20200625153614.63912-1-coiby.xu@gmail.com> <20200625153614.63912-3-coiby.xu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200625153614.63912-3-coiby.xu@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 25, 2020 at 11:36:14PM +0800, Coiby Xu wrote: > Signed-off-by: Coiby Xu > --- > drivers/staging/qlge/qlge_dbg.c | 23 ++++++++++------------- > drivers/staging/qlge/qlge_main.c | 8 ++++---- > drivers/staging/qlge/qlge_mpi.c | 4 ++-- > 3 files changed, 16 insertions(+), 19 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3232C433E0 for ; Thu, 25 Jun 2020 17:23:50 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9480E20773 for ; Thu, 25 Jun 2020 17:23:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zvjAC9yY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9480E20773 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 5E3692052C; Thu, 25 Jun 2020 17:23:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gRYe48MJHXcy; Thu, 25 Jun 2020 17:23:49 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 7832D20532; Thu, 25 Jun 2020 17:23:49 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id BA5681BF336 for ; Thu, 25 Jun 2020 17:23:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id B6DFE8884C for ; Thu, 25 Jun 2020 17:23:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ALd8O5j0Ec4h for ; Thu, 25 Jun 2020 17:23:47 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by hemlock.osuosl.org (Postfix) with ESMTPS id 242FF887D3 for ; Thu, 25 Jun 2020 17:23:47 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57D4720773; Thu, 25 Jun 2020 17:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593105826; bh=CA8sK1iaFslFSn8XGSDmoUdnBkprbim1itFO/LPNh/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zvjAC9yYbAgnqLTGPS1P81nV2NWhnDq+aLq1948TpmmXlp9JIBddj6DSbePiKRdzP iy5BNoaAgBHoUFOgS0kGB3GkvEaZumFrUl7SwWZmL4RR43hRLyeYmKCl2GZYUuz4u5 kVEtEG49aDmjyQnuUopYz7ozKlvFsewDUnfTZTho= Date: Thu, 25 Jun 2020 19:23:42 +0200 From: Greg Kroah-Hartman To: Coiby Xu Subject: Re: [PATCH 2/2] fix else after return or break Message-ID: <20200625172342.GA3965841@kroah.com> References: <20200625153614.63912-1-coiby.xu@gmail.com> <20200625153614.63912-3-coiby.xu@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200625153614.63912-3-coiby.xu@gmail.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, "open list:QLOGIC QLGE 10Gb ETHERNET DRIVER" , "supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER" , open list , Manish Chopra Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, Jun 25, 2020 at 11:36:14PM +0800, Coiby Xu wrote: > Signed-off-by: Coiby Xu > --- > drivers/staging/qlge/qlge_dbg.c | 23 ++++++++++------------- > drivers/staging/qlge/qlge_main.c | 8 ++++---- > drivers/staging/qlge/qlge_mpi.c | 4 ++-- > 3 files changed, 16 insertions(+), 19 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel