From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: David Hildenbrand <david@redhat.com>,
Wei Yang <richard.weiyang@linux.alibaba.com>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oscar Salvador <osalvador@suse.de>, Linux MM <linux-mm@kvack.org>,
Baoquan He <bhe@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/spase: never partially remove memmap for early section
Date: Fri, 26 Jun 2020 06:29:40 +0800 [thread overview]
Message-ID: <20200625222940.GA16822@L-31X9LVDL-1304.local> (raw)
In-Reply-To: <CAPcyv4hnsUoavnzX8q5VReiLXrOsOYW0Ef5GDKxQtS+6pQLy4A@mail.gmail.com>
On Thu, Jun 25, 2020 at 12:46:43PM -0700, Dan Williams wrote:
>On Wed, Jun 24, 2020 at 10:53 PM David Hildenbrand <david@redhat.com> wrote:
>>
>>
>>
>> > Am 25.06.2020 um 01:47 schrieb Dan Williams <dan.j.williams@intel.com>:
>> >
>> > On Wed, Jun 24, 2020 at 3:44 PM Wei Yang
>> > <richard.weiyang@linux.alibaba.com> wrote:
>> > [..]
>> >>> So, you are right that there is a mismatch here, but I think the
>> >>> comprehensive fix is to allow early sections to be partially
>> >>> depopulated/repopulated rather than have section_activate() and
>> >>> section_deacticate() special case early sections. The special casing
>> >>> is problematic in retrospect as section_deactivate() can't be
>> >>> maintained without understand special rules in section_activate().
>> >>
>> >> Hmm... This means we need to adjust pfn_valid() too, which always return true
>> >> for early sections.
>> >
>> > Right, rather than carry workarounds in 3 locations, and the bug that
>> > has resulted from then getting out of sync, just teach early section
>> > mapping to allow for the subsection populate/depopulate.
>> >
>>
>> I prefer the easy fix first - IOW what we Here here. Especially, pfn_to_online_page() will need changes as well.
>
>Agree, yes, let's do the simple fix first for 5.8 and the special-case
>elimination work later.
Ok, let me send v2 with detailed change log and a comment in code first.
Thanks all for your time.
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2020-06-25 22:29 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 9:42 [PATCH] mm/spase: never partially remove memmap for early section Wei Yang
2020-06-23 12:44 ` David Hildenbrand
2020-06-23 13:02 ` Wei Yang
2020-06-23 13:16 ` David Hildenbrand
2020-06-23 15:18 ` Michal Hocko
2020-06-23 21:48 ` Wei Yang
2020-06-24 6:13 ` Wei Yang
2020-06-24 16:10 ` Dan Williams
2020-06-24 16:10 ` Dan Williams
2020-06-24 22:05 ` Wei Yang
2020-06-24 22:20 ` Dan Williams
2020-06-24 22:20 ` Dan Williams
2020-06-24 22:44 ` Wei Yang
2020-06-24 23:47 ` Dan Williams
2020-06-24 23:47 ` Dan Williams
2020-06-25 5:53 ` David Hildenbrand
2020-06-25 19:46 ` Dan Williams
2020-06-25 19:46 ` Dan Williams
2020-06-25 22:29 ` Wei Yang [this message]
2020-06-29 8:34 ` Wei Yang
2020-06-29 22:13 ` Dan Williams
2020-06-29 22:13 ` Dan Williams
2020-06-29 22:58 ` Wei Yang
2020-06-30 7:16 ` David Hildenbrand
2020-06-25 22:39 ` Wei Yang
2020-06-26 4:59 ` David Hildenbrand
2020-06-24 7:48 ` David Hildenbrand
2020-06-24 8:04 ` David Hildenbrand
2020-06-24 8:13 ` Wei Yang
2020-06-24 8:41 ` David Hildenbrand
2020-06-24 8:50 ` Michal Hocko
2020-06-24 22:27 ` Wei Yang
2020-06-24 0:21 ` Dan Williams
2020-06-24 0:21 ` Dan Williams
2020-06-24 1:11 ` Wei Yang
2020-06-24 1:47 ` Baoquan He
2020-06-24 2:14 ` Baoquan He
2020-06-24 3:46 ` Wei Yang
2020-06-24 3:52 ` Baoquan He
2020-06-24 3:56 ` Wei Yang
2020-06-24 8:51 ` David Hildenbrand
2020-06-24 22:08 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625222940.GA16822@L-31X9LVDL-1304.local \
--to=richard.weiyang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.