From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 564A9C433E1 for ; Fri, 26 Jun 2020 09:14:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CC6920675 for ; Fri, 26 Jun 2020 09:14:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbgFZJOc (ORCPT ); Fri, 26 Jun 2020 05:14:32 -0400 Received: from verein.lst.de ([213.95.11.211]:51043 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbgFZJOa (ORCPT ); Fri, 26 Jun 2020 05:14:30 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 8309968CEE; Fri, 26 Jun 2020 11:14:27 +0200 (CEST) Date: Fri, 26 Jun 2020 11:14:27 +0200 From: Christoph Hellwig To: Javier =?iso-8859-1?Q?Gonz=E1lez?= Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@kernel.dk, Javier =?iso-8859-1?Q?Gonz=E1lez?= , SelvaKumar S , Kanchan Joshi , Nitesh Shetty Subject: Re: [PATCH 5/6] block: add zone attr. to zone mgmt IOCTL struct Message-ID: <20200626091427.GC26616@lst.de> References: <20200625122152.17359-1-javier@javigon.com> <20200625122152.17359-6-javier@javigon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200625122152.17359-6-javier@javigon.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org > + * Zone Attributes > + */ > +enum blk_zone_attr { > + BLK_ZONE_ATTR_ZFC = 1 << 0, > + BLK_ZONE_ATTR_FZR = 1 << 1, > + BLK_ZONE_ATTR_RZR = 1 << 2, > + BLK_ZONE_ATTR_ZDEV = 1 << 7, > +}; I have no ^$^$#$%#% idea what this is supposed to be. If you add userspace ABIs you need to document them in detail. Until I've seen that documentation I can't even comment if they make sense. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1833CC433E0 for ; Fri, 26 Jun 2020 11:30:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD7762065F for ; Fri, 26 Jun 2020 11:30:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="chzAaacY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qRUNAiGx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD7762065F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vYbO1NyaFQsvEBMeiZjm0bJGZGseIBveYfLUM4uSz5w=; b=chzAaacYPTRaHpz2dlataCbSN lUO32Rpe9oVVei3M9ZXNDFkRt+gUZYJnhg30osqLvWD5ooKBeb5PSBCcisUdZnfi+sRqmbGz6yojF yIAdusCxyqVhPesfP8sj/fdTVLzcAcJtBDltimDaRg+COzKdFpHPWeTRulG0p+BBXmh6P33jTkvEk um7auv52TJ6tKjyCnLkHR1RkPE1lsGr0W0DB1aybEI7eWRazY4v1GSuHhFygxM6EBkO/YeXBX9w1G Tr/qsIcknakdkeJSzO9UcdcH6a0Odhorv8LZz2/vvQKGRg8ezqoZfv3FIPpE7AveBGuRI0dxU2W3i +iEl0eRtQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomYd-00044y-I8; Fri, 26 Jun 2020 11:30:11 +0000 Received: from casper.infradead.org ([90.155.50.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolGD-0001jR-Ml for linux-nvme@merlin.infradead.org; Fri, 26 Jun 2020 10:07:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZsvEk0Aw5xJ3mAN4FB8GVLYl4pbDcfadUvX721mj6qI=; b=qRUNAiGxyaXDkhmOGFskLEvqOB 9fy+yBo5wqlmnw3YnydxCvGGN7lM5vYl+OtvvbUzq4wOxSn5I0ZCYfKThfGiU0et5esdzKS6RCJWs e3orl1rZcmz161wLxKNMy0mZYRXanHNN2r8xl96y7Sur2rtl919eK74pK7RW0qu184IatfzkYZIvR 3Uza4uG8UxmpoTmflcs8qGRvpGRsteZtzxSgs1mPniOyVUpBCuofJQCojO1Ac7IenLDds4HxN1QMl lPcKDDrnwnygduqLKgSQD6U7raWk70aWRcptcXuWKQcXLAFYNZatFY11fcknMFHGBQG/DlpfzWiCW y96Q2+xA==; Received: from verein.lst.de ([213.95.11.211]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jokYB-0008AU-CJ for linux-nvme@lists.infradead.org; Fri, 26 Jun 2020 09:21:58 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 8309968CEE; Fri, 26 Jun 2020 11:14:27 +0200 (CEST) Date: Fri, 26 Jun 2020 11:14:27 +0200 From: Christoph Hellwig To: Javier =?iso-8859-1?Q?Gonz=E1lez?= Subject: Re: [PATCH 5/6] block: add zone attr. to zone mgmt IOCTL struct Message-ID: <20200626091427.GC26616@lst.de> References: <20200625122152.17359-1-javier@javigon.com> <20200625122152.17359-6-javier@javigon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200625122152.17359-6-javier@javigon.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_102136_183799_9603C721 X-CRM114-Status: GOOD ( 10.55 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, SelvaKumar S , sagi@grimberg.me, Kanchan Joshi , linux-nvme@lists.infradead.org, Nitesh Shetty , linux-block@vger.kernel.org, kbusch@kernel.org, Javier =?iso-8859-1?Q?Gonz=E1lez?= , hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > + * Zone Attributes > + */ > +enum blk_zone_attr { > + BLK_ZONE_ATTR_ZFC = 1 << 0, > + BLK_ZONE_ATTR_FZR = 1 << 1, > + BLK_ZONE_ATTR_RZR = 1 << 2, > + BLK_ZONE_ATTR_ZDEV = 1 << 7, > +}; I have no ^$^$#$%#% idea what this is supposed to be. If you add userspace ABIs you need to document them in detail. Until I've seen that documentation I can't even comment if they make sense. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme