From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DE3BC433E0 for ; Fri, 26 Jun 2020 18:57:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7518520836 for ; Fri, 26 Jun 2020 18:57:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593197828; bh=ga9QcAFBEb/ZaVBLq07Or6LWyuGCp8WUM+IUjs4NkPw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=uMO0pzr0nB9luba43EKkPk2LXrPTRlLEaHGHeZUCNgd4WokiRbkPJyob+yTPflRlo IdDK7FWoQNommjNPknuMer8Dcpa9jCcjApzWjzGJ27NYXAKHylsCGTOOw8XL16INOP 5AQgpZh4HnDvTtI3mUZJMYgiO54mlmkVamosyPyE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725823AbgFZS5H (ORCPT ); Fri, 26 Jun 2020 14:57:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:47470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbgFZS5H (ORCPT ); Fri, 26 Jun 2020 14:57:07 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61B4A2053B; Fri, 26 Jun 2020 18:57:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593197826; bh=ga9QcAFBEb/ZaVBLq07Or6LWyuGCp8WUM+IUjs4NkPw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h4CwIFFYKtIHPlq1qWa2Cz1pvozhKOikliG4LBTz3JZDRxJX4525msu3Bl83hOTtB NWsy0M+IeNLA3s5L1uzorm1Go2GLX8TCMJ3RgupZ1RXxQQPgAvgJINyPvDf4X6yoME ySIOt+Z7Nwoqltc3O2zaSiwCU2aKMkP+SUe0EHGQ= Date: Fri, 26 Jun 2020 11:57:04 -0700 From: Jakub Kicinski To: Jeff Kirsher Cc: davem@davemloft.net, Alice Michael , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, Alan Brady , Phani Burra , Joshua Hay , Madhu Chittim , Pavan Kumar Linga , Donald Skidmore , Jesse Brandeburg , Sridhar Samudrala Subject: Re: [net-next v3 13/15] iecm: Add ethtool Message-ID: <20200626115704.1439eff4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200626020737.775377-14-jeffrey.t.kirsher@intel.com> References: <20200626020737.775377-1-jeffrey.t.kirsher@intel.com> <20200626020737.775377-14-jeffrey.t.kirsher@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 25 Jun 2020 19:07:35 -0700 Jeff Kirsher wrote: > @@ -978,7 +1059,20 @@ static int iecm_open(struct net_device *netdev) > */ > static int iecm_change_mtu(struct net_device *netdev, int new_mtu) > { > - /* stub */ > + struct iecm_vport *vport = iecm_netdev_to_vport(netdev); > + > + if (new_mtu < netdev->min_mtu) { > + netdev_err(netdev, "new MTU invalid. min_mtu is %d\n", > + netdev->min_mtu); > + return -EINVAL; > + } else if (new_mtu > netdev->max_mtu) { > + netdev_err(netdev, "new MTU invalid. max_mtu is %d\n", > + netdev->max_mtu); > + return -EINVAL; > + } Core already checks this. Please remove all checks which core already does. > + netdev->mtu = new_mtu; > + > + return iecm_initiate_soft_reset(vport, __IECM_SR_MTU_CHANGE); > }