From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6640EC433E0 for ; Fri, 26 Jun 2020 19:10:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C4712075A for ; Fri, 26 Jun 2020 19:10:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593198608; bh=bGIb4SrpptDuv4sh91TPMeqb+dnvHN1p3gav+iysFlY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Hpbftc8092bEoMJon9usMFjnU2ho4AYPeOe0XFQk9eyv3Bi/DVTqOFdlRpSYwGbKi +urWCue2j1MZPStIar4EpvNm3/JWmbJy5kxKK4UkzEnMDME0rJRFE+x2bSyxfiD6SY i4uueDG5uBuIQRRr8bdt/x5EiuEaqP9G713nMBO4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726005AbgFZTKH (ORCPT ); Fri, 26 Jun 2020 15:10:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:56908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725792AbgFZTKH (ORCPT ); Fri, 26 Jun 2020 15:10:07 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1891C2053B; Fri, 26 Jun 2020 19:10:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593198606; bh=bGIb4SrpptDuv4sh91TPMeqb+dnvHN1p3gav+iysFlY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qD2+YhsUC0c8GHqJgkYGWnexD0yDWsCOgYr13pnx44b1yUUCOpsZPHkwXpZW7wMGN I54h4Jtw/nn6oN2HNV+RpoUA6wdks505JA5LBiW+yxJO2Pv6eHHcrdD7zOqZWJoLFt uiM59j2OQ9lQfuUbbSunu1s11kTrh1e5oEbfQjvg= Date: Fri, 26 Jun 2020 12:10:04 -0700 From: Jakub Kicinski To: Jeff Kirsher Cc: davem@davemloft.net, Alice Michael , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, Alan Brady , Phani Burra , Joshua Hay , Madhu Chittim , Pavan Kumar Linga , Donald Skidmore , Jesse Brandeburg , Sridhar Samudrala Subject: Re: [net-next v3 06/15] iecm: Implement mailbox functionality Message-ID: <20200626121004.506bfa6f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200626020737.775377-7-jeffrey.t.kirsher@intel.com> References: <20200626020737.775377-1-jeffrey.t.kirsher@intel.com> <20200626020737.775377-7-jeffrey.t.kirsher@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 25 Jun 2020 19:07:28 -0700 Jeff Kirsher wrote: > + err = register_netdev(netdev); > + if (err) > + return err; So the unregister_netdevice() call is in the previous patch, but registering it is apparetnly in the "implement mbox" patch... > + /* carrier off on init to avoid Tx hangs */ > + netif_carrier_off(netdev); > + > + /* make sure transmit queues start off as stopped */ > + netif_tx_stop_all_queues(netdev); Seems like a bad idea to turn the carrier off and stop queues _after_ the netdev is registered. That's a very basic thing to pass 6 authors and 3 reviewers. What am I missing?