From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4B24C433DF for ; Fri, 26 Jun 2020 19:58:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89AF82070A for ; Fri, 26 Jun 2020 19:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593201490; bh=GC2lLesfdJnBgKU0FxJqMOrdz4kBj/wjLgwMjrW1dEc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=WozgJ4xaeApSiRN2emaYm7drZlGzTp0TrrIvDoWzt0liXMp6LFfc2X70WYZC4KhS1 +mUA6UDmBtDoCmOJC8fTH1fh7Rtc85uz/GziKh3pCwpl5pEaVnosGcOke+iBNQeL48 vaMN4estSYrSbJY4Nz4NGtnsDFA16066RwYjlQtc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725821AbgFZT6J (ORCPT ); Fri, 26 Jun 2020 15:58:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:42490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725275AbgFZT6J (ORCPT ); Fri, 26 Jun 2020 15:58:09 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 97541206BE; Fri, 26 Jun 2020 19:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593201489; bh=GC2lLesfdJnBgKU0FxJqMOrdz4kBj/wjLgwMjrW1dEc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HlXcGdaRrnm8G2XVsAWRx678lmEYLuuevvv3fDI2PtGeLSWiBicK/MkuA4xjRUzhq on3Ssq00/pZXQK8Zd2l1H+O1QUxTStM+yEAOgzVzaRsK73sw9KAmmr+q8Hvp3nxgb8 C3jxu1zms7OwKRHH7bZv8d2d4l/B72gGI494OBXk= Date: Fri, 26 Jun 2020 12:58:06 -0700 From: Jakub Kicinski To: Jeff Kirsher Cc: davem@davemloft.net, Alice Michael , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, Alan Brady , Phani Burra , Joshua Hay , Madhu Chittim , Pavan Kumar Linga , Donald Skidmore , Jesse Brandeburg , Sridhar Samudrala Subject: Re: [net-next v3 11/15] iecm: Add splitq TX/RX Message-ID: <20200626125806.0b1831a1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200626020737.775377-12-jeffrey.t.kirsher@intel.com> References: <20200626020737.775377-1-jeffrey.t.kirsher@intel.com> <20200626020737.775377-12-jeffrey.t.kirsher@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 25 Jun 2020 19:07:33 -0700 Jeff Kirsher wrote: > @@ -1315,7 +1489,18 @@ iecm_tx_splitq_clean(struct iecm_queue *tx_q, u16 end, int napi_budget, > */ > static inline void iecm_tx_hw_tstamp(struct sk_buff *skb, u8 *desc_ts) Pretty sure you don't need the inline here. It's static function with one caller. > { > - /* stub */ > + struct skb_shared_hwtstamps hwtstamps; > + u64 tstamp; > + > + /* Only report timestamp to stack if requested */ > + if (!likely(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP)) > + return; > + > + tstamp = (desc_ts[0] | (desc_ts[1] << 8) | (desc_ts[2] & 0x3F) << 16); > + hwtstamps.hwtstamp = > + ns_to_ktime(tstamp << IECM_TW_TIME_STAMP_GRAN_512_DIV_S); > + > + skb_tstamp_tx(skb, &hwtstamps); > } Why is there time stamp reading support if you have no ts_info configuration on ethtool side at all and no PHC support?