Re: [PATCH v3 bpf-next 2/8] bpf: move to generic BTF show support, apply it to seq files/strings

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2116 bytes --]

Hi Alan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Alan-Maguire/bpf-printk-add-BTF-based-type-printing/20200623-201410
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: i386-randconfig-a013-20200624 (attached as .config)
compiler: gcc-6 (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   kernel/bpf/btf.c:4192:2: warning: initialized field overwritten [-Woverride-init]
     0, /* avoid empty array */
     ^
   kernel/bpf/btf.c:4192:2: note: (near initialization for 'bpf_ctx_convert_map[22]')
   kernel/bpf/btf.c:5269:6: warning: no previous prototype for 'btf_type_show' [-Wmissing-prototypes]
    void btf_type_show(const struct btf *btf, u32 type_id, void *obj,
         ^~~~~~~~~~~~~
   kernel/bpf/btf.c: In function 'btf_seq_show':
>> kernel/bpf/btf.c:5286:22: warning: function might be possible candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
     seq_vprintf((struct seq_file *)show->target, fmt, args);
                         ^~~~~~~~
   kernel/bpf/btf.c: In function 'btf_snprintf_show':
   kernel/bpf/btf.c:5316:2: warning: function might be possible candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
     len = vsnprintf(show->target, ssnprintf->len_left, fmt, args);
     ^~~

vim +/gnu_printf +5286 kernel/bpf/btf.c

  5280	
  5281	static void btf_seq_show(struct btf_show *show, const char *fmt, ...)
  5282	{
  5283		va_list args;
  5284	
  5285		va_start(args, fmt);
> 5286		seq_vprintf((struct seq_file *)show->target, fmt, args);
  5287		va_end(args);
  5288	}
  5289	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31592 bytes --]