From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E979BC433DF for ; Sat, 27 Jun 2020 07:57:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF8A520706 for ; Sat, 27 Jun 2020 07:57:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726131AbgF0H5D (ORCPT ); Sat, 27 Jun 2020 03:57:03 -0400 Received: from verein.lst.de ([213.95.11.211]:53949 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725980AbgF0H5C (ORCPT ); Sat, 27 Jun 2020 03:57:02 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 758DF68B02; Sat, 27 Jun 2020 09:56:59 +0200 (CEST) Date: Sat, 27 Jun 2020 09:56:59 +0200 From: Christoph Hellwig To: Ard Biesheuvel Cc: Christoph Hellwig , Andrew Morton , linux-hyperv@vger.kernel.org, Peter Zijlstra , Catalin Marinas , X86 ML , Dexuan Cui , Linux Kernel Mailing List , linux-mm@kvack.org, Jessica Yu , Vitaly Kuznetsov , Will Deacon , Linux ARM Subject: Re: [PATCH 2/3] arm64: use PAGE_KERNEL_ROX directly in alloc_insn_page Message-ID: <20200627075659.GA12509@lst.de> References: <20200618064307.32739-1-hch@lst.de> <20200618064307.32739-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 27, 2020 at 09:34:42AM +0200, Ard Biesheuvel wrote: > > + return __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, VMALLOC_END, > > + GFP_KERNEL, PAGE_KERNEL_ROX, VM_FLUSH_RESET_PERMS, > > + NUMA_NO_NODE, __func__); > > Why is this passing a string for the 'caller' argument, and not the > address of the caller? Dementia. Fix sent. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 511E1C433E0 for ; Sat, 27 Jun 2020 08:01:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EAD220706 for ; Sat, 27 Jun 2020 08:01:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xZ6Y4MaD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EAD220706 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OtEdMJcXbzGmvZcnczIN5wpAzamMH6riB0CyfkmNZEQ=; b=xZ6Y4MaD3YzCRhXvk8Mef5G7e uSio3vKEUaj0Q7/VJCuZ/gY2HiGxQKa+D3SRiPXmJobEoHEFxr9Y+VxGxKl7o0u9Z6qdgvWOP0rjd BJaK6LWCO/4wgqHlVi5DN5ejPgBGIRESlPgqBIQ+7Ki49FywGPMIusPK1VR9+l+UkFFlFSjLXGWBW Pf/3z2ZNAA7Iio5WbdqHsShVxNrx5s4GgZNSl/EpSXDjw8aYrR3QFMS2WekM5vDbAlXxfzPZElscB p+hc+x9JZglopWcaRC33x1Wl1bzuCk7LjxnXS7GybwAJITxUvTPsgY5Q2XRiwQGIYT0Hbpzn5utMy 43rL0JkaQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jp5hw-000476-TK; Sat, 27 Jun 2020 07:57:04 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jp5hu-00046Y-Hi for linux-arm-kernel@lists.infradead.org; Sat, 27 Jun 2020 07:57:03 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 758DF68B02; Sat, 27 Jun 2020 09:56:59 +0200 (CEST) Date: Sat, 27 Jun 2020 09:56:59 +0200 From: Christoph Hellwig To: Ard Biesheuvel Subject: Re: [PATCH 2/3] arm64: use PAGE_KERNEL_ROX directly in alloc_insn_page Message-ID: <20200627075659.GA12509@lst.de> References: <20200618064307.32739-1-hch@lst.de> <20200618064307.32739-3-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, Peter Zijlstra , Catalin Marinas , X86 ML , Dexuan Cui , Linux Kernel Mailing List , Vitaly Kuznetsov , linux-mm@kvack.org, Jessica Yu , Andrew Morton , Will Deacon , Christoph Hellwig , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jun 27, 2020 at 09:34:42AM +0200, Ard Biesheuvel wrote: > > + return __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, VMALLOC_END, > > + GFP_KERNEL, PAGE_KERNEL_ROX, VM_FLUSH_RESET_PERMS, > > + NUMA_NO_NODE, __func__); > > Why is this passing a string for the 'caller' argument, and not the > address of the caller? Dementia. Fix sent. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel