From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7987C433E0 for ; Sat, 27 Jun 2020 10:28:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDDEA208B6 for ; Sat, 27 Jun 2020 10:28:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726424AbgF0K2R (ORCPT ); Sat, 27 Jun 2020 06:28:17 -0400 Received: from smtprelay04.ispgateway.de ([80.67.29.8]:39300 "EHLO smtprelay04.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725994AbgF0K2R (ORCPT ); Sat, 27 Jun 2020 06:28:17 -0400 X-Greylist: delayed 1133 seconds by postgrey-1.27 at vger.kernel.org; Sat, 27 Jun 2020 06:28:16 EDT Received: from [88.130.61.231] (helo=kiste) by smtprelay04.ispgateway.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1jp7lw-0002lF-C5; Sat, 27 Jun 2020 12:09:20 +0200 Date: Sat, 27 Jun 2020 12:09:20 +0200 From: Hans Wippel To: "Jason A. Donenfeld" Cc: WireGuard mailing list , Netdev Subject: Re: wireguard: problem sending via libpcap's packet socket Message-Id: <20200627120920.b4c6af54789b0c09747a92a9@hwipl.net> In-Reply-To: References: <20200626201330.325840-1-ndev@hwipl.net> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Sat__27_Jun_2020_12_09_20_+0200_RA2jFS43=+BYiVsa" X-Df-Sender: bmRldkBod2lwbC5uZXQ= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is a multi-part message in MIME format. --Multipart=_Sat__27_Jun_2020_12_09_20_+0200_RA2jFS43=+BYiVsa Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Hi Jason, thanks for quick replies and patches! For whatever it's worth, I have attached another simple test program to this mail. It opens AF_PACKET sockets without libpcap and (incorrectly) sets the protocol to 0. It works with my ethernet device. Looking at the code, it should also work with the patches you posted. Maybe it is useful for testing some (stupid) corner case. Hans --Multipart=_Sat__27_Jun_2020_12_09_20_+0200_RA2jFS43=+BYiVsa Content-Type: application/octet-stream; name="rawsock.go" Content-Disposition: attachment; filename="rawsock.go" Content-Transfer-Encoding: base64 cGFja2FnZSBtYWluCgppbXBvcnQgKAoJImVuY29kaW5nL2JpbmFyeSIKCSJsb2ciCgkibmV0IgoK CSJnaXRodWIuY29tL2dvb2dsZS9nb3BhY2tldCIKCSJnaXRodWIuY29tL2dvb2dsZS9nb3BhY2tl dC9sYXllcnMiCgkiZ29sYW5nLm9yZy94L3N5cy91bml4IgopCgovLyBSYXdTb2NrZXQgc3RvcmVz IGEgcmF3IHNvY2tldAp0eXBlIFJhd1NvY2tldCBzdHJ1Y3QgewoJZmQgICAgICBpbnQKCWRldk5h bWUgc3RyaW5nCglkZXYgICAgICpuZXQuSW50ZXJmYWNlCglhZGRyICAgICp1bml4LlNvY2thZGRy TGlua2xheWVyCn0KCi8vIENsb3NlIGNsb3NlcyB0aGUgcmF3IHNvY2tldApmdW5jIChyICpSYXdT b2NrZXQpIENsb3NlKCkgewoJdW5peC5DbG9zZShyLmZkKQp9CgovLyBTZW5kIHNlbmRzIGRhdGEg b3V0IG9mIHRoZSByYXcgc29ja2V0CmZ1bmMgKHIgKlJhd1NvY2tldCkgU2VuZChkYXRhIFtdYnl0 ZSkgewoJZXJyIDo9IHVuaXguU2VuZHRvKHIuZmQsIGRhdGEsIDAsIHIuYWRkcikKCWlmIGVyciAh PSBuaWwgewoJCWxvZy5GYXRhbChlcnIpCgl9Cn0KCi8vIGh0b25zIGNvbnZlcnRzIGEgdWludDE2 IHRvIG5ldHdvcmsgYnl0ZSBvcmRlciAoZXhwZWN0cyBsaXR0bGUgZW5kaWFuIHN5c3RlbSkKZnVu YyBodG9ucyh4IHVpbnQxNikgdWludDE2IHsKCWJ1ZiA6PSBtYWtlKFtdYnl0ZSwgMikKCWJpbmFy eS5MaXR0bGVFbmRpYW4uUHV0VWludDE2KGJ1ZiwgeCkKCXJldHVybiBiaW5hcnkuQmlnRW5kaWFu LlVpbnQxNihidWYpCn0KCi8vIE5ld1Jhd1NvY2tldCBjcmVhdGVzIGEgbmV3IHJhdyBzb2NrZXQg Zm9yIGRldmljZQpmdW5jIE5ld1Jhd1NvY2tldChkZXZpY2Ugc3RyaW5nKSAqUmF3U29ja2V0IHsK CS8vIGNyZWF0ZSByYXcgc29ja2V0CglmZCwgZXJyIDo9IHVuaXguU29ja2V0KHVuaXguQUZfUEFD S0VULCB1bml4LlNPQ0tfUkFXLAoJCTApCgkvLyAgICAgIGludChodG9ucyh1bml4LkVUSF9QX0FM TCkpKQoJaWYgZXJyICE9IG5pbCB7CgkJbG9nLkZhdGFsKGVycikKCX0KCgkvLyBnZXQgbG9vcGJh Y2sgaW50ZXJmYWNlCglkZXYsIGVyciA6PSBuZXQuSW50ZXJmYWNlQnlOYW1lKGRldmljZSkKCWlm IGVyciAhPSBuaWwgewoJCWxvZy5GYXRhbChlcnIpCgl9CgoJLy8gY3JlYXRlIHNvY2thZGRyCglh ZGRyIDo9ICZ1bml4LlNvY2thZGRyTGlua2xheWVyewoJCS8vIFByb3RvY29sOiBodG9ucyh1bml4 LkVUSF9QX0lQKSwKCQlJZmluZGV4OiBkZXYuSW5kZXgsCgkJSGFsZW46ICAgNiwKCX0KCgkvLyBj cmVhdGUgcmF3IHNvY2tldCBhbmQgcmV0dXJuIGl0CglyZXR1cm4gJlJhd1NvY2tldHsKCQlmZDog ICAgICBmZCwKCQlkZXZOYW1lOiBkZXZpY2UsCgkJZGV2OiAgICAgZGV2LAoJCWFkZHI6ICAgIGFk ZHIsCgl9Cn0KCi8vIGNyZWF0ZUlQUGFja2V0IGNyZWF0ZXMgYW4gSVAgcGFja2V0CmZ1bmMgY3Jl YXRlSVBQYWNrZXQoZnJvbSwgdG8gbmV0LklQLCBmcm9tUG9ydCwgdG9Qb3J0IGxheWVycy5VRFBQ b3J0KSBbXWJ5dGUgewoJLy8gcHJlcGFyZSBjcmVhdGlvbiBvZiBwYWNrZXQKCW9wdHMgOj0gZ29w YWNrZXQuU2VyaWFsaXplT3B0aW9uc3sKCQlGaXhMZW5ndGhzOiAgICAgICB0cnVlLAoJCUNvbXB1 dGVDaGVja3N1bXM6IHRydWUsCgl9CgoJLy8gY3JlYXRlIGlwIGhlYWRlcgoJaXAgOj0gbGF5ZXJz LklQdjR7CgkJVmVyc2lvbjogIDQsCgkJRmxhZ3M6ICAgIGxheWVycy5JUHY0RG9udEZyYWdtZW50 LAoJCVRUTDogICAgICA2NCwKCQlQcm90b2NvbDogbGF5ZXJzLklQUHJvdG9jb2xVRFAsCgkJU3Jj SVA6ICAgIGZyb20sCgkJRHN0SVA6ICAgIHRvLAoJfQoKCS8vIGNyZWF0ZSB1ZHAgaGVhZGVyCgl1 ZHAgOj0gbGF5ZXJzLlVEUHsKCQlTcmNQb3J0OiBmcm9tUG9ydCwKCQlEc3RQb3J0OiB0b1BvcnQs Cgl9Cgl1ZHAuU2V0TmV0d29ya0xheWVyRm9yQ2hlY2tzdW0oJmlwKQoKCS8vIGNyZWF0ZSBwYXls b2FkCglwYXlsb2FkIDo9IFtdYnl0ZXsxLCAyLCAzLCA0LCA1LCA2LCA3LCA4LCA5LCAxMCwgMTEs IDEyLCAxMywgMTQsIDE1fQoKCS8vIHNlcmlhbGl6ZSBwYWNrZXQgdG8gYnVmZmVyCgl2YXIgZXJy IGVycm9yCglidWYgOj0gZ29wYWNrZXQuTmV3U2VyaWFsaXplQnVmZmVyKCkKCXBsIDo9IGdvcGFj a2V0LlBheWxvYWQocGF5bG9hZCkKCWVyciA9IGdvcGFja2V0LlNlcmlhbGl6ZUxheWVycyhidWYs IG9wdHMsICZpcCwgJnVkcCwgcGwpCglpZiBlcnIgIT0gbmlsIHsKCQlsb2cuRmF0YWwoZXJyKQoJ fQoKCXJldHVybiBidWYuQnl0ZXMoKQp9CgovLyBjcmVhdGVFdGhlcm5ldFBhY2tldCBjcmVhdGVz IGFuIGV0aGVybmV0IHBhY2tldCB3aXRoIGFuIElQIHBhY2tldApmdW5jIGNyZWF0ZUV0aGVybmV0 UGFja2V0KGZyb21NQUMsIHRvTUFDIHN0cmluZywgaXBQYWNrZXQgW11ieXRlKSBbXWJ5dGUgewoJ Ly8gcHJlcGFyZSBjcmVhdGlvbiBvZiBwYWNrZXQKCW9wdHMgOj0gZ29wYWNrZXQuU2VyaWFsaXpl T3B0aW9uc3sKCQlGaXhMZW5ndGhzOiAgICAgICB0cnVlLAoJCUNvbXB1dGVDaGVja3N1bXM6IHRy dWUsCgl9CgoJLy8gY3JlYXRlIGV0aGVybmV0IGhlYWRlcgoJc3JjTUFDLCBlcnIgOj0gbmV0LlBh cnNlTUFDKGZyb21NQUMpCglpZiBlcnIgIT0gbmlsIHsKCQlsb2cuRmF0YWwoZXJyKQoJfQoJZHN0 TUFDLCBlcnIgOj0gbmV0LlBhcnNlTUFDKHRvTUFDKQoJaWYgZXJyICE9IG5pbCB7CgkJbG9nLkZh dGFsKGVycikKCX0KCWV0aCA6PSBsYXllcnMuRXRoZXJuZXR7CgkJU3JjTUFDOiAgICAgICBzcmNN QUMsCgkJRHN0TUFDOiAgICAgICBkc3RNQUMsCgkJRXRoZXJuZXRUeXBlOiBsYXllcnMuRXRoZXJu ZXRUeXBlSVB2NCwKCX0KCgkvLyBzZXJpYWxpemUgcGFja2V0IHRvIGJ1ZmZlcgoJYnVmIDo9IGdv cGFja2V0Lk5ld1NlcmlhbGl6ZUJ1ZmZlcigpCglwbCA6PSBnb3BhY2tldC5QYXlsb2FkKGlwUGFj a2V0KQoJZXJyID0gZ29wYWNrZXQuU2VyaWFsaXplTGF5ZXJzKGJ1Ziwgb3B0cywgJmV0aCwgcGwp CglpZiBlcnIgIT0gbmlsIHsKCQlsb2cuRmF0YWwoZXJyKQoJfQoKCXJldHVybiBidWYuQnl0ZXMo KQp9CgpmdW5jIG1haW4oKSB7CgkvLyBjcmVhdGUgd2lyZWd1YXJkIHNvY2tldAoJZGV2aWNlIDo9 ICJ3ZzAiCglzb2NrIDo9IE5ld1Jhd1NvY2tldChkZXZpY2UpCgoJLy8gY3JlYXRlIHBhY2tldAoJ ZnJvbSA6PSBuZXQuSVB2NCgxOTIsIDE2OCwgMSwgMSkKCXRvIDo9IG5ldC5JUHY0KDE5MiwgMTY4 LCAxLCAxKQoJZnJvbVBvcnQgOj0gbGF5ZXJzLlVEUFBvcnQoMTIzNCkKCXRvUG9ydCA6PSBsYXll cnMuVURQUG9ydCgxMjM0KQoJcGFja2V0IDo9IGNyZWF0ZUlQUGFja2V0KGZyb20sIHRvLCBmcm9t UG9ydCwgdG9Qb3J0KQoKCS8vIHNlbmQgcGFja2V0IGFuZCBjbG9zZSBzb2NrZXQKCXNvY2suU2Vu ZChwYWNrZXQpCglzb2NrLkNsb3NlKCkKCgkvLyBjcmVhdGUgZXRoZXJuZXQgc29ja2V0CglkZXZp Y2UgPSAiZXRoMCIKCXNvY2sgPSBOZXdSYXdTb2NrZXQoZGV2aWNlKQoKCS8vIGNyZWF0ZSBwYWNr ZXQKCWZyb20gPSBuZXQuSVB2NCgxOTIsIDE2OCwgMSwgMSkKCXRvID0gbmV0LklQdjQoMTkyLCAx NjgsIDEsIDEpCglmcm9tUG9ydCA9IGxheWVycy5VRFBQb3J0KDEyMzQpCgl0b1BvcnQgPSBsYXll cnMuVURQUG9ydCgxMjM0KQoJZnJvbU1BQyA6PSAiMDA6MDA6NWU6MDA6NTM6MDEiCgl0b01BQyA6 PSAiZmY6ZmY6ZmY6ZmY6ZmY6ZmYiCglwYWNrZXQgPSBjcmVhdGVJUFBhY2tldChmcm9tLCB0bywg ZnJvbVBvcnQsIHRvUG9ydCkKCXBhY2tldCA9IGNyZWF0ZUV0aGVybmV0UGFja2V0KGZyb21NQUMs IHRvTUFDLCBwYWNrZXQpCgoJLy8gc2VuZCBwYWNrZXQgYW5kIGNsb3NlIHNvY2tldAoJc29jay5T ZW5kKHBhY2tldCkKCXNvY2suQ2xvc2UoKQp9Cg== --Multipart=_Sat__27_Jun_2020_12_09_20_+0200_RA2jFS43=+BYiVsa--