[PATCH] fscache: fix bugon.cocci warnings

From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] fscache: fix bugon.cocci warnings
Date: Sat, 27 Jun 2020 23:14:10 +0800	[thread overview]
Message-ID: <20200627151410.GA26948@651fe2006c6f> (raw)
In-Reply-To: <202006272346.voedACJD%lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

CC: kbuild-all(a)lists.01.org
TO: David Howells <dhowells@redhat.com>

From: kernel test robot <lkp@intel.com>

fs/fscache/read_helper.c:88:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG.
Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)

 Use BUG_ON instead of a if condition followed by BUG.

Semantic patch information:
 This makes an effort to find cases where BUG() follows an if
 condition on an expression and replaces the if condition and BUG()
 with a BUG_ON having the conditional expression of the if statement
 as argument.

Generated by: scripts/coccinelle/misc/bugon.cocci

Fixes: 2c7d3b597c2d ("fscache: Add read helper")
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git fscache-iter
head:   fef70d709fde3f284e93e5baae6591f90e6e4a95
commit: 2c7d3b597c2d56663f17fb0c9921158e5304de04 [38/59] fscache: Add read helper
:::::: branch date: 20 hours ago
:::::: commit date: 23 hours ago

Please take the patch only if it's a positive warning. Thanks!

 read_helper.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/fs/fscache/read_helper.c
+++ b/fs/fscache/read_helper.c
@@ -84,8 +84,7 @@ static void fscache_read_copy_to_cache(s
 
 	BUG_ON(work_pending(&req->work));
 	INIT_WORK(&req->work, fscache_do_read_copy_to_cache);
-	if (!queue_work(fscache_op_wq, &req->work))
-		BUG();
+	BUG_ON(!queue_work(fscache_op_wq, &req->work));
 }
 
 /*
