All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	ben.widawsky@intel.com, alex.shi@linux.alibaba.com,
	tobin@kernel.org, cl@linux.com, akpm@linux-foundation.org,
	stable@kernel.org
Subject: Re: [PATCH] mm/vmscan: restore zone_reclaim_mode ABI
Date: Mon, 29 Jun 2020 09:13:38 +0200	[thread overview]
Message-ID: <20200629071338.m4veigbp4tu45gbz@beryllium.lan> (raw)
In-Reply-To: <83731eeb-1f64-50b7-41e9-5b7114678533@intel.com>

Hi Dave,

On Fri, Jun 26, 2020 at 06:53:33AM -0700, Dave Hansen wrote:
> Was there something else specifically in the documentation which you
> think I've neglected?

The first paragraph explains how you ended up modifying the code. While
I understand that you want to document the process, it wont help
a reader in future. It doesn't add any intersting information at all.
Just state what you're doing as first thing and explain why you are
doing it after it.

> > I think the documentation update should not be part of this patch.
> > This makes the back porting to stable more difficult.
> 
> Really?  If a backporter doesn't care about documentation, I'd just
> expect them to see the reject, ignore it, and move on with their life.
> If they do, they'd want the code fix and the Documentation/ update in
> the same patch so that they don't get disconnected.

I understood you are fixing a regression ingroduced by a previous change. In
this case I would only fix the regression. Updating/improving the
documentation is good, I just don't think it's necessary to back port it to
stables trees along side the bug fix.

Thanks,
Daniel

  reply	other threads:[~2020-06-29 19:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26  0:34 [PATCH] mm/vmscan: restore zone_reclaim_mode ABI Dave Hansen
2020-06-26  0:34 ` Dave Hansen
2020-06-26  7:59 ` Daniel Wagner
2020-06-26 13:53   ` Dave Hansen
2020-06-29  7:13     ` Daniel Wagner [this message]
2020-06-29 14:36       ` Dave Hansen
2020-06-29 15:53         ` Daniel Wagner
2020-06-29 16:05           ` Dave Hansen
2020-06-26 19:24 ` Qian Cai
2020-06-26 21:24   ` Dave Hansen
2020-06-29  6:52 ` Baoquan He
2020-06-29 14:27   ` Dave Hansen
2020-06-29 23:30     ` Baoquan He
2020-06-29 23:37       ` Dave Hansen
2020-07-01  2:47         ` Andrew Morton
2020-07-01 15:27           ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200629071338.m4veigbp4tu45gbz@beryllium.lan \
    --to=dwagner@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alex.shi@linux.alibaba.com \
    --cc=ben.widawsky@intel.com \
    --cc=cl@linux.com \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=stable@kernel.org \
    --cc=tobin@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.