From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A33A3C433E0 for ; Mon, 29 Jun 2020 07:47:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76C5023330 for ; Mon, 29 Jun 2020 07:47:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76C5023330 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC7DB89E9E; Mon, 29 Jun 2020 07:46:59 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id B296A89E9E for ; Mon, 29 Jun 2020 07:46:57 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id C8CB220023; Mon, 29 Jun 2020 09:46:55 +0200 (CEST) Date: Mon, 29 Jun 2020 09:46:54 +0200 From: Sam Ravnborg To: Emil Velikov Subject: Re: [PATCH 2/3] drm/panel: use mipi_dsi_dcs_write_buffer where possible Message-ID: <20200629074654.GC227119@ravnborg.org> References: <20200505160329.2976059-1-emil.l.velikov@gmail.com> <20200505160329.2976059-2-emil.l.velikov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=QX4gbG5DAAAA:8 a=NXpJzYs8AAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=PWEOW87Kur7FUUydQVUA:9 a=CjuIK1q_8ugA:10 a=AbAUZ8qAyYyZVLSsDulk:22 a=cwV61pgf2j4Cq8VD9hE_:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Thierry Reding , ML dri-devel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, May 11, 2020 at 12:28:40PM +0100, Emil Velikov wrote: > On Tue, 5 May 2020 at 17:05, Emil Velikov wrote: > > > > From: Emil Velikov > > > > A few of the new panels create a local macro wrapping around > > mipi_dsi_dcs_write. At the same time, they don't really care about the > > command/payload split. > > > > mipi_dsi_dcs_write does a kmalloc/memcpy/kfree for payload > 7 bytes. > > kmalloc - avoid that all together by using the _buffer function. > > > Seems like I've left an extra word here - will fix in v2, alongside > any review feedback. > s/kmalloc - avoid/Avoid/ > > > Aside: > > panel-xinpeng-xpp055c272.c calls its wrapper "generic" although it > > should be "dcs". But that for another day/patch. > > > > Cc: Heiko Stuebner > > Cc: Heiko Stuebner > > Cc: Thierry Reding > > Cc: Sam Ravnborg > > Signed-off-by: Emil Velikov Fixed up changelog when applied to drm-misc-next. Sam > > --- > > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 4 ++-- > > drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 4 ++-- > > drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c | 4 ++-- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/panel/panel-elida-kd35t133.c b/drivers/gpu/drm/panel/panel-elida-kd35t133.c > > index 711ded453c44..00e3d67af812 100644 > > --- a/drivers/gpu/drm/panel/panel-elida-kd35t133.c > > +++ b/drivers/gpu/drm/panel/panel-elida-kd35t133.c > > @@ -52,9 +52,9 @@ static inline struct kd35t133 *panel_to_kd35t133(struct drm_panel *panel) > > } > > > > #define dsi_dcs_write_seq(dsi, cmd, seq...) do { \ > > - static const u8 d[] = { seq }; \ > > + static const u8 b[] = { cmd, seq }; \ > > int ret; \ > > - ret = mipi_dsi_dcs_write(dsi, cmd, d, ARRAY_SIZE(d)); \ > > + ret = mipi_dsi_dcs_write_buffer(dsi, b, ARRAY_SIZE(b)); \ > > if (ret < 0) \ > > return ret; \ > > } while (0) > > diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c > > index 5a7a31c8513e..eaa9da3ebbea 100644 > > --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c > > +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c > > @@ -246,9 +246,9 @@ struct ltk050h3146w *panel_to_ltk050h3146w(struct drm_panel *panel) > > } > > > > #define dsi_dcs_write_seq(dsi, cmd, seq...) do { \ > > - static const u8 d[] = { seq }; \ > > + static const u8 b[] = { cmd, seq }; \ > > int ret; \ > > - ret = mipi_dsi_dcs_write(dsi, cmd, d, ARRAY_SIZE(d)); \ > > + ret = mipi_dsi_dcs_write_buffer(dsi, b, ARRAY_SIZE(b)); \ > > if (ret < 0) \ > > return ret; \ > > } while (0) > > diff --git a/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c b/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c > > index 1645aceab597..9e07d7e86807 100644 > > --- a/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c > > +++ b/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c > > @@ -62,9 +62,9 @@ static inline struct xpp055c272 *panel_to_xpp055c272(struct drm_panel *panel) > > } > > > > #define dsi_generic_write_seq(dsi, cmd, seq...) do { \ > > - static const u8 d[] = { seq }; \ > > + static const u8 b[] = { cmd, seq }; \ > > int ret; \ > > - ret = mipi_dsi_dcs_write(dsi, cmd, d, ARRAY_SIZE(d)); \ > > + ret = mipi_dsi_dcs_write_buffer(dsi, b, ARRAY_SIZE(b)); \ > > if (ret < 0) \ > > return ret; \ > > } while (0) > > -- > > 2.25.1 > > > > Humble poke? > > -Emil > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel