CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Linus Walleij <linus.walleij@linaro.org>
CC: Nicolas Pitre <nico@fluxnic.net>
CC: Jakub Kicinski <kuba@kernel.org>
CC: "Michael S. Tsirkin" <mst@redhat.com>
CC: Shannon Nelson <snelson@pensando.io>
CC: Markus Elfring <elfring@users.sourceforge.net>
CC: Martin Habets <mhabets@solarflare.com>
CC: netdev(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/net/ethernet/smsc/smc91x.c:2001:10-30: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

 Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
 threaded IRQs without a primary handler need to be requested with
 IRQF_ONESHOT, otherwise the request will fail.

 So pass the IRQF_ONESHOT flag in this case.

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

Fixes: 75ac9d5e2268 ("SMSC slask")
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git nomadik-nhk15-smsc
head:   75ac9d5e2268a8506be065fbacd25197135527bb
commit: 75ac9d5e2268a8506be065fbacd25197135527bb [3/3] SMSC slask
:::::: branch date: 15 hours ago
:::::: commit date: 15 hours ago

Please take the patch only if it's a positive warning. Thanks!

 smc91x.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -1998,7 +1998,9 @@ static int smc_probe(struct net_device *
 
 	/* Grab the IRQ */
 	irq_flags |= IRQF_ONESHOT;
-	retval = request_threaded_irq(dev->irq, NULL, smc_interrupt, irq_flags, dev->name, dev);
+	retval = request_threaded_irq(dev->irq, NULL, smc_interrupt,
+				      irq_flags | IRQF_ONESHOT, dev->name,
+				      dev);
       	if (retval)
       		goto err_out;